]> git-server-git.apps.pok.os.sepia.ceph.com Git - xfsprogs-dev.git/commitdiff
xfs_scrub: warn about incomplete repairs if we never get to them
authorDarrick J. Wong <djwong@kernel.org>
Wed, 24 Jun 2026 18:16:04 +0000 (11:16 -0700)
committerAndrey Albershteyn <aalbersh@kernel.org>
Thu, 25 Jun 2026 13:42:53 +0000 (15:42 +0200)
If the final pass at repairs fails because the kernel says the
filesystem is busy, we should emit this error to the caller instead of
dropping it silently.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
scrub/repair.c

index 5d821655877b8079e728c432f635ec4d9c154988..fdefc2131aa453617de857c6ed09ec4fa34d2faa 100644 (file)
@@ -110,7 +110,10 @@ repair_epilogue(
        case EDEADLOCK:
        case EBUSY:
                /* Filesystem is busy, try again later. */
-               if (debug || verbose)
+               if (repair_flags & XRM_FINAL_WARNING)
+                       str_error(ctx, descr_render(dsc),
+_("Filesystem is busy, repair incomplete."));
+               else if (debug || verbose)
                        str_info(ctx, descr_render(dsc),
 _("Filesystem is busy, deferring repair."));
                return 0;