]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
rgw: PublicAccessConfiguration -> PublicAccessBlockConfiguration
authorAbhishek Lekshmanan <abhishek@suse.com>
Wed, 16 Oct 2019 11:22:09 +0000 (13:22 +0200)
committerAbhishek Lekshmanan <abhishek@suse.com>
Mon, 3 Feb 2020 16:53:34 +0000 (17:53 +0100)
also drop iam namespace

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
src/rgw/rgw_common.h
src/rgw/rgw_op.cc
src/rgw/rgw_op.h
src/rgw/rgw_public_access.cc
src/rgw/rgw_public_access.h

index 7410f468c1aece9f93278036ebf08d05a4f13957..1eb40997d1bc5a38e95925b1750c729a2ee96128 100644 (file)
@@ -1695,7 +1695,7 @@ struct req_state : DoutPrefixProvider {
 
   rgw::IAM::Environment env;
   boost::optional<rgw::IAM::Policy> iam_policy;
-  boost::optional<rgw::IAM::PublicAccessConfiguration> bucket_access_conf;
+  boost::optional<PublicAccessBlockConfiguration> bucket_access_conf;
   vector<rgw::IAM::Policy> iam_user_policies;
 
   /* Is the request made by an user marked as a system one?
index 0c3354303ea26d346d26e6b7166fa9d098026365..6509d6b0eaae31d612c7f254bfc824d94d812e53 100644 (file)
@@ -86,7 +86,6 @@ using rgw::IAM::Effect;
 using rgw::IAM::Policy;
 
 using rgw::IAM::Policy;
-using rgw::IAM::PublicAccessConfiguration;
 
 static string mp_ns = RGW_OBJ_NS_MULTIPART;
 static string shadow_ns = RGW_OBJ_NS_SHADOW;
@@ -295,13 +294,13 @@ static boost::optional<Policy> get_iam_policy_from_attr(CephContext* cct,
   }
 }
 
-static boost::optional<PublicAccessConfiguration>
+static boost::optional<PublicAccessBlockConfiguration>
 get_public_access_conf_from_attr(const map<string, bufferlist>& attrs)
 {
   if (auto aiter = attrs.find(RGW_ATTR_PUBLIC_ACCESS);
       aiter != attrs.end()) {
     bufferlist::const_iterator iter{&aiter->second};
-    PublicAccessConfiguration access_conf;
+    PublicAccessBlockConfiguration access_conf;
     try {
       access_conf.decode(iter);
     } catch (const buffer::error& e) {
index 882bd94957936d013f9e8701d83fa6f2bc49c2a3..906b26d236996a0d5e70a4a2bbd84e228182e244 100644 (file)
@@ -2400,7 +2400,7 @@ public:
 class RGWPutBucketPublicAccessBlock : public RGWOp {
 protected:
   bufferlist data;
-  rgw::IAM::PublicAccessConfiguration access_conf;
+  PublicAccessBlockConfiguration access_conf;
 public:
   int verify_permission() override;
   const char* name() const override { return "put_bucket_public_access_block";}
@@ -2413,7 +2413,7 @@ public:
 
 class RGWGetBucketPublicAccessBlock : public RGWOp {
 protected:
-  rgw::IAM::PublicAccessConfiguration access_conf;
+  PublicAccessBlockConfiguration access_conf;
 public:
   int verify_permission() override;
   const char* name() const override { return "get_bucket_public_access_block";}
@@ -2426,7 +2426,7 @@ public:
 
 class RGWDeleteBucketPublicAccessBlock : public RGWOp {
 protected:
-  rgw::IAM::PublicAccessConfiguration access_conf;
+  PublicAccessBlockConfiguration access_conf;
 public:
   int verify_permission() override;
   const char* name() const override { return "delete_bucket_public_access_block";}
index c36f779d220aef80516e699cce9300c5b82f269c..3197b75c522bc38a4c0edd979ed725d9444a2e48 100644 (file)
@@ -1,17 +1,15 @@
 #include "rgw_public_access.h"
 #include "rgw_xml.h"
 
-namespace rgw::IAM {
-
-void PublicAccessConfiguration::decode_xml(XMLObj *obj) {
+void PublicAccessBlockConfiguration::decode_xml(XMLObj *obj) {
   RGWXMLDecoder::decode_xml("BlockPublicAcls", BlockPublicAcls, obj);
   RGWXMLDecoder::decode_xml("IgnorePublicAcls", IgnorePublicAcls, obj);
   RGWXMLDecoder::decode_xml("BlockPublicPolicy", BlockPublicPolicy, obj);
   RGWXMLDecoder::decode_xml("RestrictPublicBuckets", RestrictPublicBuckets, obj);
 }
 
-void PublicAccessConfiguration::dump_xml(Formatter *f) const {
-  Formatter::ObjectSection os(*f, "BlockPublicAccessConfiguration");
+void PublicAccessBlockConfiguration::dump_xml(Formatter *f) const {
+  Formatter::ObjectSection os(*f, "BlockPublicAccessBlockConfiguration");
   // AWS spec mentions the values to be ALL CAPs, but clients will not
   // understand this or a mixed case like it is supposed to, hence the need to
   // manually encode here
@@ -24,7 +22,7 @@ void PublicAccessConfiguration::dump_xml(Formatter *f) const {
 }
 
 
-ostream& operator<< (ostream& os, const PublicAccessConfiguration& access_conf)
+ostream& operator<< (ostream& os, const PublicAccessBlockConfiguration& access_conf)
 {
     os << std::boolalpha
        << "BlockPublicAcls: " << access_conf.block_public_acls() << std::endl
@@ -35,4 +33,3 @@ ostream& operator<< (ostream& os, const PublicAccessConfiguration& access_conf)
     return os;
 }
 
-} // namespace rgw::IAM
index b0253a5b1b0d16ad78e6a3c96173ff81aa365574..c7d68c8c30cd4c97cca29b79baa3a9536d352594 100644 (file)
 
 class XMLObj;
 
-namespace rgw::IAM {
-
-class PublicAccessConfiguration {
+class PublicAccessBlockConfiguration {
   bool BlockPublicAcls;
   bool IgnorePublicAcls;
   bool BlockPublicPolicy;
   bool RestrictPublicBuckets;
  public:
- PublicAccessConfiguration():
+ PublicAccessBlockConfiguration():
    BlockPublicAcls(false), IgnorePublicAcls(false),
   BlockPublicPolicy(false), RestrictPublicBuckets(false)
     {}
@@ -65,6 +63,5 @@ class PublicAccessConfiguration {
   void decode_xml(XMLObj *obj);
   void dump_xml(Formatter *f) const;
 };
-WRITE_CLASS_ENCODER(PublicAccessConfiguration)
-ostream& operator<< (ostream& os, const PublicAccessConfiguration& access_conf);
-} // namespace rgw::IAM
+WRITE_CLASS_ENCODER(PublicAccessBlockConfiguration)
+ostream& operator<< (ostream& os, const PublicAccessBlockConfiguration& access_conf);