]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commitdiff
Fix ldb --try_load_options doesn't use customized Env (#8929)
authorsdong <siying.d@fb.com>
Fri, 17 Sep 2021 21:43:53 +0000 (14:43 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Fri, 17 Sep 2021 22:26:27 +0000 (15:26 -0700)
Summary:
As title. The reason is that after loading customized options, the env is not set back to the correct one. Fix it.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/8929

Test Plan: Manually validate in an environment where the command failed.

Reviewed By: riversand963

Differential Revision: D31026931

fbshipit-source-id: c25dc788bf80ed5bf4b24922c442781943bcd65b

tools/ldb_cmd.cc

index b3d443c461b8321f9fb97551afd0c02f38dc8c19..891149fc6ba164cbbf7c15d785847c57e2ebeaab 100644 (file)
@@ -722,6 +722,10 @@ void LDBCommand::PrepareOptions() {
     }
   }
 
+  if (options_.env == Env::Default()) {
+    options_.env = config_options_.env;
+  }
+
   OverrideBaseOptions();
   if (exec_state_.IsFailed()) {
     return;