rgw/kafka: remove potential race condition between creation and deletion of endpoint

Fixes: https://tracker.ceph.com/issues/61254
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>

diff --git a/src/rgw/rgw_kafka.cc b/src/rgw/rgw_kafka.cc
index 163b242d5c022063167b228ee9f656fd9bdb197b..b4c0ffa24cbb1f8e09b3837f5993066c18f214fa 100644 (file)
--- a/src/rgw/rgw_kafka.cc
+++ b/src/rgw/rgw_kafka.cc
@@ -482,6 +482,7 @@ private:
         if(conn->timestamp.sec() + max_idle_time < ceph_clock_now()) {
           ldout(conn->cct, 20) << "kafka run: deleting a connection due to idle behaviour: " << ceph_clock_now() << dendl;
           conn->destroy(STATUS_CONNECTION_IDLE);
+          std::lock_guard lock(connections_lock);
           conn_it = connections.erase(conn_it);
           --connection_count; \
           continue;