tmpfs does not support fallocate

Summary: This caused Siying's unit test to fail.

Test Plan: Unittest

Reviewers: dhruba, kailiu, haobo

Reviewed By: dhruba

CC: leveldb
Differential Revision: https://reviews.facebook.net/D13539

diff --git a/util/blob_store.cc b/util/blob_store.cc
index 694787210b40d9fd981229b45ef9a9efa198ea14..168a6d74a777e4c63c74092bc2b9d15a72dd13e9 100644 (file)
--- a/util/blob_store.cc
+++ b/util/blob_store.cc
@@ -261,7 +261,10 @@ Status BlobStore::Allocate(uint32_t blocks, Blob* blob) {
 
   s = free_list_.Allocate(blocks, blob);
   if (!s.ok()) {
-    CreateNewBucket();
+    s = CreateNewBucket();
+    if (!s.ok()) {
+      return s;
+    }
     s = free_list_.Allocate(blocks, blob);
   }
 
@@ -284,12 +287,8 @@ Status BlobStore::CreateNewBucket() {
     return s;
   }
 
-  s = buckets_[new_bucket_id].get()->Allocate(
-      0, block_size_ * blocks_per_bucket_);
-  if (!s.ok()) {
-    buckets_.erase(buckets_.begin() + new_bucket_id);
-    return s;
-  }
+  // tmpfs does not support allocate
+  buckets_[new_bucket_id].get()->Allocate(0, block_size_ * blocks_per_bucket_);
 
   return free_list_.Free(Blob(new_bucket_id, 0, blocks_per_bucket_));
 }