mds: prevent new wrlocks on LocalLock if there exists any xlock waiter

Otherwise, an xlock waiter can become starved as a LocalLock supports multiple
writers.

Strictly speaking, a new lock state would be appropriate for this but we cheat
frequently with the LocalLock -- there is only one state. All transition checks
are already manually performed by the Locker.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

diff --git a/src/mds/LocalLockC.h b/src/mds/LocalLockC.h
index 4d26a1c3e14299c917a26d652e3c240f89723e47..a4df37bbcfed55fcd2b91af460e03587789e7c42 100644 (file)
--- a/src/mds/LocalLockC.h
+++ b/src/mds/LocalLockC.h
@@ -34,7 +34,7 @@ public:
   }
 
   bool can_wrlock() const {
-    return !is_xlocked();
+    return !is_xlocked() && !is_waiter_for(SimpleLock::WAIT_XLOCK);
   }
   void get_wrlock(client_t client) {
     ceph_assert(can_wrlock());