librbd/cache/pwl: WriteLogOperationSet::cell can be garbage

The pointer is never initialized but gets printed by operator<<.
Luckily outside of that it's unused.

Fixes: https://tracker.ceph.com/issues/74971
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

diff --git a/src/librbd/cache/pwl/LogOperation.cc b/src/librbd/cache/pwl/LogOperation.cc
index 8e5f6673439cebca333c5a5a87fcf8660d9d1cbc..61ba1b3724a3e58571c5d649e4e6684f7d14df54 100644 (file)
--- a/src/librbd/cache/pwl/LogOperation.cc
+++ b/src/librbd/cache/pwl/LogOperation.cc
@@ -268,8 +268,7 @@ WriteLogOperationSet::~WriteLogOperationSet() { }
 
 std::ostream &operator<<(std::ostream &os,
                          const WriteLogOperationSet &s) {
-  os << "cell=" << (void*)s.cell
-     << ", extent_ops_appending=" << s.extent_ops_appending
+  os << "extent_ops_appending=" << s.extent_ops_appending
      << ", extent_ops_persist=" << s.extent_ops_persist;
   return os;
 }

diff --git a/src/librbd/cache/pwl/LogOperation.h b/src/librbd/cache/pwl/LogOperation.h
index 8ecd53d198d2023c9f0b2c7007906e64a8e75afc..7cb98cbe17bc9e8cfb1b89b665a45c74a2102ddb 100644 (file)
--- a/src/librbd/cache/pwl/LogOperation.h
+++ b/src/librbd/cache/pwl/LogOperation.h
@@ -169,7 +169,6 @@ private:
   Context *m_on_finish;
 public:
   bool persist_on_flush;
-  BlockGuardCell *cell;
   C_Gather *extent_ops_appending;
   Context *on_ops_appending;
   C_Gather *extent_ops_persist;