]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
script/ceph-backport.sh: adjust to change in github API
authorNathan Cutler <ncutler@suse.com>
Sat, 10 Nov 2018 10:07:29 +0000 (11:07 +0100)
committerNathan Cutler <ncutler@suse.com>
Sat, 10 Nov 2018 10:07:29 +0000 (11:07 +0100)
This curl command was working fine before, but recently it started
throwing the following error:

+ curl --silent --data-binary
'{"milestone":"$milestone_number","assignee":"smithfarm","labels":["bug
fix","core"]}'
'https://api.github.com/repos/ceph/ceph/issues/25018?access_token=8ecba7355a11fab00365e44fece350bf01388553'
{
  "message": "Invalid request.\n\nFor 'properties/milestone',
\"$milestone_number\" is not an integer or null.",
  "documentation_url": "https://developer.github.com/v3"
}

Signed-off-by: Nathan Cutler <ncutler@suse.com>
src/script/ceph-backport.sh

index 7f49fdab907b824c9c16dfbd3cef3553e0caf6df..8e62a310f75ebfcc776484d7cc61ba11d6bb38a9 100755 (executable)
@@ -124,7 +124,7 @@ git push -u origin wip-$issue-$milestone
 number=$(curl --silent --data-binary '{"title":"'"$title"'","head":"'$github_user':wip-'$issue-$milestone'","base":"'$target_branch'","body":"http://tracker.ceph.com/issues/'$issue'"}' 'https://api.github.com/repos/ceph/ceph/pulls?access_token='$github_token | jq .number)
 echo "Opened pull request $number"
 
-component=core ; curl --silent --data-binary '{"milestone":"'$milestone_number'","assignee":"'$github_user'","labels":["bug fix","'$component'"]}' 'https://api.github.com/repos/ceph/ceph/issues/'$number'?access_token='$github_token
+component=core ; curl --silent --data-binary '{"milestone":'$milestone_number',"assignee":"'$github_user'","labels":["bug fix","'$component'"]}' 'https://api.github.com/repos/ceph/ceph/issues/'$number'?access_token='$github_token
 firefox https://github.com/ceph/ceph/pull/$number
 redmine_status=2 # In Progress
 curl --verbose -X PUT --header 'Content-type: application/json' --data-binary '{"issue":{"description":"https://github.com/ceph/ceph/pull/'$number'","status_id":'$redmine_status',"assigned_to_id":'$redmine_user_id'}}' 'http://tracker.ceph.com/issues/'$issue.json?key=$redmine_key