mds: move EMetaBlob cons to header

Also, remove unused mdlog parameter.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

diff --git a/src/mds/events/EExport.h b/src/mds/events/EExport.h
index 9c53c447a909da97ce4d07f1271eb84d673bb314..1de05449c180df208efee11219990058859dff26 100644 (file)
--- a/src/mds/events/EExport.h
+++ b/src/mds/events/EExport.h
@@ -35,7 +35,7 @@ public:
   EExport() :
     LogEvent(EVENT_EXPORT), target(MDS_RANK_NONE) { }
   EExport(MDLog *mdlog, CDir *dir, mds_rank_t t) :
-    LogEvent(EVENT_EXPORT), metablob(mdlog),
+    LogEvent(EVENT_EXPORT),
     base(dir->dirfrag()), target(t) { }
   
   set<dirfrag_t> &get_bounds() { return bounds; }

diff --git a/src/mds/events/EFragment.h b/src/mds/events/EFragment.h
index 2ebf0812df57b1e0d9f5def2fa3e6437f09129b8..aa3ed0ba897b0c30fec459dbf3135c007f5577e9 100644 (file)
--- a/src/mds/events/EFragment.h
+++ b/src/mds/events/EFragment.h
@@ -38,7 +38,7 @@ public:
 
   EFragment() : LogEvent(EVENT_FRAGMENT) { }
   EFragment(MDLog *mdlog, int o, dirfrag_t df, int b) :
-    LogEvent(EVENT_FRAGMENT), metablob(mdlog), 
+    LogEvent(EVENT_FRAGMENT),
     op(o), ino(df.ino), basefrag(df.frag), bits(b) { }
 
   void print(ostream& out) const override {

diff --git a/src/mds/events/EImportStart.h b/src/mds/events/EImportStart.h
index ab83df91741755b7d683989262877ae28263f3e0..970b35faab97767a79c333aace26a6f94c041ef5 100644 (file)
--- a/src/mds/events/EImportStart.h
+++ b/src/mds/events/EImportStart.h
@@ -37,7 +37,7 @@ public:
 
   EImportStart(MDLog *log, dirfrag_t di, vector<dirfrag_t>& b, mds_rank_t f) :
     LogEvent(EVENT_IMPORTSTART),
-    base(di), bounds(b), from(f), metablob(log) { }
+    base(di), bounds(b), from(f) { }
   EImportStart() :
     LogEvent(EVENT_IMPORTSTART), from(MDS_RANK_NONE) { }
   

diff --git a/src/mds/events/EMetaBlob.h b/src/mds/events/EMetaBlob.h
index 28db4fc2b0e6ea3f85ce02f6398455a3f11cbd5f..c9ab9dde531696fa861bc2e2948ffc63785702df 100644 (file)
--- a/src/mds/events/EMetaBlob.h
+++ b/src/mds/events/EMetaBlob.h
@@ -335,7 +335,10 @@ private:
   // for replay, in certain cases
   //LogSegment *_segment;
 
-  explicit EMetaBlob(MDLog *mdl = 0);  // defined in journal.cc
+  EMetaBlob() : opened_ino(0), renamed_dirino(0),
+                inotablev(0), sessionmapv(0), allocated_ino(0),
+                last_subtree_map(0), event_seq(0)
+                {}
   ~EMetaBlob() { }
 
   void print(ostream& out) {

diff --git a/src/mds/events/EOpen.h b/src/mds/events/EOpen.h
index b529f05c78702894d77549f74431b92d6781b3ef..655f97841fd507abdff9fd83e2a42e16fe916fc7 100644 (file)
--- a/src/mds/events/EOpen.h
+++ b/src/mds/events/EOpen.h
@@ -26,7 +26,7 @@ public:
 
   EOpen() : LogEvent(EVENT_OPEN) { }
   explicit EOpen(MDLog *mdlog) :
-    LogEvent(EVENT_OPEN), metablob(mdlog) { }
+    LogEvent(EVENT_OPEN) { }
 
   void print(ostream& out) const override {
     out << "EOpen " << metablob << ", " << inos.size() << " open files";

diff --git a/src/mds/events/ESlaveUpdate.h b/src/mds/events/ESlaveUpdate.h
index ea1fa3acf772eb04b79509f6b3c89876b16a1fb8..28e19822f0b2fa7a1f933017662411e407000f03 100644 (file)
--- a/src/mds/events/ESlaveUpdate.h
+++ b/src/mds/events/ESlaveUpdate.h
@@ -120,7 +120,7 @@ public:
 
   ESlaveUpdate() : LogEvent(EVENT_SLAVEUPDATE), master(0), op(0), origop(0) { }
   ESlaveUpdate(MDLog *mdlog, const char *s, metareqid_t ri, int mastermds, int o, int oo) : 
-    LogEvent(EVENT_SLAVEUPDATE), commit(mdlog), 
+    LogEvent(EVENT_SLAVEUPDATE),
     type(s),
     reqid(ri),
     master(mastermds),

diff --git a/src/mds/events/EUpdate.h b/src/mds/events/EUpdate.h
index c4ef5627fd8ac2615c8af4e08db53f9823710ed6..ed3eb3617a2f105abd1ce40697e1ceb4abbc1aa7 100644 (file)
--- a/src/mds/events/EUpdate.h
+++ b/src/mds/events/EUpdate.h
@@ -29,7 +29,7 @@ public:
 
   EUpdate() : LogEvent(EVENT_UPDATE), cmapv(0), had_slaves(false) { }
   EUpdate(MDLog *mdlog, const char *s) : 
-    LogEvent(EVENT_UPDATE), metablob(mdlog),
+    LogEvent(EVENT_UPDATE),
     type(s), cmapv(0), had_slaves(false) { }
   
   void print(ostream& out) const override {

diff --git a/src/mds/journal.cc b/src/mds/journal.cc
index b63fbd980c8b0808518fc825281a2aea12809a3b..c659c2e7b12bfa2926e8e8e19643b5946844d21c 100644 (file)
--- a/src/mds/journal.cc
+++ b/src/mds/journal.cc
@@ -299,11 +299,6 @@ void LogSegment::try_to_expire(MDSRank *mds, MDSGatherBuilder &gather_bld, int o
 // -----------------------
 // EMetaBlob
 
-EMetaBlob::EMetaBlob(MDLog *mdlog) : opened_ino(0), renamed_dirino(0),
-                                    inotablev(0), sessionmapv(0), allocated_ino(0),
-                                    last_subtree_map(0), event_seq(0)
-{ }
-
 void EMetaBlob::add_dir_context(CDir *dir, int mode)
 {
   MDSRank *mds = dir->cache->mds;