]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
osd/PrimaryLogPG: kill obsolete ondisk_{read,write}_lock comments
authorxie xingguo <xie.xingguo@zte.com.cn>
Sat, 17 Aug 2019 07:19:46 +0000 (15:19 +0800)
committerxie xingguo <xie.xingguo@zte.com.cn>
Sat, 17 Aug 2019 07:19:46 +0000 (15:19 +0800)
The ondisk_{read,write}_lock infrastructure was long gone with
https://github.com/ceph/ceph/pull/20177 merged - c244300ef33a044ad71fea7d92d77f33b5d41851,
to be specific. Hence the related comments must die since they
could be super-misleading.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
src/osd/PrimaryLogPG.cc

index 23f6dc5221154437eba00f8cfb36c65d3a210d89..a1e04de867b7ec9ab40954de33da37a2d544530f 100644 (file)
@@ -12631,11 +12631,6 @@ int PrimaryLogPG::prep_object_replica_pushes(
   ceph_assert(!recovering.count(soid));
   recovering.insert(make_pair(soid, obc));
 
-  /* We need this in case there is an in progress write on the object.  In fact,
-   * the only possible write is an update to the xattr due to a lost_revert --
-   * a client write would be blocked since the object is degraded.
-   * In almost all cases, therefore, this lock should be uncontended.
-   */
   int r = pgbackend->recover_object(
     soid,
     v,
@@ -13191,7 +13186,6 @@ int PrimaryLogPG::prep_backfill_object_push(
   start_recovery_op(oid);
   recovering.insert(make_pair(oid, obc));
 
-  // We need to take the read_lock here in order to flush in-progress writes
   int r = pgbackend->recover_object(
     oid,
     v,