]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commitdiff
iio: chemical: sps30_serial: fix buffer size in sps30_serial_read_meas()
authorAntoniu Miclaus <antoniu.miclaus@analog.com>
Thu, 12 Feb 2026 12:46:08 +0000 (14:46 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 23 Feb 2026 08:24:38 +0000 (08:24 +0000)
sizeof(num) evaluates to sizeof(size_t) which is 8 bytes on 64-bit,
but the buffer elements are only 4 bytes. The same function already
uses sizeof(*meas) on line 312, making the mismatch evident. Use
sizeof(*meas) consistently.

Fixes: b2e171f5a5c6 ("iio: sps30: add support for serial interface")
Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
Acked-by: Tomasz Duszynski <tduszyns@gmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/chemical/sps30_serial.c

index 008bc88590f37017a0da53a34c14bbc8ec78383c..a5e6bc08d5fd41500419754ae009548a5bd29e0d 100644 (file)
@@ -303,7 +303,7 @@ static int sps30_serial_read_meas(struct sps30_state *state, __be32 *meas, size_
        if (msleep_interruptible(1000))
                return -EINTR;
 
-       ret = sps30_serial_command(state, SPS30_SERIAL_READ_MEAS, NULL, 0, meas, num * sizeof(num));
+       ret = sps30_serial_command(state, SPS30_SERIAL_READ_MEAS, NULL, 0, meas, num * sizeof(*meas));
        if (ret < 0)
                return ret;
        /* if measurements aren't ready sensor returns empty frame */