]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ansible.git/commitdiff
common: fix retry on raw install python for rhel
authorGuillaume Abrioux <gabrioux@redhat.com>
Fri, 22 Feb 2019 17:17:25 +0000 (18:17 +0100)
committermergify[bot] <mergify[bot]@users.noreply.github.com>
Mon, 25 Feb 2019 10:05:34 +0000 (10:05 +0000)
when the following failure is thrown
```
    rhel-8.0.0-beta-1.7-     [===                 ] ---  B/s |   0  B     --:-- ETArhel-8.0.0-beta-1.7-appstream                   0.0  B/s |   0  B     00:00
    rhel-8.0.0-beta-1.7-     [===                 ] ---  B/s |   0  B     --:-- ETArhel-8.0.0-beta-1.7-baseos                      0.0  B/s |   0  B     00:00
    rhel-8.0.0-beta-1.7-     [   ===              ] ---  B/s |   0  B     --:-- ETArhel-8.0.0-beta-1.7-builder                     0.0  B/s |   0  B     00:00
    Failed to synchronize cache for repo 'rhel-8.0.0-beta-1.7-appstream', ignoring this repo.
    Failed to synchronize cache for repo 'rhel-8.0.0-beta-1.7-baseos', ignoring this repo.
    Failed to synchronize cache for repo 'rhel-8.0.0-beta-1.7-builder', ignoring this repo.
    No match for argument: python3
    Error: Unable to find a match
```

dnf returns 0 anyway.

Let's ensure the pattern 'Failed' isn't present in the output.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
raw_install_python.yml

index 7c9ab15d04ecd40e41a8655efa843371353a49f3..cd274ee6346a1ef7693805b0a70252c372217273 100644 (file)
@@ -19,7 +19,7 @@
   register: result
   when:
     - systempython.stat is undefined or not systempython.stat.exists
-  until: (result is succeeded) or ('Failed' not in result.stdout)
+  until: (result is succeeded) and ('Failed' not in result.stdout)
 
 - name: install python for opensuse
   raw: zypper -n install python-base creates=/usr/bin/python2.7