Make logging to a file optional

Signed-off-by: Zack Cerza <zack@redhat.com>

diff --git a/cephmetrics/__init__.py b/cephmetrics/__init__.py
index 1409100c940ae1dee7cb87bcb8734e5137cd0720..324c620844d9ee212b82b92bd0c98feedecd9b7d 100644 (file)
--- a/cephmetrics/__init__.py
+++ b/cephmetrics/__init__.py
@@ -124,17 +124,21 @@ def configure_callback(conf):
         collectd.error("ClusterName is required")
 
 
-def setup_module_logging(log_level):
+def setup_module_logging(log_level, path='/var/log/collectd-cephmetrics.log'):
 
     level = {"debug": logging.DEBUG,
              "info": logging.INFO}
 
     logging.getLogger('cephmetrics')
-    logging.basicConfig(filename='/var/log/collectd-cephmetrics.log',
-                        format='%(asctime)s - %(levelname)-7s - '
-                               '[%(filename)s:%(lineno)s:%(funcName)s() - '
-                               '%(message)s',
-                        level=level.get(log_level))
+    log_conf = dict(
+        format='%(asctime)s - %(levelname)-7s - '
+               '[%(filename)s:%(lineno)s:%(funcName)s() - '
+               '%(message)s',
+        level=level.get(log_level)
+    )
+    if path:
+        log_conf['filename'] = path
+    logging.basicConfig(**log_conf)
 
 
 def read_callback():