crimson/osd: avoid creating a throw-away object

for better readabilty and performnce

Signed-off-by: Kefu Chai <kchai@redhat.com>

diff --git a/src/crimson/osd/pg_backend.cc b/src/crimson/osd/pg_backend.cc
index e46c9372f7e0377adf4886da1f0f5c310fb74e20..cd08b87edc872f5f4e35da69d3fe1355e92d85f2 100644 (file)
--- a/src/crimson/osd/pg_backend.cc
+++ b/src/crimson/osd/pg_backend.cc
@@ -757,13 +757,11 @@ seastar::future<> PGBackend::setxattr(
 
   maybe_create_new_object(os, txn);
 
-  std::string name;
+  std::string name{"_"};
   ceph::bufferlist val;
   {
     auto bp = osd_op.indata.cbegin();
-    std::string aname;
-    bp.copy(osd_op.op.xattr.name_len, aname);
-    name = "_" + aname;
+    bp.copy(osd_op.op.xattr.name_len, name);
     bp.copy(osd_op.op.xattr.value_len, val);
     osd_op.indata.splice(0, bp.get_off());
   }