]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
os/bluestore/BlockDevice: init rotational
authorSage Weil <sage@redhat.com>
Mon, 28 Nov 2016 18:44:05 +0000 (13:44 -0500)
committerSage Weil <sage@redhat.com>
Mon, 28 Nov 2016 18:44:05 +0000 (13:44 -0500)
CID 1396126 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member rotational is not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Sage Weil <sage@redhat.com>
src/os/bluestore/BlockDevice.h
src/os/bluestore/KernelDevice.cc

index 305d86f1d79b29ae6ef98505bd5bf37eee5d6c21..ba5b7facd2065ff3b81cc717c89f70585e65f163 100644 (file)
@@ -73,7 +73,7 @@ class BlockDevice {
   std::atomic_int ioc_reap_count = {0};
 
 protected:
-  bool rotational;
+  bool rotational = true;
 
 public:
   BlockDevice() = default;
index b49032b2405788fd256c2336e403e7b2debbf6ca..7aa1b452785841a5f78389321a3012d79d88df51 100644 (file)
@@ -46,7 +46,6 @@ KernelDevice::KernelDevice(aio_callback_t cb, void *cbpriv)
 {
   zeros = buffer::create_page_aligned(1048576);
   zeros.zero();
-  rotational = true;
 }
 
 int KernelDevice::_lock()