mon/MonmapMonitor: [Cleanup] Revmove redundant access specifier, etc

Signed-off-by: Shinobu Kinjo <shinobu@redhat.com>

diff --git a/src/mon/MonmapMonitor.cc b/src/mon/MonmapMonitor.cc
index fae36d6177f27f871b50aa3debcb7d17782b553d..88e5e1731a36ae37dd4c018583c0ada8917bc88d 100644 (file)
--- a/src/mon/MonmapMonitor.cc
+++ b/src/mon/MonmapMonitor.cc
@@ -281,7 +281,7 @@ bool MonmapMonitor::preprocess_command(MonOpRequestRef op)
       p->decode(bl);
     }
 
-    assert(p != NULL);
+    assert(p);
 
     if (prefix == "mon getmap") {
       p->encode(rdata, m->get_connection()->get_features());
@@ -308,8 +308,10 @@ bool MonmapMonitor::preprocess_command(MonOpRequestRef op)
       rdata.append(ds);
       ss << "dumped monmap epoch " << p->get_epoch();
     }
-    if (p != mon->monmap)
+    if (p != mon->monmap) {
        delete p;
+       p = nullptr;
+    }
 
   } else if (prefix == "mon feature ls") {
    

diff --git a/src/mon/MonmapMonitor.h b/src/mon/MonmapMonitor.h
index e3e01173b6ee58b9190aa7c8c61b533e6ab6fc68..360b7c73deba03c5731fb6702bd56e267b5e0a4e 100644 (file)
--- a/src/mon/MonmapMonitor.h
+++ b/src/mon/MonmapMonitor.h
@@ -22,8 +22,6 @@
 #include <map>
 #include <set>
 
-using namespace std;
-
 #include "include/types.h"
 #include "msg/Messenger.h"
 
@@ -80,8 +78,6 @@ class MonmapMonitor : public PaxosService {
 
 private:
   void check_subs();
-
-private:
   bufferlist monmap_bl;
 };