]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
osd/PG: do not check for empty before loop
authorKefu Chai <kchai@redhat.com>
Sat, 8 May 2021 08:34:03 +0000 (16:34 +0800)
committerKefu Chai <kchai@redhat.com>
Sat, 8 May 2021 08:34:09 +0000 (16:34 +0800)
simpler this way.

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/osd/PG.cc

index 23edfaeaf1dcab890efc505916217a93930420c6..82c2bf2bf8fd01f2d686f9a29c65938209efd063 100644 (file)
@@ -2668,15 +2668,13 @@ std::pair<ghobject_t, bool> PG::do_delete_work(
       max,
       &olist,
       &next);
-    if (!olist.empty()) {
-      for (auto& oid : olist) {
-        if (oid == pgmeta_oid) {
-          dout(20) << __func__ << " removing pgmeta object " << oid << dendl;
-        } else {
-          dout(0) << __func__ << " additional unexpected onode"
-                  <<" new onode has appeared since PG removal started"
-                  << oid << dendl;
-        }
+    for (auto& oid : olist) {
+      if (oid == pgmeta_oid) {
+        dout(20) << __func__ << " removing pgmeta object " << oid << dendl;
+      } else {
+        dout(0) << __func__ << " additional unexpected onode"
+                <<" new onode has appeared since PG removal started"
+                << oid << dendl;
       }
     }
   }