]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
mds: change priority of mds rss perf counter to useful
authorsp98 <sapillai@redhat.com>
Thu, 7 Dec 2023 10:48:05 +0000 (16:18 +0530)
committerVenky Shankar <vshankar@redhat.com>
Thu, 4 Jan 2024 10:24:32 +0000 (15:54 +0530)
mds_cache_mem_rss perf counter can be a useful metric to detect
the usage of mds cache and detect mds cache oversize before it happens.
The PR changes the priority of the mds_rss metric from Debug to useful

Fixes: https://tracker.ceph.com/issues/63765
Signed-off-by: sp98 <sapillai@redhat.com>
(cherry picked from commit 89b9fa299c0fe80b3e8619dd9dd8cb77e5b08016)

src/mds/MDSRank.cc

index a157563e439bee73c5cff3a694f18af17a06e73f..3d34772efdde2b526cdc60f18a487ac77341da91 100644 (file)
@@ -3506,6 +3506,9 @@ void MDSRank::create_logger()
                     PerfCountersBuilder::PRIO_INTERESTING);
     mdm_plb.add_u64(l_mdm_dn, "dn", "Dentries", "dn",
                     PerfCountersBuilder::PRIO_INTERESTING);
+    // mds rss metric is set to PRIO_USEFUL as it can be useful to detect mds cache oversizing
+    mdm_plb.add_u64(l_mdm_rss, "rss", "RSS", "rss",
+                    PerfCountersBuilder::PRIO_USEFUL);
 
     mdm_plb.set_prio_default(PerfCountersBuilder::PRIO_USEFUL);
     mdm_plb.add_u64_counter(l_mdm_inoa, "ino+", "Inodes opened");
@@ -3520,9 +3523,6 @@ void MDSRank::create_logger()
     mdm_plb.add_u64_counter(l_mdm_caps, "cap-", "Capabilities removed");
     mdm_plb.add_u64(l_mdm_heap, "heap", "Heap size");
 
-    mdm_plb.set_prio_default(PerfCountersBuilder::PRIO_DEBUGONLY);
-    mdm_plb.add_u64(l_mdm_rss, "rss", "RSS");
-
     mlogger = mdm_plb.create_perf_counters();
     g_ceph_context->get_perfcounters_collection()->add(mlogger);
   }