]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
Revert "PrimeryLogPG: don't accept ops with mixed balance_reads and rwordered flags"
authorRadoslaw Zarzynski <rzarzyns@redhat.com>
Thu, 11 Dec 2025 18:28:25 +0000 (19:28 +0100)
committerRadoslaw Zarzynski <rzarzyns@redhat.com>
Thu, 11 Dec 2025 18:28:25 +0000 (19:28 +0100)
This reverts commit 4b01c004b5dc342cbdfb7cb26b47f6afe6245599 as there
are clients-in-production that actually issue writes marked as balanced-
or localized-reads. Preserving backward compatibility here is way more
important than anything else.

Fixes: https://tracker.ceph.com/issues/73997
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
(please note: this revert is not a cherry-pick from main)

src/osd/PrimaryLogPG.cc

index 9ef012eb930ddcf5c72b3e1a1561aa25ebdfc3b8..710b07f058ccc88a02c1bef40bcc9342b8c82f3a 100644 (file)
@@ -2045,15 +2045,6 @@ void PrimaryLogPG::do_op(OpRequestRef& op)
     }
   }
 
-  // check for op with rwordered and rebalance or localize reads
-  if ((m->has_flag(CEPH_OSD_FLAG_BALANCE_READS) || m->has_flag(CEPH_OSD_FLAG_LOCALIZE_READS)) &&
-      op->rwordered()) {
-    dout(4) << __func__ << ": rebelance or localized reads with rwordered not allowed "
-       << *m << dendl;
-    osd->reply_op_error(op, -EINVAL);
-    return;
-  }
-
   if ((m->get_flags() & (CEPH_OSD_FLAG_BALANCE_READS |
                         CEPH_OSD_FLAG_LOCALIZE_READS)) &&
       op->may_read() &&