]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
mgr/dashboard: fix typo in Multi-Cluster > Manager Cluster to Manage Clusters
authorAashish Sharma <aasharma@li-e74156cc-2f67-11b2-a85c-e98659a63c5c.ibm.com>
Fri, 26 Jul 2024 08:08:56 +0000 (13:38 +0530)
committerAashish Sharma <aasharma@li-e74156cc-2f67-11b2-a85c-e98659a63c5c.ibm.com>
Wed, 7 Aug 2024 11:37:32 +0000 (17:07 +0530)
This PR fixes regression caused by this commit - https://github.com/ceph/ceph/commit/24b2716ae46aa8483625e01163668f8735b9e63b

Fixes: https://tracker.ceph.com/issues/67194
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html
src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.spec.ts

index 1f25dabec4b9ddbf19eb660828da0d39a6e550d8..bc1057721bbd2ccf1c74202da8785ee5cb1f282f 100644 (file)
                             [useRouter]="true"
                             class="tc_submenuitem tc_submenuitem_multiCluster_overview"><span i18n>Overview</span></cds-sidenav-item>
           <cds-sidenav-item route="/multi-cluster/manage-clusters"
-                            title="Manager Cluster"
+                            title="Manage Clusters"
                             i18n-title
                             [useRouter]="true"
-                            class="tc_submenuitem tc_submenuitem_multiCluster_manage_clusters"><span i18n>Manager Cluster</span></cds-sidenav-item>
+                            class="tc_submenuitem tc_submenuitem_multiCluster_manage_clusters"><span i18n>Manage Clusters</span></cds-sidenav-item>
         </cds-sidenav-menu>
         <!-- Cluster -->
         <cds-sidenav-menu title="Cluster"
           <cds-sidenav-item route="/block/nvmeof"
                             [useRouter]="true"
                             title="NVMe/TCP"
-                            i18n-title><span i18n>NVMe/TCP</span></cds-sidenav-item>
+                            i18n-title
+                            class="tc_submenuitem tc_submenuitem_block_nvme"><span i18n>NVMe/TCP</span></cds-sidenav-item>
         </cds-sidenav-menu>
         <!-- Object Storage -->
         <cds-sidenav-menu title="Object"
                             title="Multi-site"
                             i18n-title
                             [useRouter]="true"
-                            class="tc_submenuitem tc_submenuitem_rgw_buckets"><span i18n>Multi-site</span></cds-sidenav-item>
+                            class="tc_submenuitem tc_submenuitem_rgw_multi-site"><span i18n>Multi-site</span></cds-sidenav-item>
           <cds-sidenav-item route="/rgw/daemon"
                             title="Gateways"
                             i18n-title
index 9bf0bde51e222fd38ad34bcc99b86b10be78bb53..86bc4610acc7d50010567f099824710898cfc8a4 100644 (file)
@@ -219,4 +219,48 @@ describe('NavigationComponent', () => {
       });
     }
   });
+
+  describe('Test Side Navigation Text', () => {
+    it('should display correct text for navigation items', () => {
+      fixture.detectChanges();
+
+      const expectedTexts = {
+        '.tc_menuitem_dashboard': 'Dashboard',
+        '.tc_submenuitem_multiCluster_overview': 'Overview',
+        '.tc_submenuitem_multiCluster_manage_clusters': 'Manage Clusters',
+        '.tc_submenuitem_cluster_pool': 'Pools',
+        '.tc_submenuitem_cluster_hosts': 'Hosts',
+        '.tc_submenuitem_cluster_inventory': 'Physical Disks',
+        '.tc_submenuitem_admin_services': 'Services',
+        '.tc_submenuitem_cluster_monitor': 'Monitors',
+        '.tc_submenuitem_cluster_osds': 'OSDs',
+        '.tc_submenuitem_cluster_crush': 'CRUSH Map',
+        '.tc_submenuitem_admin_configuration': 'Configuration',
+        '.tc_submenuitem_admin_modules': 'Manager Modules',
+        '.tc_submenuitem_admin_users': 'Ceph Users',
+        '.tc_submenuitem_admin_upgrade': 'Upgrade',
+        '.tc_submenuitem_observe_log': 'Logs',
+        '.tc_submenuitem_observe_monitoring': 'Alerts',
+        '.tc_submenuitem_block_images': 'Images',
+        '.tc_submenuitem_block_mirroring': 'Mirroring',
+        '.tc_submenuitem_block_iscsi': 'iSCSI',
+        '.tc_submenuitem_block_nvme': 'NVMe/TCP',
+        '.tc_submenuitem_rgw_overview': 'Overview',
+        '.tc_submenuitem_rgw_buckets': 'Buckets',
+        '.tc_submenuitem_rgw_users': 'Users',
+        '.tc_submenuitem_rgw_multi-site': 'Multi-site',
+        '.tc_submenuitem_rgw_daemons': 'Gateways',
+        '.tc_submenuitem_rgw_nfs': 'NFS',
+        '.tc_submenuitem_rgw_configuration': 'Configuration',
+        '.tc_submenuitem_file_cephfs': 'File Systems',
+        '.tc_submenuitem_file_nfs': 'NFS'
+      };
+
+      for (const [selector, expectedText] of Object.entries(expectedTexts)) {
+        const element = fixture.debugElement.query(By.css(selector));
+        expect(element).toBeTruthy();
+        expect(element.nativeElement.textContent.trim()).toBe(expectedText);
+      }
+    });
+  });
 });