]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commitdiff
comments about the BlockBasedTableOptions migration in Options
authorLei Jin <lei@fb.com>
Tue, 2 Sep 2014 22:35:42 +0000 (15:35 -0700)
committerLei Jin <lei@fb.com>
Tue, 2 Sep 2014 22:37:27 +0000 (15:37 -0700)
Summary: as title

Test Plan: none

Reviewers: sdong, igor

Subscribers: leveldb

Differential Revision: https://reviews.facebook.net/D22737

include/rocksdb/options.h

index 0ca30334410b939fedf7f0fc51704ef67a29dd3c..11d976fb2b0afecdadf3224cc0810dc4131766c5 100644 (file)
@@ -409,10 +409,24 @@ struct ColumnFamilyOptions {
   std::shared_ptr<MemTableRepFactory> memtable_factory;
 
   // This is a factory that provides TableFactory objects.
-  // Default: a factory that provides a default implementation of
-  // Table and TableBuilder.
+  // Default: a block-based table factory that provides a default
+  // implementation of TableBuilder and TableReader with default
+  // BlockBasedTableOptions.
   std::shared_ptr<TableFactory> table_factory;
 
+  // Block-based table related options are moved to BlockBasedTableOptions.
+  // Related options that were originally here but now moved include:
+  //   no_block_cache
+  //   block_cache
+  //   block_cache_compressed
+  //   block_size
+  //   block_size_deviation
+  //   block_restart_interval
+  //   filter_policy
+  //   whole_key_filtering
+  // If you'd like to customize some of these options, you will need to
+  // use NewBlockBasedTableFactory() to construct a new table factory.
+
   // This option allows user to to collect their own interested statistics of
   // the tables.
   // Default: empty vector -- no user-defined statistics collection will be