]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commitdiff
Disable refresh snapshot feature by default (#5606)
authorMaysam Yabandeh <myabandeh@fb.com>
Tue, 23 Jul 2019 03:01:25 +0000 (20:01 -0700)
committermyabandeh <myabandeh@fb.com>
Wed, 18 Sep 2019 21:37:16 +0000 (14:37 -0700)
Summary:
There are concerns about the correctness of this patch. Disabling by default until the concerns are resolved.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5606

Differential Revision: D16428064

Pulled By: maysamyabandeh

fbshipit-source-id: a89280f0ea85796c9c9dfbfd9a8e91dad9b000b3

include/rocksdb/options.h

index a1071f62ec76f881cf1e364dae77fd382b32e33c..1f370debf4f137a80a2deefa5a2512405fa7331c 100644 (file)
@@ -275,10 +275,10 @@ struct ColumnFamilyOptions : public AdvancedColumnFamilyOptions {
   // this option helps reducing the cpu usage of long-running compactions. The
   // feature is disabled when max_subcompactions is greater than one.
   //
-  // Default: 0.1s
+  // Default: 0
   //
   // Dynamically changeable through SetOptions() API
-  uint64_t snap_refresh_nanos = 100 * 1000 * 1000;  // 0.1s
+  uint64_t snap_refresh_nanos = 0;
 
   // Disable automatic compactions. Manual compactions can still
   // be issued on this column family