add some tests for the testable non-remote utils

diff --git a/remoto/tests/test_log.py b/remoto/tests/test_log.py
new file mode 100644 (file)
index 0000000..5757da6
--- /dev/null
+++ b/remoto/tests/test_log.py
@@ -0,0 +1,36 @@
+from remoto import log
+from mock import Mock
+
+
+class TestReporting(object):
+
+    def test_reporting_when_channel_is_empty(self):
+        conn = Mock()
+        result = Mock()
+        result.receive.side_effect = EOFError
+        log.reporting(conn, result)
+
+    def test_write_debug_statements(self):
+        conn = Mock()
+        result = Mock()
+        result.receive.side_effect = [{'debug': 'a debug message'}, EOFError]
+        log.reporting(conn, result)
+        assert conn.logger.debug.called is True
+        assert conn.logger.info.called is False
+
+    def test_write_info_statements(self):
+        conn = Mock()
+        result = Mock()
+        result.receive.side_effect = [{'error': 'an error message'}, EOFError]
+        log.reporting(conn, result)
+        assert conn.logger.debug.called is False
+        assert conn.logger.error.called is True
+
+    def test_strip_new_lines(self):
+        conn = Mock()
+        result = Mock()
+        result.receive.side_effect = [{'error': 'an error message\n\n'}, EOFError]
+        log.reporting(conn, result)
+        message = conn.logger.error.call_args[0][0]
+        assert message == 'an error message'
+

diff --git a/remoto/tests/test_process.py b/remoto/tests/test_process.py
index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..1eff8c3676fb28c702c4504a2cdfbc76418a66df 100644 (file)
--- a/remoto/tests/test_process.py
+++ b/remoto/tests/test_process.py
@@ -0,0 +1,3 @@
+# Having imports inlined in the function makes it really complicated to test
+# while controlling the environment. Figure out a way to deal with inlined imports
+# so testing evolves nicely.