os/bluestore: Writer, rename _deferred_decision -> _defer_or_allocate

A review proposal.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>

diff --git a/src/os/bluestore/Writer.cc b/src/os/bluestore/Writer.cc
index 63e1e5b891b97845860f48cfefe501f53edd7833..9cfb25edb666e57cd04af142fb026828b527ccff 100644 (file)
--- a/src/os/bluestore/Writer.cc
+++ b/src/os/bluestore/Writer.cc
@@ -1180,11 +1180,13 @@ std::pair<bool, uint32_t> BlueStore::Writer::_write_expand_r(
   return std::make_pair(new_data_pad, new_data_end);
 }
 
+
+
 // This function is a centralized place to make a decision on
 // whether to use deferred or direct writes.
 // The assumption behind it is that having parts of write executed as
 // deferred and other parts as direct is suboptimal in any case.
-void BlueStore::Writer::_deferred_decision(uint32_t need_size)
+void BlueStore::Writer::_defer_or_allocate(uint32_t need_size)
 {
   // make a deferred decision
   uint32_t released_size = 0;
@@ -1314,7 +1316,7 @@ void BlueStore::Writer::do_write(
   if (location != data_end) {
     uint32_t need_size = p2roundup(data_end, au_size) - p2align(location, au_size);
     // make a deferred decision
-    _deferred_decision(need_size);
+    _defer_or_allocate(need_size);
     _do_put_blobs(location, data_end, ref_end, bd, after_punch_it);
   } else {
     // Unlikely, but we just put everything.

diff --git a/src/os/bluestore/Writer.h b/src/os/bluestore/Writer.h
index 79f24b52d22c6528cbb68f51b6bb6c5ab30908ac..d2372e4ac73810bab1a241d08058e08ac200cc36 100644 (file)
--- a/src/os/bluestore/Writer.h
+++ b/src/os/bluestore/Writer.h
@@ -202,7 +202,7 @@ private:
 
   void _collect_released_allocated();
 
-  void _deferred_decision(uint32_t need_size);
+  void _defer_or_allocate(uint32_t need_size);
 };
 
 std::ostream& operator<<(std::ostream& out, const BlueStore::Writer::blob_data_printer& printer);