console_log: Be aware of conserver

Signed-off-by: Zack Cerza <zack@redhat.com>

diff --git a/teuthology/task/console_log.py b/teuthology/task/console_log.py
index c8ace9cc45986f36814d69540082519b2448fc59..97cf83450df2b15556caa23aaba3215526372b76 100644 (file)
--- a/teuthology/task/console_log.py
+++ b/teuthology/task/console_log.py
@@ -28,8 +28,10 @@ class ConsoleLog(Task):
             if not hasattr(remote.console, 'spawn_sol_log'):
                 log.debug("%s does not support IPMI; excluding",
                           remote.shortname)
-            elif not remote.console.has_ipmi_credentials:
-                log.debug("IPMI credentials not found for %s; excluding",
+            elif not (remote.console.has_ipmi_credentials or
+                      remote.console.has_conserver):
+                log.debug("Cannot find IPMI credentials or conserver settings "
+                          "for %s; excluding",
                           remote.shortname)
             else:
                 new_cluster.add(remote, roles)

diff --git a/teuthology/test/task/test_console_log.py b/teuthology/test/task/test_console_log.py
index e96dee9e283997049d5bdb4a824329e5e7ce0c41..b9731d47e3e33ffa21cdd92243d43d17e027b7dd 100644 (file)
--- a/teuthology/test/task/test_console_log.py
+++ b/teuthology/test/task/test_console_log.py
@@ -52,6 +52,7 @@ class TestConsoleLog(TestTask):
     def test_has_ipmi_credentials(self):
         for remote in self.ctx.cluster.remotes.keys():
             remote.console.has_ipmi_credentials = False
+            remote.console.has_conserver = False
         task = self.klass(self.ctx, self.task_config)
         assert len(task.cluster.remotes.keys()) == 0