]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commitdiff
Disable fault injection with BatchedOpsStressTest and MultiOpsTxnsStressTest (#12794)
authorHui Xiao <huixiao@fb.com>
Sat, 22 Jun 2024 02:50:59 +0000 (19:50 -0700)
committerFacebook GitHub Bot <facebook-github-bot@users.noreply.github.com>
Sat, 22 Jun 2024 02:50:59 +0000 (19:50 -0700)
Summary:
**Context/Summary:**

https://github.com/facebook/rocksdb/pull/12713 accidentally turned on fault injection in BatchedOpsStressTest and MultiOpsTxnsStressTest. Though this was meant to be an increased testing coverage, it also made our CI noisy. For now we decided to disable it before we manage to stabilize the CI and fix bugs surfaced in NonBatchedOpsStressTest which impacts more users.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/12794

Test Plan: CI

Reviewed By: cbi42

Differential Revision: D58897598

Pulled By: hx235

fbshipit-source-id: 8094072ef1bff27d7825efed0876f365a31fef9c

tools/db_crashtest.py

index 381d413f987bd2e5c672b27d61f49cbf5e67b38d..948b2c2342c131ddc3a3bbc8e960d3f254cd5b37 100644 (file)
@@ -695,6 +695,11 @@ def finalize_and_sanitize(src_params):
     if dest_params["test_batches_snapshots"] == 1:
         dest_params["enable_compaction_filter"] = 0
         dest_params["inplace_update_support"] = 0
+        # TODO(hx235): enable test_batches_snapshots with fault injection after stabilizing the CI
+        dest_params["write_fault_one_in"] = 0
+        dest_params["metadata_write_fault_one_in"] = 0
+        dest_params["read_fault_one_in"] = 0
+        dest_params["metadata_read_fault_one_in"] = 0
         if dest_params["prefix_size"] < 0:
             dest_params["prefix_size"] = 1
 
@@ -815,6 +820,12 @@ def finalize_and_sanitize(src_params):
         # Wide-column pessimistic transaction APIs are initially supported for
         # WriteCommitted only
         dest_params["use_put_entity_one_in"] = 0
+    # TODO(hx235): enable test_multi_ops_txns with fault injection after stabilizing the CI
+    if dest_params.get("test_multi_ops_txns") == 1:
+         dest_params["write_fault_one_in"] = 0
+         dest_params["metadata_write_fault_one_in"] = 0
+         dest_params["read_fault_one_in"] = 0
+         dest_params["metadata_read_fault_one_in"] = 0
     # Wide column stress tests require FullMergeV3
     if dest_params["use_put_entity_one_in"] != 0:
         dest_params["use_full_merge_v1"] = 0