]> git.apps.os.sepia.ceph.com Git - ceph-ansible.git/commitdiff
retry on packages and repositories failures
authorGuillaume Abrioux <gabrioux@redhat.com>
Wed, 19 Dec 2018 13:55:01 +0000 (14:55 +0100)
committermergify[bot] <mergify[bot]@users.noreply.github.com>
Wed, 19 Dec 2018 14:48:27 +0000 (14:48 +0000)
add register/until on all packaging related tasks to avoid non valid CI
failure.

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
30 files changed:
infrastructure-playbooks/lv-create.yml
infrastructure-playbooks/lv-teardown.yml
infrastructure-playbooks/untested-by-ci/make-osd-partitions.yml
infrastructure-playbooks/untested-by-ci/migrate-journal-to-ssd.yml
infrastructure-playbooks/untested-by-ci/recover-osds-after-ssd-journal-failure.yml
roles/ceph-agent/tasks/pre_requisite.yml
roles/ceph-common/tasks/installs/configure_redhat_local_installation.yml
roles/ceph-common/tasks/installs/debian_uca_repository.yml
roles/ceph-common/tasks/installs/install_debian_packages.yml
roles/ceph-common/tasks/installs/install_debian_rhcs_packages.yml
roles/ceph-common/tasks/installs/install_on_debian.yml
roles/ceph-common/tasks/installs/install_redhat_packages.yml
roles/ceph-common/tasks/installs/install_suse_packages.yml
roles/ceph-container-common/tasks/pre_requisites/debian_prerequisites.yml
roles/ceph-container-common/tasks/pre_requisites/prerequisites.yml
roles/ceph-infra/tasks/ntp_debian.yml
roles/ceph-infra/tasks/ntp_rpm.yml
roles/ceph-iscsi-gw/tasks/non-container/prerequisites.yml
roles/ceph-mds/tasks/non_containerized.yml
roles/ceph-mgr/tasks/pre_requisite.yml
roles/ceph-nfs/tasks/ganesha_selinux_fix.yml
roles/ceph-nfs/tasks/pre_requisite_non_container_debian.yml
roles/ceph-nfs/tasks/pre_requisite_non_container_red_hat.yml
roles/ceph-osd/tasks/main.yml
roles/ceph-rbd-mirror/tasks/pre_requisite.yml
roles/ceph-rgw/tasks/openstack-keystone.yml
tests/functional/lvm_setup.yml
tests/functional/rgw_multisite.yml
tests/functional/rhcs_setup.yml
tests/functional/setup.yml

index 2bd75984de13b81cf1433f4cc726c52e073d8871..a05ce15a017b5bc9383873b20f6abe8c961edab1 100644 (file)
@@ -38,6 +38,8 @@
     package:
       name: lvm2
       state: present
+    register: result
+    until: result is succeeded
 
   # Make entire nvme device a VG
   - name: add nvme device as lvm pv
index 4be713475951bffdafe692e5456e2447e31893a7..a717f9f7ecf53e1dad897768d950d87c958e4b2a 100644 (file)
@@ -29,6 +29,8 @@
     package:
       name: lvm2
       state: present
+    register: result
+    until: result is succeeded
 
 # BEGIN TEARDOWN
   - name: find any existing osd filesystems
index 0fc6892d2605b5d6fd94ca19307c33c3f61815e1..eb7f9f8788c3eb8dee6451c0d1993d46b605fae7 100644 (file)
@@ -49,6 +49,8 @@
     package:
       name: gdisk
       state: present
+    register: result
+    until: result is succeeded
 
   - name: erase all previous partitions(dangerous!!!)
     shell: sgdisk --zap-all -- /dev/{{item.device_name}}
index 44a75e01b6df27e2914bbd2ff6fbad5343a3d0d1..e999759edc18bffcec77f59861cd88ac21d31c42 100644 (file)
@@ -58,6 +58,8 @@
     package:
       name: gdisk
       state: present
+    register: result
+    until: result is succeeded
     when: osds_journal_devices is defined
 
   - name: generate uuid for osds journal
index de3b6e86e4d1b23fa8a6677b4dd17a50f1f93e47..d19fe129c21321bf9d9b7acbe2277aa7a921c1d1 100644 (file)
@@ -80,6 +80,8 @@
     package:
       name: gdisk
       state: present
+    register: result
+    until: result is succeeded
     
   - name: get osd(s) journal uuid
     command: cat "/var/lib/ceph/osd/{{ cluster }}-{{ item.1.osd_id }}/journal_uuid"
index 67dab66abb99d3d7d4661af792c01e259eb31c4b..3b1ed5d98342928c646f98591dce9d07219ec728 100644 (file)
@@ -5,6 +5,8 @@
   package:
     name: rhscon-agent
     state: present
+  register: result
+  until: result is succeeded
   tags:
     - package-install
 
index 5edd179dc30964156470b95802eb3cd53b9221bf..941f23929059c2e84b8a4e19c82309909b77dcca 100644 (file)
@@ -31,6 +31,8 @@
   package:
     name: rsync
     state: present
+  register: result
+  until: result is succeeded
 
 - name: synchronize ceph install
   synchronize:
index 76aea933b945936ebd380b7ca24b23002f412c70..92ff0c6d4f93c38840bba43b68e388bb3da1bc60 100644 (file)
@@ -2,6 +2,8 @@
 - name: add ubuntu cloud archive key package
   package:
     name: ubuntu-cloud-keyring
+  register: result
+  until: result is succeeded
 
 - name: add ubuntu cloud archive repository
   apt_repository:
index fc14e01acf38185a6346ca2cb66ba521277bcbd8..1af787006139f312039afdc0f567272d3b2322a3 100644 (file)
@@ -5,3 +5,5 @@
     update_cache: no
     state: "{{ (upgrade_ceph_packages|bool) | ternary('latest','present') }}"
     default_release: "{{ ceph_stable_release_uca | default(omit) }}{{ ansible_distribution_release ~ '-backports' if ceph_origin == 'distro' and ceph_use_distro_backports else '' }}"
+  register: result
+  until: result is succeeded
\ No newline at end of file
index 257f18d695d7f643e706ba5311f3f279ff57cb86..f1a25197f2498fd2debcdf1b2482a805941cb8fc 100644 (file)
@@ -3,3 +3,5 @@
   apt:
     pkg: "{{ debian_ceph_pkgs | unique }}"
     state: "{{ (upgrade_ceph_packages|bool) | ternary('latest','present') }}"
+  register: result
+  until: result is succeeded
\ No newline at end of file
index 30b70a97b552eeb7dc58f98dd6f8da7533abfc47..5c1730bdcd476ecdd8a8619e6c67f2ddf3f4042c 100644 (file)
@@ -15,6 +15,8 @@
     state: present
     update_cache: yes
     cache_valid_time: 3600
+  register: result
+  until: result is succeeded
 
 - name: include install_debian_packages.yml
   include_tasks: install_debian_packages.yml
index 4446465a9aa0194fce93b32ceb5625a8e6b1b664..d692c175896acdfcdffc03fe99e5d41e3b4a48f8 100644 (file)
@@ -3,6 +3,8 @@
   package:
     name: "{{ redhat_package_dependencies }}"
     state: present
+  register: result
+  until: result is succeeded
   when:
     - ansible_distribution == 'RedHat'
 
@@ -10,6 +12,8 @@
   yum:
     name: "{{ centos_package_dependencies }}"
     state: present
+  register: result
+  until: result is succeeded
   when:
     - ansible_distribution == 'CentOS'
 
@@ -17,3 +21,5 @@
   package:
     name: "{{ redhat_ceph_pkgs | unique }}"
     state: "{{ (upgrade_ceph_packages|bool) | ternary('latest','present') }}"
+  register: result
+  until: result is succeeded
\ No newline at end of file
index c202c5ece9238705ec1a805f1e3a9b10bdb0988c..f7a4593a8f9738c4b6de8b2cdb121f20750c6d48 100644 (file)
@@ -3,8 +3,12 @@
   package:
     name: "{{ suse_package_dependencies }}"
     state: present
+  register: result
+  until: result is succeeded
 
 - name: install suse ceph packages
   package:
     name: "{{ suse_ceph_pkgs | unique }}"
     state: "{{ (upgrade_ceph_packages|bool) | ternary('latest','present') }}"
+  register: result
+  until: result is succeeded
\ No newline at end of file
index 3958a51887db7e032de0149f632407c9f63e463f..c1011f2fc9d53eabead5abc04510c7d51308158b 100644 (file)
@@ -4,6 +4,8 @@
     name: ['apt-transport-https', 'ca-certificates', 'curl', 'software-properties-common']
     state: present
     update_cache: yes
+  register: result
+  until: result is succeeded
 
 - name: add docker's gpg key
   apt_key:
     state: present
     default_release: testing
     update_cache: yes
+  register: result
+  until: result is succeeded
 
 - name: install docker-py via pip for debian
   pip:
     name: docker-py
     state: latest
+  register: result
+  until: result is succeeded
   tags:
     - skip_ansible_lint
 
+
 - name: install docker on debian
   package:
     name: "{{ 'docker-ce' if ansible_architecture == 'aarch64' else 'docker-engine' }}"
     state: present
     update_cache: yes
+  register: result
+  until: result is succeeded
 
 # NOTE (jimcurtis): need at least version 1.9.0 of six or we get:
 # re:NameError: global name 'DEFAULT_DOCKER_API_VERSION' is not defined
index 30d74f2489baaed5398e0a95bf853484b474cf95..9e1dac16ca842bbe56622ce1f9ae54c7b863b9d9 100644 (file)
@@ -13,6 +13,8 @@
         name: python-six
         state: present
         update_cache: yes
+      register: result
+      until: result is succeeded
       tags:
         with_pkg
   when:
@@ -25,6 +27,8 @@
         name: ['docker.io', 'python-docker']
         state: present
         update_cache: yes
+      register: result
+      until: result is succeeded
       tags:
         with_pkg
   when:
@@ -48,6 +52,8 @@
       package:
         name: ['docker', 'python-docker-py']
         state: present
+      register: result
+      until: result is succeeded
       tags:
         with_pkg
   when:
index 80c8fac8251b7e975ef84c94af59dd337e1655d4..db3edc3221738a6e9f74e546180a4a972a71f7c5 100644 (file)
@@ -7,6 +7,8 @@
       package:
         name: ntp
         state: present
+      register: result
+      until: result is succeeded
     - name: start ntp
       service:
         name: ntp
@@ -22,6 +24,8 @@
       package:
         name: chrony
         state: present
+      register: result
+      until: result is succeeded
     - name: start chronyd
       service:
         name: chronyd
index 9e4d38cd2f2efa2798202efca10f58c90d0ee5bf..d8d41e2b08158e94ff6ef9917d9e9b48b91da511 100644 (file)
@@ -7,6 +7,8 @@
       package:
         name: ntp
         state: present
+      register: result
+      until: result is succeeded
     - name: start ntp
       service:
         name: ntpd
@@ -22,6 +24,8 @@
       package:
         name: chrony
         state: present
+      register: result
+      until: result is succeeded
     - name: start chrony
       service:
         name: chronyd
index 0e1d60dfb67f271620c3b40f988f077d1af26409..3fa2dbbdd83990da71b812276b417d0f5b05d024 100644 (file)
@@ -37,6 +37,8 @@
       package:
         name: "{{ item }}"
         state: "{{ (upgrade_ceph_packages|bool) | ternary('latest','present') }}"
+      register: result
+      until: result is succeeded
       with_items:
         - tcmu-runner
         - ceph-iscsi-config
index 3546dd646fdbc220b3e4a120a003e2fda5f67ddc..fe5c68c8e55edda8ff69bf15c605d80705834e50 100644 (file)
@@ -12,6 +12,8 @@
   package:
     name: "ceph-mds"
     state: "{{ (upgrade_ceph_packages|bool) | ternary('latest','present') }}"
+  register: result
+  until: result is succeeded
   when:
     - mds_group_name in group_names
     - ansible_os_family == 'RedHat'
index 401e5fd6d9660ccc59f0df9641f5b9a39ab73805..b3a1d587bdad02e5380c01010b469a905ba866f3 100644 (file)
@@ -3,6 +3,8 @@
   package:
     name: ceph-mgr
     state: "{{ (upgrade_ceph_packages|bool) | ternary('latest','present') }}"
+  register: result
+  until: result is succeeded
   when:
     - ansible_os_family in ['RedHat', 'Suse']
 
@@ -11,5 +13,7 @@
     name: ceph-mgr
     state: "{{ (upgrade_ceph_packages|bool) | ternary('latest','present') }}"
     default_release: "{{ ceph_stable_release_uca | default(omit) }}{{ ansible_distribution_release ~ '-backports' if ceph_origin == 'distro' and ceph_use_distro_backports else '' }}"
+  register: result
+  until: result is succeeded
   when:
     - ansible_os_family == 'Debian'
index 3546c8280f76d1f387381b59fb12d12ec91a56ee..1c3c0ba7de820309df42743edc0461cc20a24b43 100644 (file)
@@ -10,6 +10,8 @@
   package:
     name: policycoreutils-python
     state: present
+  register: result
+  until: result is succeeded
   when:
     - selinuxstatus.stdout != 'Disabled'
 
index 21324116d695f45e5c9f0f9ec39654dd2444f927..cc392c86b12d6ffe71368742195c2c0160e735a1 100644 (file)
             name: libjemalloc1
             state: "{{ (upgrade_ceph_packages|bool) | ternary('latest','present') }}"
             update_cache: yes
+          register: result
+          until: result is succeeded
         - name: install nfs rgw/cephfs gateway - debian
           apt:
             name: ['nfs-ganesha-rgw', 'radosgw']
             allow_unauthenticated: yes
+          register: result
+          until: result is succeeded
           when: nfs_obj_gw
         - name: install nfs rgw/cephfs gateway - debian
           apt:
             name: nfs-ganesha-ceph
             allow_unauthenticated: yes
+          register: result
+          until: result is succeeded
           when: nfs_file_gw
       when:
         - (ceph_origin == 'repository' or ceph_origin == 'distro')
           apt:
             name: nfs-ganesha
             state: "{{ (upgrade_ceph_packages|bool) | ternary('latest','present') }}"
+          register: result
+          until: result is succeeded
         - name: install red hat storage nfs file gateway
           apt:
             name: nfs-ganesha-ceph
             state: "{{ (upgrade_ceph_packages|bool) | ternary('latest','present') }}"
+          register: result
+          until: result is succeeded
           when:
             - nfs_file_gw
         - name: install red hat storage nfs obj gateway
           apt:
             name: nfs-ganesha-rgw
             state: "{{ (upgrade_ceph_packages|bool) | ternary('latest','present') }}"
+          register: result
+          until: result is succeeded
           when:
             - nfs_obj_gw
       when:
index d7ebcc3892b67dd4e7de943fb145f3a69a04180b..9878f16bc5439b2bb38a0f1ed0bdd9c7e9e6b660 100644 (file)
@@ -40,6 +40,8 @@
       package:
         name: nfs-ganesha-ceph
         state: "{{ (upgrade_ceph_packages|bool) | ternary('latest','present') }}"
+      register: result
+      until: result is succeeded
       when:
         - nfs_file_gw
 
@@ -47,5 +49,7 @@
       package:
         name: ['nfs-ganesha-rgw', 'ceph-radosgw']
         state: "{{ (upgrade_ceph_packages|bool) | ternary('latest','present') }}"
+      register: result
+      until: result is succeeded
       when:
         - nfs_obj_gw
index 48f109b01512a17d5cf5ce3d758f6bfbfb779fd7..082109d102a671187f973a8bb3c2c43b79e1b983 100644 (file)
@@ -6,6 +6,8 @@
   package:
     name: parted
     state: present
+  register: result
+  until: result is succeeded
   when:
     - not containerized_deployment
     - ansible_os_family != 'ClearLinux'
index ba2a1c6f2b0219639c8b68136ea74ed2fe5eec2c..1adba11cad384f6f33740e17898532fada76c8fc 100644 (file)
@@ -5,6 +5,8 @@
   package:
     name: rbd-mirror
     state: present
+  register: result
+  until: result is succeeded
   tags:
     - package-install
 
index 5514c6f4bf85e20a6e18628cd22a19de12f5016b..2579f1a1981a7a941e76b9d6ae5de4faea270a72 100644 (file)
@@ -3,6 +3,8 @@
   package:
     name: nss-tools
     state: present
+  register: result
+  until: result is succeeded
   when:
     - ansible_pkg_mgr == 'yum' or ansible_pkg_mgr == 'dnf'
 
@@ -10,6 +12,8 @@
   package:
     name: libnss3-tools
     state: present
+  register: result
+  until: result is succeeded
   when:
     - ansible_pkg_mgr == 'apt'
 
index c6908a4bedf2fbf5cb7e2038afb4b909945aa2df..c87b73914060d0f11cfee3c12e8a35bb70d35cf2 100644 (file)
@@ -23,6 +23,8 @@
       package:
         name: lvm2
         state: present
+      register: result
+      until: result is succeeded
       when:
         - not is_atomic
 
index 27e55b375c57929d5b4876d1532a6c5a4472720d..45502c5608dffd1a473173750df16fa1c5d8c88f 100644 (file)
@@ -19,6 +19,8 @@
       package:
         name: s3cmd
         state: present
+      register: result
+      until: result is succeeded
       when:
         - not is_atomic
 
index df45c1d19591d3075e0af43a6db59fdf936bc986..abbb4030f65d1d4b79f8e40d4ad0cb1aea906fe3 100644 (file)
@@ -80,6 +80,8 @@
       package:
         name: docker
         state: present
+      register: result
+      until: result is succeeded
       when: ansible_os_family == 'RedHat'
 
     - name: allow insecure docker registries
index 989ae5078015178fb29773c87f4d702712a68456..752b0aa30f9fa96e946a23c6606facf2f94ccf85 100644 (file)
@@ -20,6 +20,8 @@
       package:
         name: net-tools
         state: present
+      register: result
+      until: result is succeeded
       when:
         - not is_atomic
 
@@ -35,6 +37,8 @@
           package:
             name: epel-release
             state: present
+          register: result
+          until: result is succeeded
         - name: enable local epel repository
           ini_file:
             path: /etc/yum.repos.d/epel.repo