]> git-server-git.apps.pok.os.sepia.ceph.com Git - rocksdb.git/commitdiff
Fixing some issues Valgrind found
authorKosie van der Merwe <kosie.vandermerwe@gmail.com>
Tue, 8 Jan 2013 20:16:40 +0000 (12:16 -0800)
committerKosie van der Merwe <kosie.vandermerwe@gmail.com>
Tue, 8 Jan 2013 20:16:40 +0000 (12:16 -0800)
Summary: Found some issues running Valgrind on `db_test` (there are still some outstanding ones) and fixed them.

Test Plan:
make check

ran `valgrind ./db_test` and saw that errors no longer occur

Reviewers: dhruba, vamsi, emayanke, sheki

Reviewed By: dhruba

CC: leveldb
Differential Revision: https://reviews.facebook.net/D7803

db/db_impl.cc

index 9a46480834f9022b015df4032c6375eb61864d28..304dbc2a1ceb0de59d382c67e0f0485577f32f2d 100644 (file)
@@ -262,7 +262,7 @@ DBImpl::~DBImpl() {
     delete options_.block_cache;
   }
   if (options_.compression_per_level != NULL) {
-    delete options_.compression_per_level;
+    delete[] options_.compression_per_level;
   }
 
   delete logger_;
@@ -1183,7 +1183,7 @@ void DBImpl::BGWork(void* db) {
 }
 
 void DBImpl::BackgroundCall() {
-  bool madeProgress;
+  bool madeProgress = false;
   DeletionState deletion_state;
   MutexLock l(&mutex_);
   // Log(options_.info_log, "XXX BG Thread %llx process new work item", pthread_self());