]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-deploy.git/commitdiff
[RM-16979] Change use of check function.
authorOwen Synge <osynge@suse.com>
Wed, 10 Aug 2016 14:56:48 +0000 (16:56 +0200)
committerOwen Synge <osynge@suse.com>
Wed, 10 Aug 2016 14:56:48 +0000 (16:56 +0200)
Check function should be testable in same way as run function.

Signed-off-by: Owen Synge <osynge@suse.com>
ceph_deploy/util/pkg_managers.py

index 69cabd62e08cdfcfd0e4145fe8150406cf9230af..bc20eb112efd1fb2724da3b12472fc329fcb8097 100644 (file)
@@ -24,6 +24,13 @@ class PackageManager(object):
             **kw
         )
 
+    def _check(self, cmd, **kw):
+        return remoto.process.check(
+            self.remote_conn,
+            cmd,
+            **kw
+        )
+
     def install(self, packages, **kw):
         """Install packages on remote node"""
         raise NotImplementedError()
@@ -306,8 +313,7 @@ class Zypper(PackageManager):
                 extra_flags = [extra_flags]
             cmd.extend(extra_flags)
         cmd.extend(packages)
-        stdout, stderr, exitrc = remoto.process.check(
-            self.remote_conn,
+        stdout, stderr, exitrc = self._check(
             cmd,
             **kw
         )