]> git.apps.os.sepia.ceph.com Git - ceph-client.git/commitdiff
soc: ti: k3-ringacc: Constify struct k3_ring_ops
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Tue, 9 Jul 2024 17:41:29 +0000 (19:41 +0200)
committerNishanth Menon <nm@ti.com>
Tue, 6 Aug 2024 20:33:32 +0000 (15:33 -0500)
'struct k3_ring_ops' is not modified in this driver.

Constifying this structure moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig:
Before:
======
   text    data     bss     dec     hex filename
  17090    3304      32   20426    4fca drivers/soc/ti/k3-ringacc.o

After:
=====
   text    data     bss     dec     hex filename
  17266    3144      32   20442    4fda drivers/soc/ti/k3-ringacc.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/cb9dfc18cdf890afa2c53cd74b0b330d6f1c30ab.1720546863.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Nishanth Menon <nm@ti.com>
drivers/soc/ti/k3-ringacc.c

index fd4251d759352b7e6cec2e33402112d26bd34dd5..8c01029683515c92f990ffc816afbe68c9dd4873 100644 (file)
@@ -161,7 +161,7 @@ struct k3_ring {
        struct k3_ringacc_proxy_target_regs  __iomem *proxy;
        dma_addr_t      ring_mem_dma;
        void            *ring_mem_virt;
-       struct k3_ring_ops *ops;
+       const struct k3_ring_ops *ops;
        u32             size;
        enum k3_ring_size elm_size;
        enum k3_ring_mode mode;
@@ -268,17 +268,17 @@ static int k3_ringacc_ring_pop_mem(struct k3_ring *ring, void *elem);
 static int k3_dmaring_fwd_pop(struct k3_ring *ring, void *elem);
 static int k3_dmaring_reverse_pop(struct k3_ring *ring, void *elem);
 
-static struct k3_ring_ops k3_ring_mode_ring_ops = {
+static const struct k3_ring_ops k3_ring_mode_ring_ops = {
                .push_tail = k3_ringacc_ring_push_mem,
                .pop_head = k3_ringacc_ring_pop_mem,
 };
 
-static struct k3_ring_ops k3_dmaring_fwd_ops = {
+static const struct k3_ring_ops k3_dmaring_fwd_ops = {
                .push_tail = k3_ringacc_ring_push_mem,
                .pop_head = k3_dmaring_fwd_pop,
 };
 
-static struct k3_ring_ops k3_dmaring_reverse_ops = {
+static const struct k3_ring_ops k3_dmaring_reverse_ops = {
                /* Reverse side of the DMA ring can only be popped by SW */
                .pop_head = k3_dmaring_reverse_pop,
 };
@@ -288,7 +288,7 @@ static int k3_ringacc_ring_pop_io(struct k3_ring *ring, void *elem);
 static int k3_ringacc_ring_push_head_io(struct k3_ring *ring, void *elem);
 static int k3_ringacc_ring_pop_tail_io(struct k3_ring *ring, void *elem);
 
-static struct k3_ring_ops k3_ring_mode_msg_ops = {
+static const struct k3_ring_ops k3_ring_mode_msg_ops = {
                .push_tail = k3_ringacc_ring_push_io,
                .push_head = k3_ringacc_ring_push_head_io,
                .pop_tail = k3_ringacc_ring_pop_tail_io,
@@ -300,7 +300,7 @@ static int k3_ringacc_ring_push_tail_proxy(struct k3_ring *ring, void *elem);
 static int k3_ringacc_ring_pop_head_proxy(struct k3_ring *ring, void *elem);
 static int k3_ringacc_ring_pop_tail_proxy(struct k3_ring *ring, void *elem);
 
-static struct k3_ring_ops k3_ring_mode_proxy_ops = {
+static const struct k3_ring_ops k3_ring_mode_proxy_ops = {
                .push_tail = k3_ringacc_ring_push_tail_proxy,
                .push_head = k3_ringacc_ring_push_head_proxy,
                .pop_tail = k3_ringacc_ring_pop_tail_proxy,