]> git.apps.os.sepia.ceph.com Git - ceph-ansible.git/commitdiff
common: do not use `shell` module when it is not needed
authorGuillaume Abrioux <gabrioux@redhat.com>
Wed, 31 Jan 2018 08:31:11 +0000 (09:31 +0100)
committerSébastien Han <seb@redhat.com>
Wed, 31 Jan 2018 09:45:34 +0000 (10:45 +0100)
There is no need here to use `shell` instead of `command`

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
infrastructure-playbooks/purge-cluster.yml
roles/ceph-common/tasks/checks/check_firewall.yml

index c142525e59c5fb763593e38bc57138b158cece6a..b8945f7b3a3b8f2f1529d6523fc3402c1c419b8e 100644 (file)
     ignore_errors: true
 
   - name: is reboot needed
-    local_action: shell echo requesting reboot
+    local_action:
+      module: command
+        echo requesting reboot
     become: false
     notify:
       - restart machine
      state: absent
 
   - name: request data removal
-    local_action: shell echo requesting data removal
+    local_action:
+      module: command
+        echo requesting data removal
     become: false
     notify:
       - remove data
index f5ed176385e965ae8f3cece8f68e792278d20053..22b79ba70b977208863adcc6f11e83e0a2ac528d 100644 (file)
@@ -1,6 +1,8 @@
 ---
 - name: check if nmap is installed
-  local_action: shell command -v nmap
+  local_action:
+    module: command
+      command -v nmap
   changed_when: false
   failed_when: false
   register: nmapexist