]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
mgr/dashboard: s/portal_ip_address/portal_ip_addresses/
authorKefu Chai <kchai@redhat.com>
Tue, 11 Jun 2019 16:28:53 +0000 (00:28 +0800)
committerKefu Chai <kchai@redhat.com>
Wed, 12 Jun 2019 02:44:49 +0000 (10:44 +0800)
and take portal_ip_addresses as a list

it's a follow-up fix of #28084

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/pybind/mgr/dashboard/tests/test_iscsi.py

index c375f8a548839a62873749a0ea1439a358001cf8..db684234c3e1898be4b0d182fb20c764219e4e10 100644 (file)
@@ -544,19 +544,20 @@ class IscsiClientMock(object):
             "portals": {}
         }
 
-    def create_gateway(self, target_iqn, gateway_name, ip_address):
+    def create_gateway(self, target_iqn, gateway_name, ip_addresses):
         target_config = self.config['targets'][target_iqn]
         if 'ip_list' not in target_config:
             target_config['ip_list'] = []
-        target_config['ip_list'] += ip_address
+        target_config['ip_list'] += ip_addresses
         target_config['portals'][gateway_name] = {
-            "portal_ip_addresses": ip_address
+            "portal_ip_addresses": ip_addresses
         }
 
     def delete_gateway(self, target_iqn, gateway_name):
         target_config = self.config['targets'][target_iqn]
         portal_config = target_config['portals'][gateway_name]
-        target_config['ip_list'].remove(portal_config['portal_ip_address'])
+        for ip in portal_config['portal_ip_addresses']:
+            target_config['ip_list'].remove(ip)
         target_config['portals'].pop(gateway_name)
 
     def create_disk(self, pool, image, backstore):