]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
Merge pull request #40063 from rhcs-dashboard/cyclomatic-complexity
authorErnesto Puerta <37327689+epuertat@users.noreply.github.com>
Wed, 5 May 2021 16:11:03 +0000 (18:11 +0200)
committerGitHub <noreply@github.com>
Wed, 5 May 2021 16:11:03 +0000 (18:11 +0200)
mgr/dashboard: reduce cyclomatic complexity

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
1  2 
src/pybind/mgr/dashboard/tests/__init__.py
src/pybind/mgr/dashboard/tests/test_sso.py

index ab565137a18f98759b7992f719b9689f3935baa1,b14c6add15a9b3821843a1c5f1c68634cc511136..c347f54200827a6e463a443838c61536b02c57e7
@@@ -3,13 -3,16 +3,14 @@@
  from __future__ import absolute_import
  
  import errno
+ import tempfile
  import unittest
  
 -from ..services.sso import handle_sso_command, load_sso_db
 -from . import CmdException  # pylint: disable=no-name-in-module
 -from . import KVStoreMockMixin  # pylint: disable=no-name-in-module
 -from . import exec_dashboard_cmd  # pylint: disable=no-name-in-module
 +from ..services.sso import load_sso_db
 +from . import CLICommandTestMixin, CmdException  # pylint: disable=no-name-in-module
  
  
 -class AccessControlTest(unittest.TestCase, KVStoreMockMixin):
 +class AccessControlTest(unittest.TestCase, CLICommandTestMixin):
      IDP_METADATA = '''<?xml version="1.0"?>
  <md:EntityDescriptor xmlns:md="urn:oasis:names:tc:SAML:2.0:metadata"
                       xmlns:ds="http://www.w3.org/2000/09/xmldsig#"