]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
qa/tasks/test_orchestrator_cli: enable test_osd_create exception check
authorKefu Chai <kchai@redhat.com>
Tue, 3 Mar 2020 16:24:08 +0000 (00:24 +0800)
committerKefu Chai <kchai@redhat.com>
Tue, 3 Mar 2020 17:52:02 +0000 (01:52 +0800)
this reverts 9639acfefe09c87adc821bb5c5cc41974685331d, as the test does
make sense. what fails this test is the machinary to marshal/unmarshal
exception fails to handle un-picklable exceptions. the previous commit
is supposed to use a fallback to handle them.

Signed-off-by: Kefu Chai <kchai@redhat.com>
qa/tasks/mgr/test_orchestrator_cli.py

index c4e2bdc5bc1cc1babaac13085b721d244a41af97..94d87299815e8ed7db95a7ca476d9c7ec351a3e0 100644 (file)
@@ -95,8 +95,8 @@ class TestOrchestratorCli(MgrTestCase):
         res = self._orch_cmd_result("osd", "create", "-i", "-", stdin=json.dumps(drive_groups))
         self.assertEqual(res, 0)
 
-        #with self.assertRaises(Exception):
-           self._orch_cmd("osd", "create", "notfound:device")
+        with self.assertRaises(Exception):
+           self._orch_cmd("osd", "create", "notfound:device")
 
     def test_blink_device_light(self):
         def _ls_lights(what):