cmake: version libceph-common to appease dpkg-shlibdeps

when packaging debian packages, dpkg-shlibdeps analyzes the linked
shared libraries of the binaries in given package by looking at their
names. but if the name does not include any useful versioning
information, it complains. we have no intention of versioning
libceph-common, as it is merely an internal shared library used by ceph
packages only. but there is no simple way to disable dpkg-shlibdeps'
warning of

  dpkg-shlibdeps: warning: can't extract name and version from library
  name 'libceph-common.so'

other than skipping the dpkg-shlibdeps for the whole package. so let's
just version it anyway.

Signed-off-by: Kefu Chai <kchai@redhat.com>

diff --git a/ceph.spec.in b/ceph.spec.in
index d673e85d974c91af65cec9945081f063fc421ee3..008298fe5133b20d293a2a436afee499f93933f9 100644 (file)
--- a/ceph.spec.in
+++ b/ceph.spec.in
@@ -1354,7 +1354,7 @@ fi
 %defattr(-,root,root,-)
 %{_libdir}/librados.so.*
 %dir %{_libdir}/ceph
-%{_libdir}/ceph/libceph-common.so
+%{_libdir}/ceph/libceph-common.so.*
 %if %{with lttng}
 %{_libdir}/librados_tp.so.*
 %endif

diff --git a/debian/librados2.install b/debian/librados2.install
index 1d937e8d19e18ce1b642ad391128bd2025f3ed2e..c8055fb8cb1d03bfe831c5b17c01c1959987b751 100644 (file)
--- a/debian/librados2.install
+++ b/debian/librados2.install
@@ -1,3 +1,3 @@
 usr/lib/librados.so.*
 usr/lib/librados_tp.so.*
-usr/lib/ceph/libceph-common.so
+usr/lib/ceph/libceph-common.so.*

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index c9afe4100d0fcd96f48d4faa899770073d4e14a5..da71587fcf42bdcd382bd8c7edeea24b3967dd53 100644 (file)
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -566,6 +566,9 @@ target_link_libraries(ceph-common json_spirit erasure_code rt ${LIB_RESOLV}
 if(NOT WITH_SYSTEM_BOOST)
   target_link_libraries(ceph-common ${ZLIB_LIBRARIES})
 endif()
+# appease dpkg-shlibdeps
+set_target_properties(ceph-common PROPERTIES
+  SOVERSION 0)
 install(TARGETS ceph-common DESTINATION ${CMAKE_INSTALL_PKGLIBDIR})
 if(WITH_EMBEDDED)
   add_library(cephd_common STATIC