]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commitdiff
fsstress: fix attr_set naming
authorDarrick J. Wong <djwong@kernel.org>
Wed, 7 May 2025 21:54:07 +0000 (14:54 -0700)
committerZorro Lang <zlang@kernel.org>
Thu, 8 May 2025 05:24:04 +0000 (13:24 +0800)
Back in 2020 I converted attr_set to lsetxattr, but neglected to notice
that the attr name now has to have the prefix "user." which attr_set
used to append for us.  Unfortunately nobody runs fsstress in verbose
mode so I didn't notice until now, and even then only because fuse2fs
stupidly accepts any name, even if that corrupts the filesystem.

Found by running generic/642 on fuse2fs.

Cc: fstests@vger.kernel.org # v2022.05.01
Fixes: 808f39a416c962 ("fsstress: stop using attr_set")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Zorro Lang <zlang@kernel.org>
ltp/fsstress.c

index 14c29921e8b0f87751f14de9d3a083844a39826a..ed9d5fa1efc3d96871f3e4f455edd21b31ef92ed 100644 (file)
@@ -2481,7 +2481,7 @@ attr_remove_f(opnum_t opno, long r)
 void
 attr_set_f(opnum_t opno, long r)
 {
-       char            aname[10];
+       char            aname[32];
        char            *aval;
        int             e;
        pathname_t      f;
@@ -2493,7 +2493,7 @@ attr_set_f(opnum_t opno, long r)
        init_pathname(&f);
        if (!get_fname(FT_ANYm, r, &f, NULL, NULL, &v))
                append_pathname(&f, ".");
-       sprintf(aname, "a%x", nameseq++);
+       sprintf(aname, "user.a%x", nameseq++);
        li = (int)(random() % (sizeof(lengths) / sizeof(lengths[0])));
        len = (int)(random() % lengths[li]);
        if (len == 0)