]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
qa/cephfs: add check in test_acls.py
authorRishabh Dave <ridave@redhat.com>
Mon, 18 Apr 2022 19:21:04 +0000 (00:51 +0530)
committerRishabh Dave <ridave@redhat.com>
Wed, 27 Apr 2022 09:14:37 +0000 (14:44 +0530)
In xfstests-dev, "./check generic/abcd" doesn't end in error even when
there is no test abcd in generic. It's better to check the stdout to
verify success and print the returncode, stdout and stderr of the
command in logs so that such error can be found out by reading logs.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
qa/tasks/cephfs/test_acls.py

index 03665d4dad595930a3ee32053a84bef266afbbd8..5a6e03472f05354a01e8bbd8f2309632800c272e 100644 (file)
@@ -38,3 +38,7 @@ class TestACLs(XFSTestsDev):
         stdout, stderr = proc.stdout.getvalue(), proc.stderr.getvalue()
         log.info(f'Command stdout -\n{stdout}')
         log.info(f'Command stderr -\n{stderr}')
+
+        self.assertEqual(proc.returncode, 0)
+        success_line = 'Passed all 1 tests'
+        self.assertIn(success_line, stdout)