]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
Merge pull request #10160 from jmunhoz/bugfix-16463-presigned-url
authorYehuda Sadeh <yehuda@redhat.com>
Fri, 16 Dec 2016 16:42:10 +0000 (08:42 -0800)
committerGitHub <noreply@github.com>
Fri, 16 Dec 2016 16:42:10 +0000 (08:42 -0800)
rgw: aws4: add presigned url bugfix in runtime

Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
1  2 
src/common/config_opts.h
src/rgw/rgw_rest_s3.cc
src/rgw/rgw_rest_s3.h

index 9479e07a96d8c266b364e56ed129afc7a21752b9,e8ef9b3b8aae5c7b2d6a79a62bdd87254f9dbdfd..c46dcdd5ecf3c366184aa9aded5152584e14dd63
@@@ -1399,10 -1329,9 +1399,11 @@@ OPTION(rgw_keystone_token_cache_size, O
  OPTION(rgw_keystone_revocation_interval, OPT_INT, 15 * 60)  // seconds between tokens revocation check
  OPTION(rgw_keystone_verify_ssl, OPT_BOOL, true) // should we try to verify keystone's ssl
  OPTION(rgw_keystone_implicit_tenants, OPT_BOOL, false)  // create new users in their own tenants of the same name
 +OPTION(rgw_cross_domain_policy, OPT_STR, "<allow-access-from domain=\"*\" secure=\"false\" />")
 +OPTION(rgw_healthcheck_disabling_path, OPT_STR, "") // path that existence causes the healthcheck to respond 503
  OPTION(rgw_s3_auth_use_rados, OPT_BOOL, true)  // should we try to use the internal credentials for s3?
  OPTION(rgw_s3_auth_use_keystone, OPT_BOOL, false)  // should we try to use keystone for s3?
+ OPTION(rgw_s3_auth_aws4_force_boto2_compat, OPT_BOOL, true) // force aws4 auth boto2 compatibility
  
  /* OpenLDAP-style LDAP parameter strings */
  /* rgw_ldap_uri  space-separated list of LDAP servers in URI format */
Simple merge
index f6bce8394f95874871189761494ef94eba592871,b7f49306d56174940cf6bf254cb61aac2b01be5b..91c73613ab677113602ee24cf8c2c5d44f1e43b4
@@@ -451,8 -445,11 +451,8 @@@ public
  
  class RGW_Auth_S3 {
  private:
 -  static std::mutex mtx;
 -  static rgw::LDAPHelper* ldh;
 -
    static int authorize_v2(RGWRados *store, struct req_state *s);
-   static int authorize_v4(RGWRados *store, struct req_state *s);
+   static int authorize_v4(RGWRados *store, struct req_state *s, bool force_boto2_compat = true);
    static int authorize_v4_complete(RGWRados *store, struct req_state *s,
                                  const string& request_payload,
                                  bool unsigned_payload);