]> git.apps.os.sepia.ceph.com Git - ceph-cm-ansible.git/commitdiff
Quote variables used by with_items
authorZack Cerza <zack@redhat.com>
Thu, 18 Feb 2016 17:48:26 +0000 (10:48 -0700)
committerZack Cerza <zack@redhat.com>
Mon, 27 Jun 2016 22:33:01 +0000 (16:33 -0600)
Signed-off-by: Zack Cerza <zack@redhat.com>
21 files changed:
roles/ansible-managed/tasks/main.yml
roles/cobbler/tasks/apt_systems.yml
roles/cobbler/tasks/main.yml
roles/cobbler/tasks/settings.yml
roles/cobbler/tasks/upload_templates.yml
roles/cobbler/tasks/yum_systems.yml
roles/cobbler_systems/tasks/populate_systems.yml
roles/common/tasks/rhel-entitlements.yml
roles/downstream-setup/tasks/disable_yum_repos.yml
roles/downstream-setup/tasks/enable_yum_repos.yml
roles/downstream-setup/tasks/remove_yum_repos.yml
roles/downstream-setup/tasks/yum_repos.yml
roles/gateway/tasks/packages.yml
roles/nameserver/tasks/packages.yml
roles/packages/tasks/packages.yml
roles/testnode/tasks/apt/packages.yml
roles/testnode/tasks/apt/repos.yml
roles/testnode/tasks/yum/packages.yml
roles/users/tasks/create_users.yml
roles/users/tasks/revoke_users.yml
roles/vmhost/tasks/libvirt.yml

index 64f37336ae83caf83c58034427f6dcaf9389db47..cf5f23e845c04b2cf199a8292c3906f8c525b1fc 100644 (file)
@@ -50,7 +50,7 @@
   authorized_key: 
     user: "{{ cm_user }}"
     key: "{{ item }}"
-  with_items: cm_user_ssh_keys
+  with_items: "{{ cm_user_ssh_keys }}"
   when: cm_user_ssh_keys is defined and
         cm_user is defined
   tags:
index 85cf3ffc1cf971092389462bc4fa7210b96464d8..7260d2002cd47a1f52e3d44b029d4ceff0593943 100644 (file)
@@ -9,5 +9,5 @@
   apt:
     name: "{{ item }}"
     state: latest
-  with_items: cobbler_extra_packages
+  with_items: "{{ cobbler_extra_packages }}"
   when: cobbler_extra_packages|length > 0
index 4e05169902413433e038840a3af00e55faa9cf8a..36b7542f5de88de33534dded232d99971ef4792b 100644 (file)
@@ -20,7 +20,7 @@
     content: "{{ item.data }}"
     dest: "{{ item.path }}"
     mode: '600'
-  with_items: cobbler_keys["{{ ansible_hostname }}"]
+  with_items: "{{ cobbler_keys[ansible_hostname] }}"
   no_log: true
 
 - name: Include package type specific vars.
index f4bb0edb295d5cdf9994c54529f803d2c07e7f81..b32135e4af45bfb2a536dcf72bc30fa04b63c9aa 100644 (file)
@@ -29,4 +29,4 @@
 
 - name: Update settings
   command: cobbler setting edit --name={{ item.name }} --value={{ item.value}}
-  with_items: settings
+  with_items: "{{ settings }}"
index c17b0204376306bd08ce8d85d785f2ddad11c4cb..99ca0395179949d561a5596a9d87286211d2bd77 100644 (file)
@@ -16,7 +16,7 @@
     owner: root
     group: root
     mode: 0644 
-  with_items: kickstarts
+  with_items: "{{ kickstarts }}"
   tags:
     - kickstarts
 
@@ -27,7 +27,7 @@
     owner: root
     group: root
     mode: 0644
-  with_items: snippets
+  with_items: "{{ snippets }}"
   tags:
     - snippets
 
@@ -38,7 +38,7 @@
     owner: root
     group: root
     mode: 0644
-  with_items: scripts
+  with_items: "{{ scripts }}"
   tags:
     - scripts
 
@@ -49,7 +49,7 @@
     owner: root
     group: root
     mode: 0744
-  with_items: triggers
+  with_items: "{{ triggers }}"
   tags:
     - triggers
 
@@ -70,6 +70,6 @@
     owner: root
     group: root
     mode: 0755
-  with_items: utils
+  with_items: "{{ utils }}"
   tags:
     - utils
index 305d0e01440190a3019ed3be2242d34eace4be60..486cb7b5cc36731b4e2532cf0198414f8c9ded5e 100644 (file)
@@ -9,7 +9,7 @@
   yum:
     name: "{{ item }}"
     state: latest
-  with_items: cobbler_extra_packages
+  with_items: "{{ cobbler_extra_packages }}"
   when: cobbler_extra_packages|length > 0
 
 # configure red hat specific things
index 9323a45d003e248a8536219e047ee6d68a2c0b6e..b3662060eda37241048d0d97c8eda503a3af4f2f 100644 (file)
@@ -15,7 +15,7 @@
 
 - name: Add missing systems to cobbler
   command: cobbler system add --name={{ item.split('.')[0] }} --profile={{ default_profile }} --mac={{ hostvars[item].mac }} --ip-address={{ hostvars[item].ip }} --interface={{ hostvars[item].interface|default(interface) }} --hostname={{ item.split('.')[0] }}.{{ lab_domain }} --kopts="{{ hostvars[item].kernel_options|default(kernel_options) }}" --ksmeta="{{ hostvars[item].kickstart_metadata|default(kickstart_metadata) }}" --power-type={{ hostvars[item].power_type|default(power_type) }} --power-address={{ item.split('.')[0] }}.{{ ipmi_domain }} --power-user={{ hostvars[item].power_user|default(power_user) }} --power-pass={{ hostvars[item].power_pass|default(power_pass) }} --netboot-enabled false
-  with_items: cobbler_systems_add
+  with_items: "{{ cobbler_systems_add }}"
 
 - name: set cobbler_systems_update
   set_fact:
@@ -24,4 +24,4 @@
 
 - name: Update existing systems in cobbler
   command: cobbler system edit --name={{ item.split('.')[0] }} --mac={{ hostvars[item].mac }} --ip-address={{ hostvars[item].ip }} --interface={{ hostvars[item].interface|default(interface) }} --hostname={{ item.split('.')[0] }}.{{ lab_domain }} --kopts="{{ hostvars[item].kernel_options|default(kernel_options) }}" --ksmeta="{{ hostvars[item].kickstart_metadata|default(kickstart_metadata) }}" --power-type={{ hostvars[item].power_type|default(power_type) }} --power-address={{ item.split('.')[0] }}.{{ ipmi_domain }} --power-user={{ hostvars[item].power_user|default(power_user) }} --power-pass={{ hostvars[item].power_pass|default(power_pass) }}
-  with_items: cobbler_systems_update
+  with_items: "{{ cobbler_systems_update }}"
index e51c53e583490498ccce4065a8d84aa429522c6a..ec00c09a8a1556bbf847041763daa418416cab19 100644 (file)
@@ -75,7 +75,7 @@
 
 - name: Enable necessary rhsm repos
   command: subscription-manager repos --enable {{ item }}
-  with_items: rhsm_repos
+  with_items: "{{ rhsm_repos }}"
   when: replace_repos
 
 - name: Remove old apt-mirror repository definition.
index 9c214ad6833d430b49b32084a3ce66906c16240d..b98382a8364b06b83132ebd83b24d5cbfa30eba3 100644 (file)
@@ -6,5 +6,5 @@
     regexp: "enabled=1"
     backrefs: yes
     state: present
-  with_items: repos
+  with_items: "{{ repos }}"
   ignore_errors: true
index 2c7eb6d255c5cd3286e23bf6b6314bd7c2bdfb09..1fa87f46d195023cdc61a1eb93d217e43023f5f7 100644 (file)
@@ -6,5 +6,5 @@
     regexp: "enabled=0"
     backrefs: yes
     state: present
-  with_items: repos
+  with_items: "{{ repos }}"
   ignore_errors: true
index 6f249ba6e50c22c2ca5173cf97371459dc353ead..fc3741d4db3f10aacc9d6869b317abac1526c103 100644 (file)
@@ -3,4 +3,4 @@
   file:
     path: "/etc/yum.repos.d/{{ item }}.repo"
     state: absent
-  with_items: repos
+  with_items: "{{ repos }}"
index 3625bf9aed1980a45494d4e3e483931c767e3d88..8cf7243871c4eabd76a28e4d2a290f50777a1be5 100644 (file)
@@ -4,4 +4,4 @@
     url: "{{ item.url }}"
     dest: "/etc/yum.repos.d/{{ item.name }}.repo"
     force: yes
-  with_items: repos
+  with_items: "{{ repos }}"
index 253d71ae2c4cd6f5236398d702d4f0482cadb57a..8a457b2584eeb0f5acd6a49b0ab0c6d21472b596 100644 (file)
@@ -7,4 +7,4 @@
     name: "{{ item }}"
     state: latest
     enablerepo: epel
-  with_items: packages
+  with_items: "{{ packages }}"
index b162592a375e640fd0bf5135ae2d666dd18a8ac0..f90bb36bb7da29518511b2ff2571808858468430 100644 (file)
@@ -7,4 +7,4 @@
     name: "{{ item }}"
     state: latest
     enablerepo: epel
-  with_items: packages
+  with_items: "{{ packages }}"
index 718c8408e2f69c2d2d1e8fb133cac0f7c52cb339..1eecd090550e7262b3a46284a3ab95ed5d76db88 100644 (file)
@@ -4,7 +4,7 @@
     update_cache: true
     name: "{{ item }}"
     state: "{{ state }}"
-  with_items: apt_packages
+  with_items: "{{ apt_packages }}"
   when: apt_packages|length > 0 and
         ansible_pkg_mgr == "apt"
 
@@ -12,6 +12,6 @@
   yum:
     name: "{{ item }}"
     state: "{{ state }}"
-  with_items: yum_packages
+  with_items: "{{ yum_packages }}"
   when: yum_packages|length > 0 and
         ansible_pkg_mgr == "yum"
index 7a19cb0c1c40d83b65b9ed9d59a2c795fb60c73c..74c5aebe7d3e396c8dd3cecc460188679010041f 100644 (file)
@@ -4,7 +4,7 @@
     name: "{{ item }}"
     state: absent
     force: yes
-  with_items: ceph_packages_to_remove|list + packages_to_remove|list
+  with_items: "{{ ceph_packages_to_remove|list + packages_to_remove|list }}"
   when: ceph_packages_to_remove|length > 0 or
         packages_to_remove|length > 0
 
@@ -13,7 +13,7 @@
     name: "{{ item }}"
     state: latest
     force: yes
-  with_items: packages_to_upgrade
+  with_items: "{{ packages_to_upgrade }}"
   when: packages_to_upgrade|length > 0
 
 - name: Upgrade non aarch64 packages
@@ -21,7 +21,7 @@
     name: "{{ item }}"
     state: latest
     force: yes
-  with_items: non_aarch64_packages_to_upgrade
+  with_items: "{{ non_aarch64_packages_to_upgrade }}"
   when:
     non_aarch64_packages_to_upgrade|length > 0 and
     ansible_architecture != "aarch64"
@@ -31,7 +31,7 @@
     name: "{{ item }}"
     state: present 
     force: yes
-  with_items: packages|list + common_packages|list
+  with_items: "{{ packages|list + common_packages|list }}"
   when: packages|length > 0 or
         common_packages|length > 0
 
@@ -40,5 +40,5 @@
     name: "{{ item }}"
     state: present
     force: yes
-  with_items: non_aarch64_packages|list + non_aarch64_common_packages|list
+  with_items: "{{ non_aarch64_packages|list + non_aarch64_common_packages|list }}"
   when: ansible_architecture != "aarch64"
index 57c40832af6107cd0dc2e1b1b01e9cc5913d4702..304c631a879f2939ce6103d95320ece2cae0bbcf 100644 (file)
@@ -8,7 +8,7 @@
 
 - name: Remove custom repos
   file: path=/etc/apt/sources.list.d/{{ item }} state=absent
-  with_items: custom_repos.stdout_lines
+  with_items: "{{ custom_repos.stdout_lines }}"
   # Ignore changes here because we will be removing repos that we end up re-adding later
   changed_when: false
 
@@ -54,6 +54,6 @@
     state: present
     update_cache: no 
     mode: 0644
-  with_items: apt_repos|list + common_apt_repos|list
+  with_items: "{{ apt_repos|list + common_apt_repos|list }}"
   register: local_apt_repos
   when: ansible_architecture != "aarch64"
index c8ad1247ace250a46b3fa6b928c6ba8b1b113025..abd3dae83e3220aaa9bd6fd9460e490394b2e688 100644 (file)
@@ -28,7 +28,7 @@
   yum:
     name: "{{ item }}"
     state: absent
-  with_items: ceph_packages_to_remove
+  with_items: "{{ ceph_packages_to_remove }}"
   tags:
     - remove-ceph
 
@@ -36,7 +36,7 @@
   yum:
     name: "{{ item }}"
     state: absent
-  with_items: ceph_dependency_packages_to_remove
+  with_items: "{{ ceph_dependency_packages_to_remove }}"
   tags:
     - remove-ceph-dependency
 
@@ -45,7 +45,7 @@
   yum:
     name: "{{ item }}"
     state: present 
-  with_items: packages
+  with_items: "{{ packages }}"
   when: packages|length > 0
 
 - name: Install epel packages
     name: "{{ item }}"
     state: present
     enablerepo: epel
-  with_items: epel_packages
+  with_items: "{{ epel_packages }}"
   when: epel_packages|length > 0
 
 - name: Remove packages
   yum:
     name: "{{ item }}"
     state: absent
-  with_items: packages_to_remove
+  with_items: "{{ packages_to_remove }}"
   when: packages_to_remove|length > 0
 
 - name: Upgrade packages
   yum:
     name: "{{ item }}"
     state: latest
-  with_items: packages_to_upgrade
+  with_items: "{{ packages_to_upgrade }}"
   when: packages_to_upgrade|length > 0
index 9596c6b03d3014dc3e3cdf72f5376c1055ddaa53..4b94808f7cee81050b13b1c1bbe4db5b218d11c0 100644 (file)
     groups: sudo
     shell: /bin/bash
     state: present
-  with_items: managed_admin_users
+  with_items: "{{ managed_admin_users }}"
 
 - name: Create all users without sudo access.
   user:
     name: "{{ item.name }}"
     shell: /bin/bash
     state: present
-  with_items: managed_users
+  with_items: "{{ managed_users }}"
index c81ef2bef6a0fae1ee334af2ae1a219c24bd4f2c..c7300998992a2427bae04202257ef426aad7c43d 100644 (file)
@@ -13,4 +13,4 @@
   user:
     name: "{{ item }}"
     state: absent
-  with_items: revoked_users
+  with_items: "{{ revoked_users }}"
index cca6b24ab6e6e03d639174627b58937b9232561f..451ab9a9b92959ce4e54d5fcc268d59dcc6e3908 100644 (file)
@@ -49,7 +49,7 @@
 
 - name: See which pools are defined and which are not
   shell: virsh pool-info {{ item }}
-  with_items: ls_libvirtpool.stdout_lines
+  with_items: "{{ ls_libvirtpool.stdout_lines }}"
   register: pool_info
   when: srv_libvirtpool.stat.exists
   # don't bother reporting anything about this command; it's not useful