generic: Verify if statx() can qurey S_DAX flag on regular file correctly

1) With new kernel(e.g. v5.8-rc1), statx() can be used to qurey S_DAX flag
   on regular file, so add a test to verify the feature.
2) Factor out _check_s_dax() so that other tests can use it in future.

Reference:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=712b2698e4c024b561694cbcc1abba13eb0fd9ce

Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>

diff --git a/common/rc b/common/rc
index 98bb1454e90cb96abad8e97dd6455e70b29ed4c2..de431c7a6afc32bd55d27ac89458666f0126cc2e 100644 (file)
--- a/common/rc
+++ b/common/rc
@@ -3196,6 +3196,19 @@ _require_scratch_shutdown()
        _scratch_unmount
 }
 
+_check_s_dax()
+{
+       local target=$1
+       local exp_s_dax=$2
+
+       local attributes=$($XFS_IO_PROG -c 'statx -r' $target | awk '/stat.attributes / { print $3 }')
+       if [ $exp_s_dax -eq 0 ]; then
+               (( attributes & 0x2000 )) && echo "$target has unexpected S_DAX flag"
+       else
+               (( attributes & 0x2000 )) || echo "$target doen't have expected S_DAX flag"
+       fi
+}
+
 # Check if dax mount options are supported
 #
 # $1 can be either 'dax=always' or 'dax'

diff --git a/tests/generic/606 b/tests/generic/606
new file mode 100755 (executable)
index 0000000..bf7d822
--- /dev/null
+++ b/tests/generic/606
@@ -0,0 +1,92 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2020 Fujitsu.  All Rights Reserved.
+#
+# FS QA Test 606
+#
+# By the following cases, verify if statx() can query S_DAX flag
+# on regular file correctly.
+# 1) With dax=always option, FS_XFLAG_DAX is ignored and S_DAX flag
+#    always exists on regular file.
+# 2) With dax=inode option, setting/clearing FS_XFLAG_DAX can change
+#    S_DAX flag on regular file.
+# 3) With dax=never option, FS_XFLAG_DAX is ignored and S_DAX flag
+#    never exists on regular file.
+#
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1        # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+       cd /
+       rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
+_supported_fs generic
+_supported_os Linux
+_require_scratch_dax_mountopt "dax=always"
+_require_dax_iflag
+_require_xfs_io_command "statx" "-r"
+
+PARENT_DIR=$SCRATCH_MNT/testdir
+TEST_FILE=$PARENT_DIR/testfile
+
+test_s_dax()
+{
+       local dax_option=$1
+       local exp_s_dax1=$2
+       local exp_s_dax2=$3
+
+       # Mount with specified dax option
+       _scratch_mount "$dax_option"
+
+       # Prepare directory
+       mkdir -p $PARENT_DIR
+
+       rm -f $TEST_FILE
+       $XFS_IO_PROG -c "chattr +x" $PARENT_DIR
+       touch $TEST_FILE
+       # Check if setting FS_XFLAG_DAX changes S_DAX flag
+       _check_s_dax $TEST_FILE $exp_s_dax1
+
+       rm -f $TEST_FILE
+       $XFS_IO_PROG -c "chattr -x" $PARENT_DIR
+       touch $TEST_FILE
+       # Check if clearing FS_XFLAG_DAX changes S_DAX flag
+       _check_s_dax $TEST_FILE $exp_s_dax2
+
+       _scratch_unmount
+}
+
+do_tests()
+{
+       _scratch_mkfs >> $seqres.full 2>&1
+
+       # Mount with specified dax option
+       test_s_dax "-o dax=always" 1 1
+       test_s_dax "-o dax=never" 0 0
+       test_s_dax "-o dax=inode" 1 0
+       # Mount without dax option
+       export MOUNT_OPTIONS=""
+       test_s_dax "" 1 0
+}
+
+do_tests
+
+# success, all done
+echo "Silence is golden"
+status=0
+exit

diff --git a/tests/generic/606.out b/tests/generic/606.out
new file mode 100644 (file)
index 0000000..09bf888
--- /dev/null
+++ b/tests/generic/606.out
@@ -0,0 +1,2 @@
+QA output created by 606
+Silence is golden

diff --git a/tests/generic/group b/tests/generic/group
index d06c1bf64cfe3db5c8dbfea7c60811345b7f5c2b..05c6b02db97870482e0e21dd72052e90011eae5d 100644 (file)
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -608,3 +608,4 @@
 603 auto quick quota
 604 auto quick mount
 605 auto attr quick dax
+606 auto attr quick dax