common/Finisher: pass name as std::string_view to ctor

This eliminates a temporary `std::string`.

Additionally, convert the `tn` parameter to an rvalue reference and
move it to `thread_name`.

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

diff --git a/src/common/Finisher.cc b/src/common/Finisher.cc
index c6d3746d8c0540bc9c8229f6df54b7a9ea278a41..43550f351973e2baa665ba0f0570c3de2d9949a7 100644 (file)
--- a/src/common/Finisher.cc
+++ b/src/common/Finisher.cc
@@ -15,9 +15,9 @@ Finisher::Finisher(CephContext *cct_) :
   thread_name("fn_anonymous"),
   finisher_thread(this) {}
 
-Finisher::Finisher(CephContext *cct_, std::string name, std::string tn) :
+Finisher::Finisher(CephContext *cct_, std::string_view name, std::string &&tn) :
   cct(cct_), finisher_lock(ceph::make_mutex(fmt::format("Finisher::{}", name))),
-  thread_name(tn),
+  thread_name(std::move(tn)),
   finisher_thread(this) {
   PerfCountersBuilder b(cct, fmt::format("finisher-{}", name),
                        l_finisher_first, l_finisher_last);

diff --git a/src/common/Finisher.h b/src/common/Finisher.h
index 1a89f4289b71573475b086b756ed1381e222d8a5..acee6594ca4da327fe6cf19d8137581083682eaf 100644 (file)
--- a/src/common/Finisher.h
+++ b/src/common/Finisher.h
@@ -122,7 +122,7 @@ class Finisher {
   explicit Finisher(CephContext *cct_);
 
   /// Construct a named Finisher that logs its queue length.
-  Finisher(CephContext *cct_, std::string name, std::string tn);
+  Finisher(CephContext *cct_, std::string_view name, std::string &&tn);
   ~Finisher();
 };