Revert "common/config: create $RESULT_BASE before dumping kmemleak leaks"

This commit tried to fix the brokennes of the kmemleak support but it
inadvertently broke the creation of the RESULT_BASE directory which lead to
problems creating check.time file. Turns out kmemleak support in xfstests has
more problems and it needs to be majorly refactor and this commit doesn't
really solve the problem. For the time being just revert to at least allow
older configuration files, which have explicitly set RESULT_BASE to work.

This reverts commit 7fc034868d5dce9aaf3517c9c2197221b9a772e4.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Eryu Guan <guaneryu@gmail.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>

diff --git a/check b/check
index e4d767375b57ba758aa50760b39f75da53a0363a..77a06b00dbba677f9c04ca6d9a5e266ec67579eb 100755 (executable)
--- a/check
+++ b/check
@@ -538,6 +538,13 @@ for section in $HOST_OPTIONS_SECTIONS; do
                fi
        fi
 
+       mkdir -p $RESULT_BASE
+       if [ ! -d $RESULT_BASE ]; then
+               echo "failed to create results directory $RESULT_BASE"
+               status=1
+               exit
+       fi
+
        if $OPTIONS_HAVE_SECTIONS; then
                echo "SECTION       -- $section"
        fi

diff --git a/common/config b/common/config
index a788be6bc1d468d65934501294e88f2263e6aaf0..64f87057f5d733beb4f4999583ccd79d2353772e 100644 (file)
--- a/common/config
+++ b/common/config
@@ -665,11 +665,6 @@ get_next_config() {
        # set default RESULT_BASE
        if [ -z "$RESULT_BASE" ]; then
                export RESULT_BASE="$here/results/"
-               mkdir -p ${RESULT_BASE}
-               if [ ! -d ${RESULT_BASE} ]; then
-                       echo "failed to create results directory $RESULT_BASE"
-                       exit 1
-               fi
        fi
 
        if [ "$FSTYP" == "tmpfs" ]; then