xfstests: btrfs/009: regression test for subvol delete

We were allowing users to delete their default subvolume, which is problematic.
This test is a regression test to make sure we don't let that happen in the
future.  Thanks,

Signed-off-by: Josef Bacik <jbacik@fusionio.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Rich Johnston <rjohnston@sgi.com>
[rjohnston: renumbered test from 003 to 009]

diff --git a/common/rc b/common/rc
index fe6bbfcbfc553e60c7c7683afc3349518d71acdd..fe02f7996b5f1920ffaddf83529d07d0f2bd7961 100644 (file)
--- a/common/rc
+++ b/common/rc
@@ -57,6 +57,14 @@ dd()
    fi
 }
 
+_btrfs_get_subvolid()
+{
+       mnt=$1
+       name=$2
+
+       $BTRFS_UTIL_PROG sub list $mnt | grep $name | awk '{ print $2 }'
+}
+
 # Prints the md5 checksum of a given file
 _md5_checksum()
 {

diff --git a/tests/btrfs/009 b/tests/btrfs/009
new file mode 100755 (executable)
index 0000000..d46744c
--- /dev/null
+++ b/tests/btrfs/009
@@ -0,0 +1,63 @@
+#! /bin/bash
+# FS QA Test No. btrfs/009
+#
+# Regression test to make sure we can't delete the default subvol
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2013 Fusion IO.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+
+status=1       # failure is the default!
+
+_cleanup()
+{
+       rm -f $tmp.*
+}
+
+trap "_cleanup ; exit \$status" 0 1 2 3 15
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# real QA test starts here
+_supported_fs btrfs
+_supported_os Linux
+_require_scratch
+
+_scratch_mkfs > /dev/null 2>&1
+_scratch_mount
+
+$BTRFS_UTIL_PROG sub create $SCRATCH_MNT/newvol >> $seqres.full 2>&1 \
+       || _fail "couldn't create subvol"
+subvolid=$(_btrfs_get_subvolid $SCRATCH_MNT newvol)
+$BTRFS_UTIL_PROG sub set-default $subvolid $SCRATCH_MNT >> $seqres.full 2>&1 \
+       || _fail "couldn't set default"
+$BTRFS_UTIL_PROG sub delete $SCRATCH_MNT/newvol >> $seqres.full 2>&1
+_scratch_unmount
+_scratch_mount || _fail "mount should have succeeded"
+
+echo "Silence is golden"
+status=0 ; exit

diff --git a/tests/btrfs/009.out b/tests/btrfs/009.out
new file mode 100644 (file)
index 0000000..7e97715
--- /dev/null
+++ b/tests/btrfs/009.out
@@ -0,0 +1,2 @@
+QA output created by 009
+Silence is golden

diff --git a/tests/btrfs/group b/tests/btrfs/group
index 12fcb5a7a47939fe7519ec5675cb30e2ba59aef5..9eabadcf1886f9b6b21411e53f5a9d75f3646631 100644 (file)
--- a/tests/btrfs/group
+++ b/tests/btrfs/group
@@ -11,3 +11,4 @@
 006 auto quick
 007 auto rw metadata
 008 auto quick
+009 auto quick