]> git.apps.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
mgr/cephadm: do not remove service spec when removing a daemon
authorSage Weil <sage@redhat.com>
Fri, 28 Feb 2020 21:32:04 +0000 (15:32 -0600)
committerSage Weil <sage@redhat.com>
Sun, 1 Mar 2020 14:10:54 +0000 (08:10 -0600)
This makes our behavior similar to kube: if you kill a pod, the operator
or controller will come along and create a new one (probably somewhere
else).

Signed-off-by: Sage Weil <sage@redhat.com>
src/pybind/mgr/cephadm/module.py

index 13b7de454c8db9b35f72bdcf8ab689a4f94145bf..9c4c4709c163e7ba29155b9d6343b33a8290d1c7 100644 (file)
@@ -1710,10 +1710,6 @@ class CephadmOrchestrator(orchestrator.Orchestrator, MgrModule):
             for name in names:
                 if name in dm:
                     args.append((name, host, force))
-                    # TODO: bail out for OSDs when https://github.com/ceph/ceph/pull/32983 is merged
-                    if dm[name].daemon_type == 'osd':
-                        continue
-                    self._remove_key_from_store(dm[name].service_name())
         if not args:
             raise OrchestratorError('Unable to find daemon(s) %s' % (names))
         self.log.info('Remove daemons %s' % [a[0] for a in args])