]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commitdiff
xfs/074: specify filesystem size in terms of size not block count
authorEryu Guan <eguan@redhat.com>
Mon, 21 Sep 2015 01:05:44 +0000 (11:05 +1000)
committerDave Chinner <david@fromorbit.com>
Mon, 21 Sep 2015 01:05:44 +0000 (11:05 +1000)
When testing 512 block size xfs, xfs/074 fails as

   QA output created by 074
  +fallocate: No space left on device
   Silence is golden

That's because 40051712*512=20G < 30G.

And quote from Dave:

  That was sized to give AGs of a specific size, which originally
  contributed to the problem being exposed. You should change the block
  count specification to a size specification so the filesysetm being
  made on 4k block size filesystems remains unchanged.

  size    = 40051712b
          = 40051712 * 4096
          = 164,051,812,352
          = 156452m

So set the filesystem size to 156452m explicitly.

Suggested-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
tests/xfs/074

index a571a3414f3af09fe7057f1c347a50ada89e845a..9f24512ed895e0cdb025ce88ee3d29befcfaef3b 100755 (executable)
@@ -62,7 +62,7 @@ mkdir -p $LOOP_MNT
 $XFS_IO_PROG -ft -c "truncate 1t" $LOOP_FILE >> $seqres.full
 LOOP_DEV=`_create_loop_device $LOOP_FILE`
 
-_mkfs_dev -d size=40051712b,agcount=4 -l size=32m $LOOP_DEV
+_mkfs_dev -d size=156452m,agcount=4 -l size=32m $LOOP_DEV
 _mount $LOOP_DEV $LOOP_MNT
 
 # Corrupt the BMBT by creating extents larger than MAXEXTLEN