]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-ci.git/commitdiff
src: replace push_back(T{}) with emplace_back()
authorKefu Chai <tchaikov@gmail.com>
Tue, 26 Aug 2025 05:28:56 +0000 (13:28 +0800)
committerKefu Chai <tchaikov@gmail.com>
Tue, 26 Aug 2025 05:39:59 +0000 (13:39 +0800)
in ed6b7124, we switched from some instances of `push_back(Type{})`
patterns to `emplace_back()` to simplify the code and to avoid
unnecessary overhead of copy/move constructor calls. but there were
still remaining instances of them in `generate_test_instance()`
member function implementations.

in this change, we switched all of them to be more consistent.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
122 files changed:
src/auth/Auth.h
src/auth/cephx/CephxKeyServer.h
src/auth/cephx/CephxProtocol.h
src/cls/2pc_queue/cls_2pc_queue_ops.h
src/cls/2pc_queue/cls_2pc_queue_types.h
src/cls/cas/cls_cas_internal.h
src/cls/cas/cls_cas_ops.h
src/cls/fifo/cls_fifo.cc
src/cls/fifo/cls_fifo_ops.h
src/cls/fifo/cls_fifo_types.h
src/cls/journal/cls_journal_types.cc
src/cls/lock/cls_lock_ops.cc
src/cls/lock/cls_lock_types.cc
src/cls/log/cls_log_ops.h
src/cls/log/cls_log_types.h
src/cls/queue/cls_queue_ops.h
src/cls/queue/cls_queue_types.h
src/cls/rbd/cls_rbd.h
src/cls/rbd/cls_rbd_types.cc
src/cls/refcount/cls_refcount_ops.cc
src/cls/rgw/cls_rgw_ops.cc
src/cls/rgw/cls_rgw_ops.h
src/cls/rgw/cls_rgw_types.cc
src/cls/rgw/cls_rgw_types.h
src/cls/rgw_gc/cls_rgw_gc_ops.h
src/cls/rgw_gc/cls_rgw_gc_types.h
src/cls/timeindex/cls_timeindex_ops.h
src/cls/timeindex/cls_timeindex_types.cc
src/cls/user/cls_user_ops.cc
src/cls/user/cls_user_types.cc
src/cls/version/cls_version_ops.h
src/cls/version/cls_version_types.h
src/common/CompatSet.cc
src/common/LogEntry.cc
src/common/SloppyCRCMap.cc
src/common/bit_vector.hpp
src/common/ceph_json.h
src/common/entity_name.cc
src/common/frag.cc
src/common/fs_types.cc
src/common/histogram.cc
src/common/hobject.cc
src/common/snap_types.cc
src/include/cephfs/types.h
src/include/filepath.cc
src/include/object.cc
src/include/types.cc
src/include/types.h
src/include/util.h
src/mds/Anchor.cc
src/mds/Capability.cc
src/mds/inode_backtrace.cc
src/mds/mdstypes.cc
src/mds/mdstypes.h
src/mds/snap.cc
src/messages/MClientReply.h
src/messages/MClientRequest.h
src/messages/MMDSBeacon.h
src/messages/MMDSCacheRejoin.h
src/messages/MMgrReport.h
src/mgr/MDSPerfMetricTypes.h
src/mgr/MetricTypes.h
src/mgr/MgrCap.cc
src/mgr/OSDPerfMetricTypes.h
src/mgr/ServiceMap.cc
src/mon/AuthMonitor.h
src/mon/ConnectionTracker.cc
src/mon/CreatingPGs.h
src/mon/MgrMap.h
src/mon/MonCap.cc
src/mon/MonCommand.h
src/mon/MonMap.cc
src/mon/MonitorDBStore.h
src/mon/PGMap.cc
src/mon/PGMap.h
src/mon/health_check.h
src/mon/mon_types.h
src/os/SequencerPosition.h
src/os/Transaction.cc
src/os/bluestore/bluefs_types.cc
src/os/bluestore/bluestore_types.cc
src/os/bluestore/bluestore_types.h
src/osd/HitSet.cc
src/osd/HitSet.h
src/osd/OSDMap.cc
src/osd/OSDMap.h
src/osd/SnapMapper.cc
src/osd/SnapMapper.h
src/osd/osd_types.cc
src/osd/osd_types.h
src/rgw/driver/rados/groups.cc
src/rgw/driver/rados/rgw_bucket.cc
src/rgw/driver/rados/rgw_data_sync.cc
src/rgw/driver/rados/rgw_datalog.cc
src/rgw/driver/rados/rgw_obj_manifest.cc
src/rgw/driver/rados/rgw_rados.cc
src/rgw/driver/rados/rgw_user.h
src/rgw/driver/rados/roles.cc
src/rgw/driver/rados/users.cc
src/rgw/rgw_acl.cc
src/rgw/rgw_basic_types.cc
src/rgw/rgw_basic_types.h
src/rgw/rgw_cache.cc
src/rgw/rgw_common.cc
src/rgw/rgw_common.h
src/rgw/rgw_cors.cc
src/rgw/rgw_dencoder.cc
src/rgw/rgw_lc.cc
src/rgw/rgw_log.cc
src/rgw/rgw_metadata.cc
src/rgw/rgw_multi.cc
src/rgw/rgw_obj_types.h
src/rgw/rgw_object_lock.cc
src/rgw/rgw_oidc_provider.cc
src/rgw/rgw_placement_types.h
src/rgw/rgw_pool_types.h
src/rgw/rgw_quota.cc
src/rgw/rgw_realm.cc
src/rgw/rgw_sync_policy.cc
src/rgw/rgw_tag.cc
src/rgw/rgw_zone.cc
src/rgw/rgw_zone_types.h

index 366aeb69ce50392b225564573ddf13ffe3ae21fb..feb19ccbfb7b7a0d523cc8165251aff8e9a26b30 100644 (file)
@@ -76,7 +76,7 @@ struct EntityAuth {
   }
   static std::list<EntityAuth> generate_test_instances() {
     std::list<EntityAuth> ls;
-    ls.push_back(EntityAuth{});
+    ls.emplace_back();
     return ls;
   }
 };
@@ -122,10 +122,10 @@ struct AuthCapsInfo {
   }
   static std::list<AuthCapsInfo> generate_test_instances() {
     std::list<AuthCapsInfo> ls;
-    ls.push_back(AuthCapsInfo{});
-    ls.push_back(AuthCapsInfo{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().allow_all = true;
-    ls.push_back(AuthCapsInfo{});
+    ls.emplace_back();
     ls.back().caps.append("foo");
     ls.back().caps.append("bar");
     return ls;
@@ -190,8 +190,8 @@ struct AuthTicket {
   }
   static std::list<AuthTicket> generate_test_instances() {
     std::list<AuthTicket> ls;
-    ls.push_back(AuthTicket{});
-    ls.push_back(AuthTicket{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().name.set_id("client.123");
     ls.back().global_id = 123;
     ls.back().init_timestamps(utime_t(123, 456), 7);
@@ -290,8 +290,8 @@ struct ExpiringCryptoKey {
   }
   static std::list<ExpiringCryptoKey> generate_test_instances() {
     std::list<ExpiringCryptoKey> ls;
-    ls.push_back(ExpiringCryptoKey{});
-    ls.push_back(ExpiringCryptoKey{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().key.set_secret(
       CEPH_CRYPTO_AES, bufferptr("1234567890123456", 16), utime_t(123, 456));
     return ls;
@@ -365,8 +365,8 @@ struct RotatingSecrets {
   }
   static std::list<RotatingSecrets> generate_test_instances() {
     std::list<RotatingSecrets> ls;
-    ls.push_back(RotatingSecrets{});
-    ls.push_back(RotatingSecrets{});
+    ls.emplace_back();
+    ls.emplace_back();
     ExpiringCryptoKey eck{};
     ls.back().add(eck);
     return ls;
index addac53e7260ca3712a39e1acbf96ad26aee13ec..1dbfb15475ee41eb4925c664479ad15bca35c28a 100644 (file)
@@ -80,8 +80,8 @@ struct KeyServerData {
   }
   static std::list<KeyServerData> generate_test_instances() {
     std::list<KeyServerData> ls;
-    ls.push_back(KeyServerData{});
-    ls.push_back(KeyServerData{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().version = 1;
     return ls;
   }
@@ -180,11 +180,11 @@ struct KeyServerData {
     }
     static std::list<Incremental> generate_test_instances() {
       std::list<Incremental> ls;
-      ls.push_back(Incremental{});
+      ls.emplace_back();
       ls.back().op = AUTH_INC_DEL;
-      ls.push_back(Incremental{});
+      ls.emplace_back();
       ls.back().op = AUTH_INC_ADD;
-      ls.push_back(Incremental{});
+      ls.emplace_back();
       ls.back().op = AUTH_INC_SET_ROTATING;
       return ls;
     }
index f47eb8856dcee0075d5083e4a61aece8f879f8f1..3e7bdb2c58f604709a3439dc49dd5fa589947d5a 100644 (file)
@@ -60,7 +60,7 @@ struct CephXServerChallenge {
   }
   static std::list<CephXServerChallenge> generate_test_instances() {
     std::list<CephXServerChallenge> ls;
-    ls.push_back(CephXServerChallenge{});
+    ls.emplace_back();
     ls.back().server_challenge = 1;
     return ls;
   }
@@ -86,7 +86,7 @@ struct CephXRequestHeader {
   }
   static std::list<CephXRequestHeader> generate_test_instances() {
     std::list<CephXRequestHeader> ls;
-    ls.push_back(CephXRequestHeader{});
+    ls.emplace_back();
     ls.back().request_type = 1;
     return ls;
   }
@@ -113,7 +113,7 @@ struct CephXResponseHeader {
   }
   static std::list<CephXResponseHeader> generate_test_instances() {
     std::list<CephXResponseHeader> ls;
-    ls.push_back(CephXResponseHeader{});
+    ls.emplace_back();
     ls.back().request_type = 1;
     ls.back().status = 0;
     return ls;
@@ -150,7 +150,7 @@ struct CephXTicketBlob {
 
   static std::list<CephXTicketBlob> generate_test_instances() {
     std::list<CephXTicketBlob> ls;
-    ls.push_back(CephXTicketBlob{});
+    ls.emplace_back();
     ls.back().secret_id = 123;
     ls.back().blob.append(std::string_view("this is a blob"));
     return ls;
@@ -204,10 +204,10 @@ struct CephXAuthenticate {
   }
   static std::list<CephXAuthenticate> generate_test_instances() {
     std::list<CephXAuthenticate> ls;
-    ls.push_back(CephXAuthenticate{});
+    ls.emplace_back();
     ls.back().client_challenge = 0;
     ls.back().key = 0;
-    ls.push_back(CephXAuthenticate{});
+    ls.emplace_back();
     ls.back().client_challenge = 1;
     ls.back().key = 2;
     ls.back().old_ticket.secret_id = 3;
@@ -237,7 +237,7 @@ struct CephXChallengeBlob {
   }
   static std::list<CephXChallengeBlob> generate_test_instances() {
     std::list<CephXChallengeBlob> ls;
-    ls.push_back(CephXChallengeBlob{});
+    ls.emplace_back();
     ls.back().server_challenge = 123;
     ls.back().client_challenge = 456;
     return ls;
@@ -299,7 +299,7 @@ struct CephXServiceTicketRequest {
 
   static std::list<CephXServiceTicketRequest> generate_test_instances() {
     std::list<CephXServiceTicketRequest> ls;
-    ls.push_back(CephXServiceTicketRequest{});
+    ls.emplace_back();
     ls.back().keys = 123;
     return ls;
   }
@@ -342,9 +342,9 @@ struct CephXAuthorizeReply {
   }
   static std::list<CephXAuthorizeReply> generate_test_instances() {
     std::list<CephXAuthorizeReply> ls;
-    ls.push_back(CephXAuthorizeReply{});
+    ls.emplace_back();
     ls.back().nonce_plus_one = 0;
-    ls.push_back(CephXAuthorizeReply{});
+    ls.emplace_back();
     ls.back().nonce_plus_one = 123;
     ls.back().connection_secret = "secret";
     return ls;
@@ -457,8 +457,8 @@ struct CephXServiceTicket {
   }
   static std::list<CephXServiceTicket> generate_test_instances() {
     std::list<CephXServiceTicket> ls;
-    ls.push_back(CephXServiceTicket{});
-    ls.push_back(CephXServiceTicket{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().session_key.set_secret(
       CEPH_CRYPTO_AES, bufferptr("1234567890123456", 16), utime_t(123, 456));
     ls.back().validity = utime_t(123, 456);
@@ -492,8 +492,8 @@ struct CephXServiceTicketInfo {
   }
   static std::list<CephXServiceTicketInfo> generate_test_instances() {
     std::list<CephXServiceTicketInfo> ls;
-    ls.push_back(CephXServiceTicketInfo{});
-    ls.push_back(CephXServiceTicketInfo{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().ticket.global_id = 1234;
     ls.back().ticket.init_timestamps(utime_t(123, 456), utime_t(123, 456));
     ls.back().session_key.set_secret(
@@ -522,7 +522,7 @@ struct CephXAuthorizeChallenge : public AuthAuthorizerChallenge {
   }
   static std::list<CephXAuthorizeChallenge> generate_test_instances() {
     std::list<CephXAuthorizeChallenge> ls;
-    ls.push_back(CephXAuthorizeChallenge{});
+    ls.emplace_back();
     ls.back().server_challenge = 1234;
     return ls;
   }
@@ -558,8 +558,8 @@ struct CephXAuthorize {
   }
   static std::list<CephXAuthorize> generate_test_instances() {
     std::list<CephXAuthorize> ls;
-    ls.push_back(CephXAuthorize{});
-    ls.push_back(CephXAuthorize{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().nonce = 1234;
     ls.back().have_challenge = true;
     ls.back().server_challenge_plus_one = 1234;
index 65435c521f8b9a741291405203b22bd69b7fc44f..66c1ac22e8e5e6a34ee5899e4daed8ca643b3632 100644 (file)
@@ -32,9 +32,9 @@ struct cls_2pc_queue_reserve_op {
 
   static std::list<cls_2pc_queue_reserve_op> generate_test_instances() {
     std::list<cls_2pc_queue_reserve_op> ls;
-    ls.push_back(cls_2pc_queue_reserve_op{});
+    ls.emplace_back();
     ls.back().size = 0;
-    ls.push_back(cls_2pc_queue_reserve_op{});
+    ls.emplace_back();
     ls.back().size = 123;
     ls.back().entries = 456;
     return ls;
@@ -63,7 +63,7 @@ struct cls_2pc_queue_reserve_ret {
 
   static std::list<cls_2pc_queue_reserve_ret> generate_test_instances() {
     std::list<cls_2pc_queue_reserve_ret> ls;
-    ls.push_back(cls_2pc_queue_reserve_ret{});
+    ls.emplace_back();
     ls.back().id = 123;
     return ls;
   }
@@ -95,7 +95,7 @@ struct cls_2pc_queue_commit_op {
 
   static std::list<cls_2pc_queue_commit_op> generate_test_instances() {
     std::list<cls_2pc_queue_commit_op> ls;
-    ls.push_back(cls_2pc_queue_commit_op{});
+    ls.emplace_back();
     ls.back().id = 123;
     ls.back().bl_data_vec.push_back(ceph::buffer::list());
     ls.back().bl_data_vec.back().append("foo");
@@ -125,7 +125,7 @@ struct cls_2pc_queue_abort_op {
   }
   static std::list<cls_2pc_queue_abort_op> generate_test_instances() {
     std::list<cls_2pc_queue_abort_op> ls;
-    ls.push_back(cls_2pc_queue_abort_op{});
+    ls.emplace_back();
     ls.back().id = 1;
     return ls;
   }
@@ -152,8 +152,8 @@ struct cls_2pc_queue_expire_op {
   }
   static std::list<cls_2pc_queue_expire_op> generate_test_instances() {
     std::list<cls_2pc_queue_expire_op> ls;
-    ls.push_back(cls_2pc_queue_expire_op{});
-    ls.push_back(cls_2pc_queue_expire_op{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().stale_time = ceph::coarse_real_time::min();
     return ls;
   }
@@ -187,8 +187,8 @@ struct cls_2pc_queue_reservations_ret {
 
   static std::list<cls_2pc_queue_reservations_ret> generate_test_instances() {
     std::list<cls_2pc_queue_reservations_ret> ls;
-    ls.push_back(cls_2pc_queue_reservations_ret{});
-    ls.push_back(cls_2pc_queue_reservations_ret{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().reservations[1] = cls_2pc_reservation();
     ls.back().reservations[2] = cls_2pc_reservation();
     return ls;
index c64ce58632f7193e38ae5412a70ae6bf9a0483be..5c12f26b11461e8f64451116785a200960fcb342 100644 (file)
@@ -44,9 +44,9 @@ struct cls_2pc_reservation
 
   static std::list<cls_2pc_reservation> generate_test_instances() {
     std::list<cls_2pc_reservation> ls;
-    ls.push_back(cls_2pc_reservation{});
+    ls.emplace_back();
     ls.back().size = 0;
-    ls.push_back(cls_2pc_reservation{});
+    ls.emplace_back();
     ls.back().size = 123;
     ls.back().timestamp = ceph::coarse_real_clock::zero();
     return ls;
@@ -102,8 +102,8 @@ struct cls_2pc_urgent_data
 
   static std::list<cls_2pc_urgent_data> generate_test_instances() {
     std::list<cls_2pc_urgent_data> ls;
-    ls.push_back(cls_2pc_urgent_data{});
-    ls.push_back(cls_2pc_urgent_data{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().reserved_size = 123;
     ls.back().last_id = 456;
     ls.back().reservations.emplace(789, cls_2pc_reservation(1, ceph::coarse_real_clock::zero(), 2));
index a4020566eead7129be0dd9aa0adf1cd389187c0a..f535b2c6cd814305480721d5959f85667505ce73 100644 (file)
@@ -95,7 +95,7 @@ struct chunk_refs_t {
   }
   static std::list<chunk_refs_t> generate_test_instances() {
     std::list<chunk_refs_t> ls;
-    ls.push_back(chunk_refs_t{});
+    ls.emplace_back();
     return ls;
   }
 };
@@ -149,8 +149,8 @@ struct chunk_refs_by_object_t : public chunk_refs_t::refs_t {
   }
   static std::list<chunk_refs_by_object_t> generate_test_instances() {
     std::list<chunk_refs_by_object_t> ls;
-    ls.push_back(chunk_refs_by_object_t{});
-    ls.push_back(chunk_refs_by_object_t{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().by_object.insert(hobject_t(sobject_t("foo", CEPH_NOSNAP)));
     ls.back().by_object.insert(hobject_t(sobject_t("bar", CEPH_NOSNAP)));
     return ls;
@@ -398,8 +398,8 @@ struct chunk_refs_count_t : public chunk_refs_t::refs_t {
   }
   static std::list<chunk_refs_count_t> generate_test_instances() {
     std::list<chunk_refs_count_t> o;
-    o.push_back(chunk_refs_count_t{});
-    o.push_back(chunk_refs_count_t{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().total = 123;
     return o;
   }
index fdc3ea9fc7cf0006cfbf6dfef31e2bf1fd822653..916c00ede20b69883dc9fc82df8c8686c7604bf6 100644 (file)
@@ -41,7 +41,7 @@ struct cls_cas_chunk_create_or_get_ref_op {
   }
   static std::list<cls_cas_chunk_create_or_get_ref_op> generate_test_instances() {
     std::list<cls_cas_chunk_create_or_get_ref_op> ls;
-    ls.push_back(cls_cas_chunk_create_or_get_ref_op{});
+    ls.emplace_back();
     return ls;
   }
 };
@@ -69,7 +69,7 @@ struct cls_cas_chunk_get_ref_op {
   }
   static std::list<cls_cas_chunk_get_ref_op> generate_test_instances() {
     std::list<cls_cas_chunk_get_ref_op> ls;
-    ls.push_back(cls_cas_chunk_get_ref_op{});
+    ls.emplace_back();
     return ls;
   }
 };
@@ -98,7 +98,7 @@ struct cls_cas_chunk_put_ref_op {
   }
   static std::list<cls_cas_chunk_put_ref_op> generate_test_instances() {
     std::list<cls_cas_chunk_put_ref_op> ls;
-    ls.push_back(cls_cas_chunk_put_ref_op{});
+    ls.emplace_back();
     return ls;
   }
 };
index 6526f7ee51d3ce2d24e6f291f35445a2b52068ca..9d78eb8f01ea31b3e5ee75903b72c67ceb4f00b6 100644 (file)
@@ -59,8 +59,8 @@ struct entry_header {
   }
   static std::list<entry_header> generate_test_instances() {
     std::list<entry_header> ls;
-    ls.push_back(entry_header{});
-    ls.push_back(entry_header{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().mtime = ceph::real_clock::now();
     return ls;
   }
index 0328e4ca0f901a7b479eb7bd16efa6e250728a55..45a8732df75c41078e637fd2dfb0b130042ef04e 100644 (file)
@@ -79,8 +79,8 @@ struct create_meta
   }
   static std::list<create_meta> generate_test_instances() {
     std::list<create_meta> o;
-    o.push_back(create_meta{});
-    o.push_back(create_meta{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().id = "id";
     objv v1;
     v1.instance = "inst1";
@@ -116,8 +116,8 @@ struct get_meta
   }
   static std::list<get_meta> generate_test_instances() {
     std::list<get_meta> o;
-    o.push_back(get_meta{});
-    o.push_back(get_meta{});
+    o.emplace_back();
+    o.emplace_back();
     objv v1;
     v1.instance = "inst1";
     v1.ver = 1;
@@ -155,8 +155,8 @@ struct get_meta_reply
   }
   static std::list<get_meta_reply> generate_test_instances() {
     std::list<get_meta_reply> o;
-    o.push_back(get_meta_reply{});
-    o.push_back(get_meta_reply{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().info = fifo::info();
     o.back().part_header_size = 1024;
     o.back().part_entry_overhead = 1024;
index 03f1d58cad2ea715d9331553022aec589d97d13c..d74ef5309f9ef9b1b7cc31a74f56c4b95bcce46b 100644 (file)
@@ -121,8 +121,8 @@ struct data_params {
   }
   static std::list<data_params> generate_test_instances() {
     std::list<data_params> o;
-    o.push_back(data_params{});
-    o.push_back(data_params{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().max_part_size = 1;
     o.back().max_entry_size = 2;
     o.back().full_size_threshold = 3;
@@ -443,8 +443,8 @@ struct info {
   }
   static std::list<info> generate_test_instances() {
     std::list<info> o;
-    o.push_back(info{});
-    o.push_back(info{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().id = "myid";
     o.back().version = objv();
     o.back().oid_prefix = "myprefix";
index d311811165b244dfaba91dab1c7b0c4dac9c542a..530110ce6cb3d18b56e531743c1963edc848e478 100644 (file)
@@ -35,7 +35,7 @@ void ObjectPosition::dump(Formatter *f) const {
 
 std::list<ObjectPosition> ObjectPosition::generate_test_instances() {
   std::list<ObjectPosition> o;
-  o.push_back(ObjectPosition{});
+  o.emplace_back();
   o.push_back(ObjectPosition(1, 2, 3));
   return o;
 }
@@ -64,7 +64,7 @@ void ObjectSetPosition::dump(Formatter *f) const {
 
 std::list<ObjectSetPosition> ObjectSetPosition::generate_test_instances() {
   std::list<ObjectSetPosition> o;
-  o.push_back(ObjectSetPosition{});
+  o.emplace_back();
   o.push_back(ObjectSetPosition({{0, 1, 120}, {121, 2, 121}}));
   return o;
 }
@@ -142,7 +142,7 @@ void Tag::dump(Formatter *f) const {
 
 std::list<Tag> Tag::generate_test_instances() {
   std::list<Tag> o;
-  o.push_back(Tag{});
+  o.emplace_back();
 
   bufferlist data;
   data.append(std::string(128, '1'));
index 2d4e607b9e47e37399c50f6ff34962128b47c06a..77f04936a4c788f086bf1a38bf6a66788e6e944a 100644 (file)
@@ -51,7 +51,7 @@ list<cls_lock_lock_op> cls_lock_lock_op::generate_test_instances()
   i.duration = utime_t(5, 0);
   i.flags = LOCK_FLAG_MAY_RENEW;
   o.push_back(std::move(i));
-  o.push_back(cls_lock_lock_op{});
+  o.emplace_back();
   return o;
 }
 
@@ -68,7 +68,7 @@ list<cls_lock_unlock_op> cls_lock_unlock_op::generate_test_instances()
   i.name = "name";
   i.cookie = "cookie";
   o.push_back(std::move(i));
-  o.push_back(cls_lock_unlock_op{});
+  o.emplace_back();
   return o;
 }
 
@@ -87,7 +87,7 @@ list<cls_lock_break_op> cls_lock_break_op::generate_test_instances()
   i.cookie = "cookie";
   i.locker =  entity_name_t::CLIENT(1);
   o.push_back(std::move(i));
-  o.push_back(cls_lock_break_op{});
+  o.emplace_back();
   return o;
 }
 
@@ -102,7 +102,7 @@ list<cls_lock_get_info_op> cls_lock_get_info_op::generate_test_instances()
   cls_lock_get_info_op i;
   i.name = "name";
   o.push_back(std::move(i));
-  o.push_back(cls_lock_get_info_op{});
+  o.emplace_back();
   return o;
 }
 
@@ -154,7 +154,7 @@ list<cls_lock_get_info_reply> cls_lock_get_info_reply::generate_test_instances()
   i.lockers[id2] = locker_info_t(utime_t(20, 0), addr2, "description2");
 
   o.push_back(std::move(i));
-  o.push_back(cls_lock_get_info_reply{});
+  o.emplace_back();
   return o;
 }
 
@@ -179,7 +179,7 @@ list<cls_lock_list_locks_reply> cls_lock_list_locks_reply::generate_test_instanc
   i.locks.push_back("lock3");
 
   o.push_back(std::move(i));
-  o.push_back(cls_lock_list_locks_reply{});
+  o.emplace_back();
   return o;
 }
 
@@ -200,7 +200,7 @@ list<cls_lock_assert_op> cls_lock_assert_op::generate_test_instances()
   i.cookie = "cookie";
   i.tag = "tag";
   o.push_back(std::move(i));
-  o.push_back(cls_lock_assert_op{});
+  o.emplace_back();
   return o;
 }
 
@@ -223,7 +223,7 @@ list<cls_lock_set_cookie_op> cls_lock_set_cookie_op::generate_test_instances()
   i.tag = "tag";
   i.new_cookie = "new cookie";
   o.push_back(std::move(i));
-  o.push_back(cls_lock_set_cookie_op{});
+  o.emplace_back();
   return o;
 }
 
index 5bf7f8602b8673c731121d2192271858a869957d..65936141d4bc4c4bf315f2ad90d12e1a52a1d713 100644 (file)
@@ -36,7 +36,7 @@ std::list<locker_id_t> locker_id_t::generate_test_instances()
   locker_id_t i;
   generate_lock_id(i, 1, "cookie");
   o.push_back(std::move(i));
-  o.push_back(locker_id_t{});
+  o.emplace_back();
   return o;
 }
 
@@ -67,7 +67,7 @@ std::list<locker_info_t> locker_info_t::generate_test_instances()
   generate_test_addr(i.addr, 1, 2);
   i.description = "description";
   o.push_back(std::move(i));
-  o.push_back(locker_info_t{});
+  o.emplace_back();
   return o;
 }
 
@@ -99,6 +99,6 @@ std::list<lock_info_t> lock_info_t::generate_test_instances()
   i.lock_type = ClsLockType::EXCLUSIVE;
   i.tag = "tag";
   o.push_back(std::move(i));
-  o.push_back(lock_info_t{});
+  o.emplace_back();
   return o;
 }
index d0609aa0e4254e27d44d65dd33f1e20a3d7dda13..00f561c9e20a5cabc2e24efaae37d7e8601a7802 100644 (file)
@@ -45,8 +45,8 @@ struct add_op {
     std::list<add_op> l;
     l.emplace_back();
     l.emplace_back();
-    l.back().entries.push_back(entry{});
-    l.back().entries.push_back(entry{});
+    l.back().entries.emplace_back();
+    l.back().entries.emplace_back();
     l.back().entries.back().section = "section";
     l.back().entries.back().name = "name";
     l.back().entries.back().timestamp = ceph::real_time{1s + 2ns};
@@ -137,8 +137,8 @@ struct list_ret {
     std::list<list_ret> ls;
     ls.emplace_back();
     ls.emplace_back();
-    ls.back().entries.push_back(entry{});
-    ls.back().entries.push_back(entry{});
+    ls.back().entries.emplace_back();
+    ls.back().entries.emplace_back();
     ls.back().entries.back().section = "section";
     ls.back().entries.back().name = "name";
     ls.back().entries.back().timestamp = ceph::real_time{1s + 2ns};
index 75f9116563c51d711fe6bc046e8a004b740f26b2..b4d963ba82be33497ecd84cd2d16c0a53d2a0a26 100644 (file)
@@ -71,8 +71,8 @@ struct entry {
 
   static std::list<cls::log::entry> generate_test_instances() {
     std::list<cls::log::entry> l;
-    l.push_back(cls::log::entry{});
-    l.push_back(cls::log::entry{});
+    l.emplace_back();
+    l.emplace_back();
     l.back().id = "test_id";
     l.back().section = "test_section";
     l.back().name = "test_name";
@@ -109,8 +109,8 @@ struct header {
   }
   static std::list<header> generate_test_instances() {
     std::list<header> o;
-    o.push_back(header{});
-    o.push_back(header{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().max_marker = "test_marker";
     o.back().max_time = ceph::real_clock::zero();
     return o;
index db0e901a5c392fec5db3099aa1496c46880dc5df..517dc0c2eaa76840eb357c564e0b1d2e1c5bc020 100644 (file)
@@ -38,8 +38,8 @@ struct cls_queue_init_op {
 
   static std::list<cls_queue_init_op> generate_test_instances() {
     std::list<cls_queue_init_op> o;
-    o.push_back(cls_queue_init_op{});
-    o.push_back(cls_queue_init_op{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().queue_size = 1024;
     o.back().max_urgent_data_size = 1024;
     o.back().bl_urgent_data.append(std::string_view("data"));
@@ -71,8 +71,8 @@ struct cls_queue_enqueue_op {
 
   static std::list<cls_queue_enqueue_op> generate_test_instances() {
     std::list<cls_queue_enqueue_op> o;
-    o.push_back(cls_queue_enqueue_op{});
-    o.push_back(cls_queue_enqueue_op{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().bl_data_vec.push_back(ceph::buffer::list());
     o.back().bl_data_vec.back().append(std::string_view("data"));
     return o;
@@ -112,8 +112,8 @@ struct cls_queue_list_op {
 
   static std::list<cls_queue_list_op> generate_test_instances() {
     std::list<cls_queue_list_op> o;
-    o.push_back(cls_queue_list_op{});
-    o.push_back(cls_queue_list_op{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().max = 123;
     o.back().start_marker = "foo";
     return o;
@@ -152,7 +152,7 @@ struct cls_queue_list_ret {
 
   static std::list<cls_queue_list_ret> generate_test_instances() {
     std::list<cls_queue_list_ret> o;
-    o.push_back(cls_queue_list_ret{});
+    o.emplace_back();
     o.back().is_truncated = true;
     o.back().next_marker = "foo";
     o.back().entries.push_back(cls_queue_entry());
@@ -186,8 +186,8 @@ struct cls_queue_remove_op {
   }
   static std::list<cls_queue_remove_op> generate_test_instances() {
     std::list<cls_queue_remove_op> o;
-    o.push_back(cls_queue_remove_op{});
-    o.push_back(cls_queue_remove_op{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().end_marker = "foo";
     return o;
   }
@@ -216,7 +216,7 @@ struct cls_queue_get_capacity_ret {
   }
   static std::list<cls_queue_get_capacity_ret> generate_test_instances() {
     std::list<cls_queue_get_capacity_ret> o;
-    o.push_back(cls_queue_get_capacity_ret{});
+    o.emplace_back();
     o.back().queue_capacity = 123;
     return o;
   }
index 7d31e57ac06af4ab526b533e59e15070d79d6625..138d6ca44f4241a6b586e8529e2c9b3c4a65cd59 100644 (file)
@@ -41,8 +41,8 @@ struct cls_queue_entry
   }
   static std::list<cls_queue_entry> generate_test_instances() {
     std::list<cls_queue_entry> o;
-    o.push_back(cls_queue_entry{});
-    o.push_back(cls_queue_entry{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().data.append(std::string_view("data"));
     o.back().marker = "marker";
     return o;
@@ -99,8 +99,8 @@ struct cls_queue_marker
   }
   static std::list<cls_queue_marker> generate_test_instances() {
     std::list<cls_queue_marker> o;
-    o.push_back(cls_queue_marker{});
-    o.push_back(cls_queue_marker{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().offset = 1024;
     o.back().gen = 0;
     return o;
@@ -150,8 +150,8 @@ struct cls_queue_head
   }
   static std::list<cls_queue_head> generate_test_instances() {
     std::list<cls_queue_head> o;
-    o.push_back(cls_queue_head{});
-    o.push_back(cls_queue_head{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().max_head_size = 1024;
     o.back().front.offset = 1024;
     o.back().front.gen = 0;
index 91df6d20e103b35922ab1b84df6b9d4f34b212f1..32ac460de6037869418ce428584b96061054415f 100644 (file)
@@ -95,7 +95,7 @@ struct cls_rbd_parent {
 
   static std::list<cls_rbd_parent> generate_test_instances() {
     std::list<cls_rbd_parent> o;
-    o.push_back(cls_rbd_parent{});
+    o.emplace_back();
     o.push_back(cls_rbd_parent{{1, "", "image id", 234}, {}});
     o.push_back(cls_rbd_parent{{1, "", "image id", 234}, {123}});
     o.push_back(cls_rbd_parent{{1, "ns", "image id", 234}, {123}});
index 794dbfee104206577e17688bcd044312a6da58da..b312b8a8573394f083681ff9cb464a5093d4e03d 100644 (file)
@@ -539,7 +539,7 @@ void ParentImageSpec::dump(Formatter *f) const {
 
 std::list<ParentImageSpec> ParentImageSpec::generate_test_instances() {
   std::list<ParentImageSpec> o;
-  o.push_back(ParentImageSpec{});
+  o.emplace_back();
   o.push_back(ParentImageSpec{1, "", "foo", 3});
   o.push_back(ParentImageSpec{1, "ns", "foo", 3});
   return o;
index 22d6ae36284a15ee4286bf820f3d0f332317daab..2286438b370b3e62cd12c6acce8aab4b403bf606 100644 (file)
@@ -16,8 +16,8 @@ void cls_refcount_get_op::dump(ceph::Formatter *f) const
 list<cls_refcount_get_op> cls_refcount_get_op::generate_test_instances()
 {
   list<cls_refcount_get_op> ls;
-  ls.push_back(cls_refcount_get_op{});
-  ls.push_back(cls_refcount_get_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().tag = "foo";
   ls.back().implicit_ref = true;
   return ls;
@@ -33,8 +33,8 @@ void cls_refcount_put_op::dump(ceph::Formatter *f) const
 list<cls_refcount_put_op> cls_refcount_put_op::generate_test_instances()
 {
   list<cls_refcount_put_op> ls;
-  ls.push_back(cls_refcount_put_op{});
-  ls.push_back(cls_refcount_put_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().tag = "foo";
   ls.back().implicit_ref = true;
   return ls;
@@ -50,8 +50,8 @@ void cls_refcount_set_op::dump(ceph::Formatter *f) const
 list<cls_refcount_set_op> cls_refcount_set_op::generate_test_instances()
 {
   list<cls_refcount_set_op> ls;
-  ls.push_back(cls_refcount_set_op{});
-  ls.push_back(cls_refcount_set_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().refs.push_back("foo");
   ls.back().refs.push_back("bar");
   return ls;
@@ -66,8 +66,8 @@ void cls_refcount_read_op::dump(ceph::Formatter *f) const
 list<cls_refcount_read_op> cls_refcount_read_op::generate_test_instances()
 {
   list<cls_refcount_read_op> ls;
-  ls.push_back(cls_refcount_read_op{});
-  ls.push_back(cls_refcount_read_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   return ls;
 }
 
@@ -83,8 +83,8 @@ void cls_refcount_read_ret::dump(ceph::Formatter *f) const
 list<cls_refcount_read_ret> cls_refcount_read_ret::generate_test_instances()
 {
   list<cls_refcount_read_ret> ls;
-  ls.push_back(cls_refcount_read_ret{});
-  ls.push_back(cls_refcount_read_ret{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().refs.push_back("foo");
   ls.back().refs.push_back("bar");
   return ls;
@@ -110,7 +110,7 @@ void obj_refcount::dump(ceph::Formatter *f) const
 list<obj_refcount> obj_refcount::generate_test_instances()
 {
   list<obj_refcount> ls;
-  ls.push_back(obj_refcount{});
+  ls.emplace_back();
   ls.back().refs.emplace("foo",true);
   ls.back().retired_refs.emplace("bar");
   return ls;
index 7a0c58454e900e575d77d80340858ff1ca09abae..5d4034ae13ce916a4b63626a0e1f3c6781594c80 100644 (file)
@@ -20,8 +20,8 @@ void rgw_cls_tag_timeout_op::dump(Formatter *f) const
 list<rgw_cls_tag_timeout_op> rgw_cls_tag_timeout_op::generate_test_instances()
 {
   list<rgw_cls_tag_timeout_op> ls;
-  ls.push_back(rgw_cls_tag_timeout_op{});
-  ls.push_back(rgw_cls_tag_timeout_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().tag_timeout = 23323;
   return ls;
 }
@@ -37,8 +37,8 @@ void cls_rgw_gc_set_entry_op::dump(Formatter *f) const
 list<cls_rgw_gc_set_entry_op> cls_rgw_gc_set_entry_op::generate_test_instances()
 {
   list<cls_rgw_gc_set_entry_op> ls;
-  ls.push_back(cls_rgw_gc_set_entry_op{});
-  ls.push_back(cls_rgw_gc_set_entry_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().expiration_secs = 123;
   return ls;
 }
@@ -52,8 +52,8 @@ void cls_rgw_gc_defer_entry_op::dump(Formatter *f) const
 list<cls_rgw_gc_defer_entry_op> cls_rgw_gc_defer_entry_op::generate_test_instances()
 {
   list<cls_rgw_gc_defer_entry_op> ls;
-  ls.push_back(cls_rgw_gc_defer_entry_op{});
-  ls.push_back(cls_rgw_gc_defer_entry_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().expiration_secs = 123;
   ls.back().tag = "footag";
   return ls;
@@ -69,8 +69,8 @@ void cls_rgw_gc_list_op::dump(Formatter *f) const
 list<cls_rgw_gc_list_op> cls_rgw_gc_list_op::generate_test_instances()
 {
   list<cls_rgw_gc_list_op> ls;
-  ls.push_back(cls_rgw_gc_list_op{});
-  ls.push_back(cls_rgw_gc_list_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().marker = "mymarker";
   ls.back().max = 2312;
   return ls;
@@ -86,8 +86,8 @@ void cls_rgw_gc_list_ret::dump(Formatter *f) const
 list<cls_rgw_gc_list_ret> cls_rgw_gc_list_ret::generate_test_instances()
 {
   list<cls_rgw_gc_list_ret> ls;
-  ls.push_back(cls_rgw_gc_list_ret{});
-  ls.push_back(cls_rgw_gc_list_ret{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().entries.push_back(cls_rgw_gc_obj_info());
   ls.back().truncated = true;
   return ls;
@@ -101,8 +101,8 @@ void cls_rgw_gc_remove_op::dump(Formatter *f) const
 list<cls_rgw_gc_remove_op> cls_rgw_gc_remove_op::generate_test_instances()
 {
   list<cls_rgw_gc_remove_op> ls;
-  ls.push_back(cls_rgw_gc_remove_op{});
-  ls.push_back(cls_rgw_gc_remove_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().tags.push_back("tag1");
   ls.back().tags.push_back("tag2");
   return ls;
@@ -117,7 +117,7 @@ list<cls_rgw_lc_get_entry_ret> cls_rgw_lc_get_entry_ret::generate_test_instances
 {
   list<cls_rgw_lc_get_entry_ret> ls;
   cls_rgw_lc_entry entry("bucket1", 6000, 0);
-  ls.push_back(cls_rgw_lc_get_entry_ret{});
+  ls.emplace_back();
   ls.back().entry = entry;
   return ls;
 }
@@ -131,7 +131,7 @@ list<rgw_cls_obj_prepare_op> rgw_cls_obj_prepare_op::generate_test_instances()
   op.tag = "tag";
   op.locator = "locator";
   o.push_back(std::move(op));
-  o.push_back(rgw_cls_obj_prepare_op{});
+  o.emplace_back();
   return o;
 }
 
@@ -159,7 +159,7 @@ list<rgw_cls_obj_complete_op> rgw_cls_obj_complete_op::generate_test_instances()
   op.meta = *iter;
 
   o.push_back(std::move(op));
-  o.push_back(rgw_cls_obj_complete_op{});
+  o.emplace_back();
   return o;
 }
 
@@ -197,7 +197,7 @@ list<rgw_cls_link_olh_op> rgw_cls_link_olh_op::generate_test_instances()
 
   o.push_back(std::move(op));
 
-  o.push_back(rgw_cls_link_olh_op{});
+  o.emplace_back();
   return o;
 }
 
@@ -228,7 +228,7 @@ list<rgw_cls_unlink_instance_op> rgw_cls_unlink_instance_op::generate_test_insta
 
   o.push_back(std::move(op));
 
-  o.push_back(rgw_cls_unlink_instance_op{});
+  o.emplace_back();
   return o;
 }
 
@@ -251,7 +251,7 @@ list<rgw_cls_read_olh_log_op> rgw_cls_read_olh_log_op::generate_test_instances()
   op.olh_tag = "olh_tag";
 
   o.push_back(std::move(op));
-  o.push_back(rgw_cls_read_olh_log_op{});
+  o.emplace_back();
   return o;
 }
 
@@ -272,7 +272,7 @@ list<rgw_cls_read_olh_log_ret> rgw_cls_read_olh_log_ret::generate_test_instances
   r.log[1].push_back(*iter);
 
   o.push_back(std::move(r));
-  o.push_back(rgw_cls_read_olh_log_ret{});
+  o.emplace_back();
   return o;
 }
 
@@ -291,7 +291,7 @@ list<rgw_cls_trim_olh_log_op> rgw_cls_trim_olh_log_op::generate_test_instances()
   op.olh_tag = "olh_tag";
 
   o.push_back(std::move(op));
-  o.push_back(rgw_cls_trim_olh_log_op{});
+  o.emplace_back();
   return o;
 }
 
@@ -310,7 +310,7 @@ list<rgw_cls_bucket_clear_olh_op> rgw_cls_bucket_clear_olh_op::generate_test_ins
   op.olh_tag = "olh_tag";
 
   o.push_back(std::move(op));
-  o.push_back(rgw_cls_bucket_clear_olh_op{});
+  o.emplace_back();
   return o;
 }
 
@@ -328,7 +328,7 @@ list<rgw_cls_list_op> rgw_cls_list_op::generate_test_instances()
   op.num_entries = 100;
   op.filter_prefix = "filter_prefix";
   o.push_back(std::move(op));
-  o.push_back(rgw_cls_list_op{});
+  o.emplace_back();
   return o;
 }
 
@@ -349,7 +349,7 @@ list<rgw_cls_list_ret> rgw_cls_list_ret::generate_test_instances()
     o.push_back(std::move(ret));
   }
 
-  o.push_back(rgw_cls_list_ret{});
+  o.emplace_back();
   return o;
 }
 
@@ -371,7 +371,7 @@ list<rgw_cls_check_index_ret> rgw_cls_check_index_ret::generate_test_instances()
   r.calculated_header = h.front();
   o.push_back(std::move(r));
 
-  o.push_back(rgw_cls_check_index_ret{});
+  o.emplace_back();
   return o;
 }
 
@@ -396,7 +396,7 @@ list<rgw_cls_bucket_update_stats_op> rgw_cls_bucket_update_stats_op::generate_te
   dec_s.total_size_rounded = 4096;
   dec_s.num_entries = 1;
   o.push_back(std::move(r));
-  o.push_back(rgw_cls_bucket_update_stats_op{});
+  o.emplace_back();
   return o;
 }
 
@@ -424,8 +424,8 @@ void cls_rgw_bi_log_list_op::dump(Formatter *f) const
 list<cls_rgw_bi_log_list_op> cls_rgw_bi_log_list_op::generate_test_instances()
 {
   list<cls_rgw_bi_log_list_op> ls;
-  ls.push_back(cls_rgw_bi_log_list_op{});
-  ls.push_back(cls_rgw_bi_log_list_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().marker = "mark";
   ls.back().max = 123;
   return ls;
@@ -440,8 +440,8 @@ void cls_rgw_bi_log_trim_op::dump(Formatter *f) const
 list<cls_rgw_bi_log_trim_op> cls_rgw_bi_log_trim_op::generate_test_instances()
 {
   list<cls_rgw_bi_log_trim_op> ls;
-  ls.push_back(cls_rgw_bi_log_trim_op{});
-  ls.push_back(cls_rgw_bi_log_trim_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().start_marker = "foo";
   ls.back().end_marker = "bar";
   return ls;
@@ -456,8 +456,8 @@ void cls_rgw_bi_log_list_ret::dump(Formatter *f) const
 list<cls_rgw_bi_log_list_ret> cls_rgw_bi_log_list_ret::generate_test_instances()
 {
   list<cls_rgw_bi_log_list_ret> ls;
-  ls.push_back(cls_rgw_bi_log_list_ret{});
-  ls.push_back(cls_rgw_bi_log_list_ret{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().entries.push_back(rgw_bi_log_entry());
   ls.back().truncated = true;
   return ls;
@@ -466,9 +466,9 @@ list<cls_rgw_bi_log_list_ret> cls_rgw_bi_log_list_ret::generate_test_instances()
 std::list<cls_rgw_mp_upload_part_info_update_op> cls_rgw_mp_upload_part_info_update_op::generate_test_instances()
 {
   std::list<cls_rgw_mp_upload_part_info_update_op> ls;
-  ls.push_back(cls_rgw_mp_upload_part_info_update_op{});
+  ls.emplace_back();
   ls.back().part_key = "part1";
-  ls.push_back(cls_rgw_mp_upload_part_info_update_op{});
+  ls.emplace_back();
   ls.back().part_key = "part2";
   return ls;
 }
@@ -483,8 +483,8 @@ void cls_rgw_mp_upload_part_info_update_op::dump(Formatter* f) const
 list<cls_rgw_reshard_add_op> cls_rgw_reshard_add_op::generate_test_instances()
 {
   list<cls_rgw_reshard_add_op> ls;
-  ls.push_back(cls_rgw_reshard_add_op{});
-  ls.push_back(cls_rgw_reshard_add_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   list<cls_rgw_reshard_entry> l = cls_rgw_reshard_entry::generate_test_instances();
   auto iter = l.begin();
   ls.back().entry = *iter;
@@ -499,8 +499,8 @@ void cls_rgw_reshard_add_op::dump(Formatter *f) const
 list<cls_rgw_reshard_list_op> cls_rgw_reshard_list_op::generate_test_instances()
 {
   list<cls_rgw_reshard_list_op> ls;
-  ls.push_back(cls_rgw_reshard_list_op{});
-  ls.push_back(cls_rgw_reshard_list_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().max = 1000;
   ls.back().marker = "foo";
   return ls;
@@ -515,8 +515,8 @@ void cls_rgw_reshard_list_op::dump(Formatter *f) const
 list<cls_rgw_reshard_list_ret> cls_rgw_reshard_list_ret::generate_test_instances()
 {
   list<cls_rgw_reshard_list_ret> ls;
-  ls.push_back(cls_rgw_reshard_list_ret{});
-  ls.push_back(cls_rgw_reshard_list_ret{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().entries.push_back(cls_rgw_reshard_entry());
   ls.back().is_truncated = true;
   return ls;
@@ -531,8 +531,8 @@ void cls_rgw_reshard_list_ret::dump(Formatter *f) const
 list<cls_rgw_reshard_get_op> cls_rgw_reshard_get_op::generate_test_instances()
 {
   list<cls_rgw_reshard_get_op> ls;
-  ls.push_back(cls_rgw_reshard_get_op{});
-  ls.push_back(cls_rgw_reshard_get_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   return ls;
 }
 
@@ -544,8 +544,8 @@ void cls_rgw_reshard_get_op::dump(Formatter *f) const
 list<cls_rgw_reshard_get_ret> cls_rgw_reshard_get_ret::generate_test_instances()
 {
   list<cls_rgw_reshard_get_ret> ls;
-  ls.push_back(cls_rgw_reshard_get_ret{});
-  ls.push_back(cls_rgw_reshard_get_ret{});
+  ls.emplace_back();
+  ls.emplace_back();
   return ls;
 }
 
@@ -557,8 +557,8 @@ void cls_rgw_reshard_get_ret::dump(Formatter *f) const
 list<cls_rgw_reshard_remove_op> cls_rgw_reshard_remove_op::generate_test_instances()
 {
   list<cls_rgw_reshard_remove_op> ls;
-  ls.push_back(cls_rgw_reshard_remove_op{});
-  ls.push_back(cls_rgw_reshard_remove_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().bucket_name = "foo";
   ls.back().bucket_id = "bucket_id";
   return ls;
@@ -574,8 +574,8 @@ void cls_rgw_reshard_remove_op::dump(Formatter *f) const
 list<cls_rgw_set_bucket_resharding_op> cls_rgw_set_bucket_resharding_op::generate_test_instances()
 {
   list<cls_rgw_set_bucket_resharding_op> ls;
-  ls.push_back(cls_rgw_set_bucket_resharding_op{});
-  ls.push_back(cls_rgw_set_bucket_resharding_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   return ls;
 }
 
@@ -587,8 +587,8 @@ void cls_rgw_set_bucket_resharding_op::dump(Formatter *f) const
 list<cls_rgw_clear_bucket_resharding_op> cls_rgw_clear_bucket_resharding_op::generate_test_instances()
 {
   list<cls_rgw_clear_bucket_resharding_op> ls;
-  ls.push_back(cls_rgw_clear_bucket_resharding_op{});
-  ls.push_back(cls_rgw_clear_bucket_resharding_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   return ls;
 }
 
@@ -599,8 +599,8 @@ void cls_rgw_clear_bucket_resharding_op::dump(Formatter *f) const
 list<cls_rgw_guard_bucket_resharding_op> cls_rgw_guard_bucket_resharding_op::generate_test_instances()
 {
   list<cls_rgw_guard_bucket_resharding_op> ls;
-  ls.push_back(cls_rgw_guard_bucket_resharding_op{});
-  ls.push_back(cls_rgw_guard_bucket_resharding_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   return ls;
 }
 
@@ -613,8 +613,8 @@ void cls_rgw_guard_bucket_resharding_op::dump(Formatter *f) const
 list<cls_rgw_get_bucket_resharding_op> cls_rgw_get_bucket_resharding_op::generate_test_instances()
 {
   list<cls_rgw_get_bucket_resharding_op> ls;
-  ls.push_back(cls_rgw_get_bucket_resharding_op{});
-  ls.push_back(cls_rgw_get_bucket_resharding_op{});
+  ls.emplace_back();
+  ls.emplace_back();
   return ls;
 }
 
index 5b63280eeffc1d10fc723027bc1077c6d9096264..be5606aee8ed9596480b1fef3059ab96c9a461c7 100644 (file)
@@ -536,7 +536,7 @@ struct rgw_cls_obj_remove_op {
 
   static std::list<rgw_cls_obj_remove_op> generate_test_instances() {
     std::list<rgw_cls_obj_remove_op> o;
-    o.push_back(rgw_cls_obj_remove_op{});
+    o.emplace_back();
     o.back().keep_attr_prefixes.push_back("keep_attr_prefixes1");
     o.back().keep_attr_prefixes.push_back("keep_attr_prefixes2");
     o.back().keep_attr_prefixes.push_back("keep_attr_prefixes3");
@@ -566,7 +566,7 @@ struct rgw_cls_obj_store_pg_ver_op {
 
   static std::list<rgw_cls_obj_store_pg_ver_op> generate_test_instances() {
     std::list<rgw_cls_obj_store_pg_ver_op> o;
-    o.push_back(rgw_cls_obj_store_pg_ver_op{});
+    o.emplace_back();
     o.back().attr = "attr";
     return o;
   }
@@ -600,7 +600,7 @@ struct rgw_cls_obj_check_attrs_prefix {
 
   static std::list<rgw_cls_obj_check_attrs_prefix> generate_test_instances() {
     std::list<rgw_cls_obj_check_attrs_prefix> o;
-    o.push_back(rgw_cls_obj_check_attrs_prefix{});
+    o.emplace_back();
     o.back().check_prefix = "prefix";
     o.back().fail_if_exist = true;
     return o;
@@ -666,7 +666,7 @@ struct rgw_cls_usage_log_add_op {
 
   static std::list<rgw_cls_usage_log_add_op> generate_test_instances() {
     std::list<rgw_cls_usage_log_add_op> o;
-    o.push_back(rgw_cls_usage_log_add_op{});
+    o.emplace_back();
     return o;
   }
 };
@@ -701,8 +701,8 @@ struct rgw_cls_bi_get_op {
 
   static std::list<rgw_cls_bi_get_op> generate_test_instances() {
     std::list<rgw_cls_bi_get_op> o;
-    o.push_back(rgw_cls_bi_get_op{});
-    o.push_back(rgw_cls_bi_get_op{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().key.name = "key";
     o.back().key.instance = "instance";
     o.back().type = BIIndexType::Plain;
@@ -734,7 +734,7 @@ struct rgw_cls_bi_get_ret {
 
   static std::list<rgw_cls_bi_get_ret> generate_test_instances() {
     std::list<rgw_cls_bi_get_ret> o;
-    o.push_back(rgw_cls_bi_get_ret{});
+    o.emplace_back();
     o.back().entry.idx = "entry";
     return o;
   }
@@ -764,8 +764,8 @@ struct rgw_cls_bi_put_op {
 
   static std::list<rgw_cls_bi_put_op> generate_test_instances() {
     std::list<rgw_cls_bi_put_op> o;
-    o.push_back(rgw_cls_bi_put_op{});
-    o.push_back(rgw_cls_bi_put_op{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().entry.idx = "entry";
     return o;
   }
@@ -794,8 +794,8 @@ struct rgw_cls_bi_put_entries_op {
 
   static std::list<rgw_cls_bi_put_entries_op> generate_test_instances() {
     std::list<rgw_cls_bi_put_entries_op> o;
-    o.push_back(rgw_cls_bi_put_entries_op{});
-    o.push_back(rgw_cls_bi_put_entries_op{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().entries.push_back({.idx = "entry"});
     o.back().check_existing = true;
     return o;
@@ -840,8 +840,8 @@ struct rgw_cls_bi_list_op {
 
   static std::list<rgw_cls_bi_list_op> generate_test_instances() {
     std::list<rgw_cls_bi_list_op> o;
-    o.push_back(rgw_cls_bi_list_op{});
-    o.push_back(rgw_cls_bi_list_op{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().max = 100;
     o.back().name_filter = "name_filter";
     o.back().marker = "marker";
@@ -878,8 +878,8 @@ struct rgw_cls_bi_list_ret {
 
   static std::list<rgw_cls_bi_list_ret> generate_test_instances() {
     std::list<rgw_cls_bi_list_ret> o;
-    o.push_back(rgw_cls_bi_list_ret{});
-    o.push_back(rgw_cls_bi_list_ret{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().entries.push_back(rgw_cls_bi_entry());
     o.back().entries.push_back(rgw_cls_bi_entry());
     o.back().entries.back().idx = "entry";
@@ -933,7 +933,7 @@ struct rgw_cls_usage_log_read_op {
 
   static std::list<rgw_cls_usage_log_read_op> generate_test_instances() {
     std::list<rgw_cls_usage_log_read_op> o;
-    o.push_back(rgw_cls_usage_log_read_op{});
+    o.emplace_back();
     o.back().start_epoch = 1;
     o.back().end_epoch = 2;
     o.back().owner = "owner";
@@ -974,11 +974,11 @@ struct rgw_cls_usage_log_read_ret {
 
   static std::list<rgw_cls_usage_log_read_ret> generate_test_instances() {
     std::list<rgw_cls_usage_log_read_ret> o;
-    o.push_back(rgw_cls_usage_log_read_ret{});
+    o.emplace_back();
     o.back().next_iter = "123";
     o.back().truncated = true;
     o.back().usage.clear();
-    o.push_back(rgw_cls_usage_log_read_ret{});
+    o.emplace_back();
     o.back().usage[rgw_user_bucket("user1", "bucket1")] = rgw_usage_log_entry();
     o.back().usage[rgw_user_bucket("user2", "bucket2")] = rgw_usage_log_entry();
     o.back().truncated = true;
@@ -1400,8 +1400,8 @@ struct cls_rgw_lc_set_entry_op {
 
   static std::list<cls_rgw_lc_set_entry_op> generate_test_instances() {
     std::list<cls_rgw_lc_set_entry_op> ls;
-    ls.push_back(cls_rgw_lc_set_entry_op{});
-    ls.push_back(cls_rgw_lc_set_entry_op{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().entry.bucket = "foo";
     ls.back().entry.start_time = 123;
     ls.back().entry.status = 456;
index 8f665bc714fe55d6da4ff2db56e6e957a14dd518..b70bb8885be6aaaa0f339d3243a724e1bb920aab 100644 (file)
@@ -64,8 +64,8 @@ void rgw_zone_set::dump(Formatter *f) const
 list<rgw_zone_set> rgw_zone_set::generate_test_instances()
 {
   list<rgw_zone_set> o;
-  o.push_back(rgw_zone_set{});
-  o.push_back(rgw_zone_set{});
+  o.emplace_back();
+  o.emplace_back();
   std::optional<string> loc_key = "loc_key";
   o.back().insert("zone1", loc_key);
   o.back().insert("zone2", loc_key);
@@ -151,7 +151,7 @@ list<rgw_bucket_pending_info> rgw_bucket_pending_info::generate_test_instances()
   i.state = CLS_RGW_STATE_COMPLETE;
   i.op = CLS_RGW_OP_DEL;
   o.push_back(std::move(i));
-  o.push_back(rgw_bucket_pending_info{});
+  o.emplace_back();
   return o;
 }
 
@@ -189,7 +189,7 @@ list<rgw_bucket_dir_entry_meta> rgw_bucket_dir_entry_meta::generate_test_instanc
   m.owner_display_name = "display name";
   m.content_type = "content/type";
   o.push_back(std::move(m));
-  o.push_back(rgw_bucket_dir_entry_meta{});
+  o.emplace_back();
   return o;
 }
 
@@ -245,7 +245,7 @@ list<rgw_bucket_dir_entry> rgw_bucket_dir_entry::generate_test_instances()
 
     o.push_back(std::move(e));
   }
-  o.push_back(rgw_bucket_dir_entry{});
+  o.emplace_back();
   return o;
 }
 
@@ -263,8 +263,8 @@ void rgw_bucket_entry_ver::decode_json(JSONObj *obj) {
 list<rgw_bucket_entry_ver> rgw_bucket_entry_ver::generate_test_instances()
 {
   list<rgw_bucket_entry_ver> ls;
-  ls.push_back(rgw_bucket_entry_ver{});
-  ls.push_back(rgw_bucket_entry_ver{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().pool = 123;
   ls.back().epoch = 12322;
   return ls;
@@ -463,7 +463,7 @@ list<rgw_cls_bi_entry> rgw_cls_bi_entry::generate_test_instances()
   m.idx = "idx";
   encode(entry, m.data);
   o.push_back(std::move(m));
-  o.push_back(rgw_cls_bi_entry{});
+  o.emplace_back();
   return o;
 }
 
@@ -501,7 +501,7 @@ list<rgw_bucket_olh_entry> rgw_bucket_olh_entry::generate_test_instances()
   entry.exists = true;
   entry.pending_removal = true;
   o.push_back(std::move(entry));
-  o.push_back(rgw_bucket_olh_entry{});
+  o.emplace_back();
   return o;
 }
 
@@ -522,7 +522,7 @@ list<rgw_bucket_deleted_entry> rgw_bucket_deleted_entry::generate_test_instances
   entry.key.name = "key.name";
   entry.key.instance = "key.instance";
   o.push_back(std::move(entry));
-  o.push_back(rgw_bucket_deleted_entry{});
+  o.emplace_back();
   return o;
 }
 
@@ -537,7 +537,7 @@ list<rgw_bucket_olh_log_entry> rgw_bucket_olh_log_entry::generate_test_instances
   entry.key.instance = "key.instance";
   entry.delete_marker = true;
   o.push_back(std::move(entry));
-  o.push_back(rgw_bucket_olh_log_entry{});
+  o.emplace_back();
   return o;
 }
 
@@ -650,8 +650,8 @@ void rgw_bi_log_entry::dump(Formatter *f) const
 list<rgw_bi_log_entry> rgw_bi_log_entry::generate_test_instances()
 {
   list<rgw_bi_log_entry> ls;
-  ls.push_back(rgw_bi_log_entry{});
-  ls.push_back(rgw_bi_log_entry{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().id = "midf";
   ls.back().object = "obj";
   ls.back().timestamp = ceph::real_clock::from_ceph_timespec({ceph_le32(2), ceph_le32(3)});
@@ -671,7 +671,7 @@ list<rgw_bucket_category_stats> rgw_bucket_category_stats::generate_test_instanc
   s.num_entries = 2;
   s.actual_size = 1024;
   o.push_back(std::move(s));
-  o.push_back(rgw_bucket_category_stats{});
+  o.emplace_back();
   return o;
 }
 
@@ -699,7 +699,7 @@ list<rgw_bucket_dir_header> rgw_bucket_dir_header::generate_test_instances()
     o.push_back(std::move(h));
   }
 
-  o.push_back(rgw_bucket_dir_header{});
+  o.emplace_back();
   return o;
 }
 
@@ -742,7 +742,7 @@ list<rgw_bucket_dir> rgw_bucket_dir::generate_test_instances()
     o.push_back(std::move(d));
   }
 
-  o.push_back(rgw_bucket_dir{});
+  o.emplace_back();
   return o;
 }
 
@@ -769,7 +769,7 @@ list<rgw_s3select_usage_data> rgw_s3select_usage_data::generate_test_instances()
   s.bytes_processed = 1024;
   s.bytes_returned = 512;
   o.push_back(std::move(s));
-  o.push_back(rgw_s3select_usage_data{});
+  o.emplace_back();
   return o;
 }
 
@@ -788,7 +788,7 @@ list<rgw_usage_data> rgw_usage_data::generate_test_instances()
   s.ops = 2;
   s.successful_ops = 1;
   o.push_back(std::move(s));
-  o.push_back(rgw_usage_data{});
+  o.emplace_back();
   return o;
 }
 
@@ -811,7 +811,7 @@ list<rgw_usage_log_info> rgw_usage_log_info::generate_test_instances()
   rgw_usage_log_entry r(owner, payer, bucket);
   s.entries.push_back(r);
   o.push_back(std::move(s));
-  o.push_back(rgw_usage_log_info{});
+  o.emplace_back();
   return o;
 }
 
@@ -827,7 +827,7 @@ list<rgw_user_bucket> rgw_user_bucket::generate_test_instances()
   s.user = "user";
   s.bucket = "bucket";
   o.push_back(std::move(s));
-  o.push_back(rgw_user_bucket{});
+  o.emplace_back();
   return o;
 }
 
@@ -889,7 +889,7 @@ list<rgw_usage_log_entry> rgw_usage_log_entry::generate_test_instances()
   entry.usage_map["get_obj"] = usage_data;
   entry.s3select_usage = s3select_usage_data;
   o.push_back(std::move(entry));
-  o.push_back(rgw_usage_log_entry{});
+  o.emplace_back();
   return o;
 }
 
@@ -931,8 +931,8 @@ void cls_rgw_reshard_entry::dump(Formatter *f) const
 list<cls_rgw_reshard_entry> cls_rgw_reshard_entry::generate_test_instances()
 {
   list<cls_rgw_reshard_entry> ls;
-  ls.push_back(cls_rgw_reshard_entry{});
-  ls.push_back(cls_rgw_reshard_entry{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().time = ceph::real_clock::from_ceph_timespec({ceph_le32(2), ceph_le32(3)});
   ls.back().tenant = "tenant";
   ls.back().bucket_name = "bucket1""";
@@ -950,8 +950,8 @@ void cls_rgw_bucket_instance_entry::dump(Formatter *f) const
 list<cls_rgw_bucket_instance_entry> cls_rgw_bucket_instance_entry::generate_test_instances()
 {
   list<cls_rgw_bucket_instance_entry> ls;
-  ls.push_back(cls_rgw_bucket_instance_entry{});
-  ls.push_back(cls_rgw_bucket_instance_entry{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().reshard_status = RESHARD_STATUS::IN_PROGRESS;
   return ls;
 }
@@ -971,7 +971,7 @@ list<cls_rgw_lc_entry> cls_rgw_lc_entry::generate_test_instances()
   s.start_time = 10;
   s.status = 1;
   o.push_back(std::move(s));
-  o.push_back(cls_rgw_lc_entry{});
+  o.emplace_back();
   return o;
 }
 
index 8dbdae7aa9117978f6e648caaa2eca84c9aa0d9d..486ac5e0186218eff8fb84e60482c7947474c68a 100644 (file)
@@ -1179,8 +1179,8 @@ struct cls_rgw_obj {
   }
   static std::list<cls_rgw_obj> generate_test_instances() {
     std::list<cls_rgw_obj> ls;
-    ls.push_back(cls_rgw_obj{});
-    ls.push_back(cls_rgw_obj{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().pool = "mypool";
     ls.back().key.name = "myoid";
     ls.back().loc = "mykey";
@@ -1233,7 +1233,7 @@ struct cls_rgw_obj_chain {
   }
   static std::list<cls_rgw_obj_chain> generate_test_instances() {
     std::list<cls_rgw_obj_chain> ls;
-    ls.push_back(cls_rgw_obj_chain{});
+    ls.emplace_back();
     return ls;
   }
 
@@ -1286,8 +1286,8 @@ struct cls_rgw_gc_obj_info
   }
   static std::list<cls_rgw_gc_obj_info> generate_test_instances() {
     std::list<cls_rgw_gc_obj_info> ls;
-    ls.push_back(cls_rgw_gc_obj_info{});
-    ls.push_back(cls_rgw_gc_obj_info{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().tag = "footag";
     ceph_timespec ts{ceph_le32(21), ceph_le32(32)};
     ls.back().time = ceph::real_clock::from_ceph_timespec(ts);
index 3c741a0e2c669304f8438756c2314e5cd71a9742..321f4f72e38ddbbd57cab4647aa9ef9fb37e6392 100644 (file)
@@ -32,7 +32,7 @@ struct cls_rgw_gc_queue_init_op {
 
   static std::list<cls_rgw_gc_queue_init_op> generate_test_instances() {
     std::list<cls_rgw_gc_queue_init_op> o;
-    o.push_back(cls_rgw_gc_queue_init_op{});
+    o.emplace_back();
     o.back().size = 1024;
     o.back().num_deferred_entries = 512;
     return o;
index 672563c858ab1b64bf7ebea134c105c4db17be8c..93502336a28c1b428be40b65b0cc7e7c2f272fae 100644 (file)
@@ -42,8 +42,8 @@ struct cls_rgw_gc_urgent_data
   }
   static std::list<cls_rgw_gc_urgent_data> generate_test_instances() {
     std::list<cls_rgw_gc_urgent_data> o;
-    o.push_back(cls_rgw_gc_urgent_data{});
-    o.push_back(cls_rgw_gc_urgent_data{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().num_urgent_data_entries = 1024;
     o.back().num_head_urgent_entries = 512;
     o.back().num_xattr_urgent_entries = 512;
index dea9859413e4c3d4b62d1b15c206f9a9b415ac75..0a2883ab29cec741966204208800afa31298f856 100644 (file)
@@ -66,8 +66,8 @@ struct cls_timeindex_list_op {
 
   static std::list<cls_timeindex_list_op> generate_test_instances() {
     std::list<cls_timeindex_list_op> o;
-    o.push_back(cls_timeindex_list_op{});
-    o.push_back(cls_timeindex_list_op{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().from_time = utime_t(1, 2);
     o.back().marker = "marker";
     o.back().to_time = utime_t(3, 4);
@@ -108,8 +108,8 @@ struct cls_timeindex_list_ret {
 
   static std::list<cls_timeindex_list_ret> generate_test_instances() {
     std::list<cls_timeindex_list_ret> o;
-    o.push_back(cls_timeindex_list_ret{});
-    o.push_back(cls_timeindex_list_ret{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().entries.push_back(cls_timeindex_entry());
     o.back().entries.back().key_ts = utime_t(1, 2);
     o.back().entries.back().key_ext = "key_ext";
index c9d0c058bac28b76bcb2ec18ae92dbae16d2f2c1..4becaf47253be872f9023249fe9ffccebeb5e04f 100644 (file)
@@ -18,6 +18,6 @@ std::list<cls_timeindex_entry> cls_timeindex_entry::generate_test_instances()
   bl.append("bar");
   i.value = bl;
   o.push_back(std::move(i));
-  o.push_back(cls_timeindex_entry{});
+  o.emplace_back();
   return o;
 }
index c0de485768e06c00993125bc880ba09da0b46406..12621339398d804118033a78fbce086abfab556d 100644 (file)
@@ -19,7 +19,7 @@ void cls_user_set_buckets_op::dump(Formatter *f) const
 list<cls_user_set_buckets_op> cls_user_set_buckets_op::generate_test_instances()
 {
   list<cls_user_set_buckets_op> ls;
-  ls.push_back(cls_user_set_buckets_op{});
+  ls.emplace_back();
   cls_user_set_buckets_op op;
   for (int i = 0; i < 3; i++) {
     cls_user_bucket_entry e;
@@ -40,7 +40,7 @@ void cls_user_remove_bucket_op::dump(Formatter *f) const
 list<cls_user_remove_bucket_op> cls_user_remove_bucket_op::generate_test_instances()
 {
   list<cls_user_remove_bucket_op> ls;
-  ls.push_back(cls_user_remove_bucket_op{});
+  ls.emplace_back();
   cls_user_remove_bucket_op op;
   cls_user_gen_test_bucket(&op.bucket, 0);
   ls.push_back(std::move(op));
@@ -56,7 +56,7 @@ void cls_user_list_buckets_op::dump(Formatter *f) const
 list<cls_user_list_buckets_op> cls_user_list_buckets_op::generate_test_instances()
 {
   list<cls_user_list_buckets_op> ls;
-  ls.push_back(cls_user_list_buckets_op{});
+  ls.emplace_back();
   cls_user_list_buckets_op op;;
   op.marker = "marker";
   op.max_entries = 1000;
@@ -74,7 +74,7 @@ void cls_user_list_buckets_ret::dump(Formatter *f) const
 list<cls_user_list_buckets_ret> cls_user_list_buckets_ret::generate_test_instances()
 {
   list<cls_user_list_buckets_ret> ls;
-  ls.push_back(cls_user_list_buckets_ret{});
+  ls.emplace_back();
   cls_user_list_buckets_ret ret;;
   for (int i = 0; i < 3; i++) {
     cls_user_bucket_entry e;
@@ -95,7 +95,7 @@ void cls_user_get_header_op::dump(Formatter *f) const
 list<cls_user_get_header_op> cls_user_get_header_op::generate_test_instances()
 {
   list<cls_user_get_header_op> ls;
-  ls.push_back(cls_user_get_header_op{});
+  ls.emplace_back();
   return ls;
 }
 
@@ -107,7 +107,7 @@ void cls_user_get_header_ret::dump(Formatter *f) const
 list<cls_user_get_header_ret> cls_user_get_header_ret::generate_test_instances()
 {
   list<cls_user_get_header_ret> ls;
-  ls.push_back(cls_user_get_header_ret{});
+  ls.emplace_back();
   cls_user_get_header_ret ret;
   cls_user_gen_test_header(&ret.header);
   ls.push_back(std::move(ret));
@@ -122,7 +122,7 @@ void cls_user_complete_stats_sync_op::dump(Formatter *f) const
 list<cls_user_complete_stats_sync_op> cls_user_complete_stats_sync_op::generate_test_instances()
 {
   list<cls_user_complete_stats_sync_op> ls;
-  ls.push_back(cls_user_complete_stats_sync_op{});
+  ls.emplace_back();
   cls_user_complete_stats_sync_op op;
   op.time = utime_t(12345, 0).to_real_time();
   ls.push_back(std::move(op));
@@ -140,7 +140,7 @@ void cls_user_account_resource_add_op::dump(Formatter *f) const
 std::list<cls_user_account_resource_add_op> cls_user_account_resource_add_op::generate_test_instances()
 {
   std::list<cls_user_account_resource_add_op> ls;
-  ls.push_back(cls_user_account_resource_add_op{});
+  ls.emplace_back();
   cls_user_account_resource_add_op op;
   cls_user_gen_test_resource(op.entry);
   ls.push_back(std::move(op));
@@ -155,7 +155,7 @@ void cls_user_account_resource_get_op::dump(Formatter *f) const
 std::list<cls_user_account_resource_get_op> cls_user_account_resource_get_op::generate_test_instances()
 {
   std::list<cls_user_account_resource_get_op> ls;
-  ls.push_back(cls_user_account_resource_get_op{});
+  ls.emplace_back();
   cls_user_account_resource_get_op op;
   op.name = "name";
   ls.push_back(std::move(op));
@@ -170,7 +170,7 @@ void cls_user_account_resource_get_ret::dump(Formatter *f) const
 std::list<cls_user_account_resource_get_ret> cls_user_account_resource_get_ret::generate_test_instances()
 {
   std::list<cls_user_account_resource_get_ret> ls;
-  ls.push_back(cls_user_account_resource_get_ret{});
+  ls.emplace_back();
   cls_user_account_resource_get_ret ret;
   cls_user_gen_test_resource(ret.entry);
   ls.push_back(std::move(ret));
@@ -185,7 +185,7 @@ void cls_user_account_resource_rm_op::dump(Formatter *f) const
 std::list<cls_user_account_resource_rm_op> cls_user_account_resource_rm_op::generate_test_instances()
 {
   std::list<cls_user_account_resource_rm_op> ls;
-  ls.push_back(cls_user_account_resource_rm_op{});
+  ls.emplace_back();
   cls_user_account_resource_rm_op op;
   op.name = "name";
   ls.push_back(std::move(op));
@@ -202,7 +202,7 @@ void cls_user_account_resource_list_op::dump(Formatter *f) const
 std::list<cls_user_account_resource_list_op> cls_user_account_resource_list_op::generate_test_instances()
 {
   std::list<cls_user_account_resource_list_op> ls;
-  ls.push_back(cls_user_account_resource_list_op{});
+  ls.emplace_back();
   cls_user_account_resource_list_op op;
   op.marker = "marker";
   op.path_prefix = "path";
@@ -221,7 +221,7 @@ void cls_user_account_resource_list_ret::dump(Formatter *f) const
 std::list<cls_user_account_resource_list_ret> cls_user_account_resource_list_ret::generate_test_instances()
 {
   std::list<cls_user_account_resource_list_ret> ls;
-  ls.push_back(cls_user_account_resource_list_ret{});
+  ls.emplace_back();
   cls_user_account_resource_list_ret ret;
   cls_user_gen_test_resource(ret.entries.emplace_back());
   ret.truncated = true;
index d26a059163ccf72f0ddb4552a8dea01b37f163ab..27c3abe9bb67dd689615da6ebcaaca4e79a173da 100644 (file)
@@ -33,7 +33,7 @@ void cls_user_bucket::dump(Formatter *f) const
 list<cls_user_bucket> cls_user_bucket::generate_test_instances()
 {
   list<cls_user_bucket> ls;
-  ls.push_back(cls_user_bucket{});
+  ls.emplace_back();
   cls_user_bucket b;
   cls_user_gen_test_bucket(&b, 0);
   ls.push_back(std::move(b));
@@ -63,7 +63,7 @@ void cls_user_gen_test_bucket_entry(cls_user_bucket_entry *entry, int i)
 list<cls_user_bucket_entry> cls_user_bucket_entry::generate_test_instances()
 {
   list<cls_user_bucket_entry> ls;
-  ls.push_back(cls_user_bucket_entry{});
+  ls.emplace_back();
   cls_user_bucket_entry entry;
   cls_user_gen_test_bucket_entry(&entry, 0);
   ls.push_back(std::move(entry));
@@ -87,7 +87,7 @@ void cls_user_stats::dump(Formatter *f) const
 list<cls_user_stats> cls_user_stats::generate_test_instances()
 {
   list<cls_user_stats> ls;
-  ls.push_back(cls_user_stats{});
+  ls.emplace_back();
   cls_user_stats s;
   cls_user_gen_test_stats(&s);
   ls.push_back(std::move(s));
@@ -111,7 +111,7 @@ void cls_user_header::dump(Formatter *f) const
 list<cls_user_header> cls_user_header::generate_test_instances()
 {
   list<cls_user_header> ls;
-  ls.push_back(cls_user_header{});
+  ls.emplace_back();
   cls_user_header h;
   cls_user_gen_test_header(&h);
   ls.push_back(std::move(h));
@@ -127,7 +127,7 @@ void cls_user_account_header::dump(ceph::Formatter* f) const
 std::list<cls_user_account_header> cls_user_account_header::generate_test_instances()
 {
   std::list<cls_user_account_header> ls;
-  ls.push_back(cls_user_account_header{});
+  ls.emplace_back();
   return ls;
 }
 
@@ -147,7 +147,7 @@ void cls_user_gen_test_resource(cls_user_account_resource& r)
 std::list<cls_user_account_resource> cls_user_account_resource::generate_test_instances()
 {
   std::list<cls_user_account_resource> ls;
-  ls.push_back(cls_user_account_resource{});
+  ls.emplace_back();
   cls_user_account_resource p;
   cls_user_gen_test_resource(p);
   ls.push_back(std::move(p));
index 74447753f136d116bb45c185dac03094d4ad4358..2e96ebc07606e332183b0a7ae9573dbca130f55b 100644 (file)
@@ -30,8 +30,8 @@ struct cls_version_set_op {
 
   static std::list<cls_version_set_op> generate_test_instances() {
     std::list<cls_version_set_op> o;
-    o.push_back(cls_version_set_op{});
-    o.push_back(cls_version_set_op{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().objv.ver = 123;
     o.back().objv.tag = "foo";
     return o;
@@ -66,8 +66,8 @@ struct cls_version_inc_op {
 
   static std::list<cls_version_inc_op> generate_test_instances() {
     std::list<cls_version_inc_op> o;
-    o.push_back(cls_version_inc_op{});
-    o.push_back(cls_version_inc_op{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().objv.ver = 123;
     o.back().objv.tag = "foo";
     o.back().conds.push_back(obj_version_cond());
@@ -106,8 +106,8 @@ struct cls_version_check_op {
 
   static std::list<cls_version_check_op> generate_test_instances() {
     std::list<cls_version_check_op> o;
-    o.push_back(cls_version_check_op{});
-    o.push_back(cls_version_check_op{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().objv.ver = 123;
     o.back().objv.tag = "foo";
     o.back().conds.push_back(obj_version_cond());
@@ -142,8 +142,8 @@ struct cls_version_read_ret {
 
   static std::list<cls_version_read_ret> generate_test_instances() {
     std::list<cls_version_read_ret> o;
-    o.push_back(cls_version_read_ret{});
-    o.push_back(cls_version_read_ret{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().objv.ver = 123;
     o.back().objv.tag = "foo";
     return o;
index faf083388623cbecac9342f7408077de33ba0d99..6b6ccfb1516b5b178342dc4cc310af832c1ac030 100644 (file)
@@ -114,8 +114,8 @@ struct obj_version_cond {
 
   static std::list<obj_version_cond> generate_test_instances() {
     std::list<obj_version_cond> o;
-    o.push_back(obj_version_cond{});
-    o.push_back(obj_version_cond{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().ver.ver = 1;
     o.back().ver.tag = "foo";
     o.back().cond = VER_COND_EQ;
index 77145d8f2ebff9c971f21a8ce7b490a1c2dbe964..e00a2975f4ebd5f82dd555987258066bbba3a947 100644 (file)
@@ -83,8 +83,8 @@ void CompatSet::dump(ceph::Formatter *f) const {
 
 std::list<CompatSet> CompatSet::generate_test_instances() {
   std::list<CompatSet> o;
-  o.push_back(CompatSet{});
-  o.push_back(CompatSet{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().compat.insert(Feature(1, "one"));
   o.back().compat.insert(Feature(2, "two"));
   o.back().ro_compat.insert(Feature(4, "four"));
index 4ebc64f70854d8e19ba32824f4daa0548ca2e08f..a76307c41067bcc484005c1e47253c462037f5d5 100644 (file)
@@ -32,7 +32,7 @@ void LogEntryKey::dump(Formatter *f) const
 list<LogEntryKey> LogEntryKey::generate_test_instances()
 {
   list<LogEntryKey> o;
-  o.push_back(LogEntryKey{});
+  o.emplace_back();
   o.push_back(LogEntryKey(entity_name_t::CLIENT(1234), utime_t(1,2), 34));
   return o;
 }
@@ -274,7 +274,7 @@ void LogEntry::dump(Formatter *f) const
 list<LogEntry> LogEntry::generate_test_instances()
 {
   list<LogEntry> o;
-  o.push_back(LogEntry{});
+  o.emplace_back();
   return o;
 }
 
@@ -359,7 +359,7 @@ void LogSummary::dump(Formatter *f) const
 list<LogSummary> LogSummary::generate_test_instances()
 {
   list<LogSummary> o;
-  o.push_back(LogSummary{});
+  o.emplace_back();
   // more!
   return o;
 }
index 6c60c63953dd2fb2a07e597615ad130cadaeb501..bfa49c04df833d48f0d1dc88a0a835db5e7f46ab 100644 (file)
@@ -174,7 +174,7 @@ void SloppyCRCMap::dump(ceph::Formatter *f) const
 list<SloppyCRCMap> SloppyCRCMap::generate_test_instances()
 {
   list<SloppyCRCMap> ls;
-  ls.push_back(SloppyCRCMap{});
+  ls.emplace_back();
   ls.push_back(SloppyCRCMap(2));
   bufferlist bl;
   bl.append("some data");
index 7f864a8beca1ec96aa68a25e1081d8b29ffe1289..e6df71c86f44bb3b4977b8d54aa0b526a126df84 100644 (file)
@@ -619,7 +619,7 @@ template <uint8_t _b>
 auto BitVector<_b>::generate_test_instances() -> std::list<BitVector> {
   std::list<BitVector> o;
 
-  o.push_back(BitVector{});
+  o.emplace_back();
 
   BitVector b;
   const uint64_t radix = 1 << b.BIT_COUNT;
index 22e729bcd433d7f1a518823e3d9e7c3c3bfe86e6..ae64ff3431270bda539eb9facaca3ec3ee53be68 100644 (file)
@@ -858,16 +858,16 @@ public:
   }
   static std::list<JSONFormattable> generate_test_instances() {
     std::list<JSONFormattable> o;
-    o.push_back(JSONFormattable{});
-    o.push_back(JSONFormattable{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().set_type(FMT_VALUE);
     o.back().value.str = "foo";
     o.back().value.quoted = true;
-    o.push_back(JSONFormattable{});
+    o.emplace_back();
     o.back().set_type(FMT_VALUE);
     o.back().value.str = "foo";
     o.back().value.quoted = false;
-    o.push_back(JSONFormattable{});
+    o.emplace_back();
     o.back().set_type(FMT_ARRAY);
     o.back().arr.push_back(JSONFormattable());
     o.back().arr.back().set_type(FMT_VALUE);
@@ -877,7 +877,7 @@ public:
     o.back().arr.back().set_type(FMT_VALUE);
     o.back().arr.back().value.str = "bar";
     o.back().arr.back().value.quoted = true;
-    o.push_back(JSONFormattable{});
+    o.emplace_back();
     o.back().set_type(FMT_OBJ);
     o.back().obj["foo"] = JSONFormattable();
     o.back().obj["foo"].set_type(FMT_VALUE);
index 6d07652167c075f98ba84345a23218a47b61fc9d..4cfb694c4c6dec9e94e129e1e9458c1b82861427 100644 (file)
@@ -52,11 +52,11 @@ void EntityName::dump(ceph::Formatter *f) const {
 
 std::list<EntityName> EntityName::generate_test_instances() {
   std::list<EntityName> ls;
-  ls.push_back(EntityName{});
-  ls.push_back(EntityName{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().set_type(CEPH_ENTITY_TYPE_OSD);
   ls.back().set_id("0");
-  ls.push_back(EntityName{});
+  ls.emplace_back();
   ls.back().set_type(CEPH_ENTITY_TYPE_MDS);
   ls.back().set_id("a");
   return ls;
index 071a8cd43b60bf017ce100172d48df7a6b6d1c7e..f67c5a131547b85d64f9c9b178c5c32e798c5b75 100644 (file)
@@ -47,7 +47,7 @@ void frag_t::dump(ceph::Formatter *f) const {
 
 std::list<frag_t> frag_t::generate_test_instances() {
   std::list<frag_t> ls;
-  ls.push_back(frag_t{});
+  ls.emplace_back();
   ls.push_back(frag_t(10, 2));
   ls.push_back(frag_t(11, 3));
   return ls;
@@ -189,8 +189,8 @@ void fragtree_t::dump(ceph::Formatter *f) const {
 
 std::list<fragtree_t> fragtree_t::generate_test_instances() {
   std::list<fragtree_t> ls;
-  ls.push_back(fragtree_t{});
-  ls.push_back(fragtree_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   return ls;
 }
 
index a0db94d27bf1c709139990d24bcf810f80f9986b..fd6d07ad49642bb4874cb95b9bc6b20dedd96ea0 100644 (file)
@@ -146,8 +146,8 @@ void file_layout_t::decode_json(JSONObj *obj){
 std::list<file_layout_t> file_layout_t::generate_test_instances()
 {
   std::list<file_layout_t> o;
-  o.push_back(file_layout_t{});
-  o.push_back(file_layout_t{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().stripe_unit = 4096;
   o.back().stripe_count = 16;
   o.back().object_size = 1048576;
index fbc04cecd65313c0391e8d39757203d766593dd0..8a33b7d775dd5cb843432ec3b8f8da97a28ccb93 100644 (file)
@@ -42,8 +42,8 @@ void pow2_hist_t::decode(ceph::buffer::list::const_iterator& p)
 std::list<pow2_hist_t> pow2_hist_t::generate_test_instances()
 {
   std::list<pow2_hist_t> ls;
-  ls.push_back(pow2_hist_t{});
-  ls.push_back(pow2_hist_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().h.push_back(1);
   ls.back().h.push_back(3);
   ls.back().h.push_back(0);
index c6156ea768afd1c568a0a54390b4ce0a07b38dac..502818e7c0918aa2ed7311579cc91d186f7b1c0c 100644 (file)
@@ -197,8 +197,8 @@ void hobject_t::dump(Formatter *f) const
 list<hobject_t> hobject_t::generate_test_instances()
 {
   list<hobject_t> o;
-  o.push_back(hobject_t{});
-  o.push_back(hobject_t{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().max = true;
   o.push_back(hobject_t(object_t("oname"), string(), 1, 234, -1, ""));
   o.push_back(hobject_t(object_t("oname2"), string("okey"), CEPH_NOSNAP,
@@ -500,8 +500,8 @@ void ghobject_t::dump(Formatter *f) const
 list<ghobject_t> ghobject_t::generate_test_instances()
 {
   list<ghobject_t> o;
-  o.push_back(ghobject_t{});
-  o.push_back(ghobject_t{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().hobj.max = true;
   o.push_back(ghobject_t(hobject_t(object_t("oname"), string(), 1, 234, -1, "")));
 
index 078a2c6716d109f7638d883835539aded553b352..ad0313bde706fb7530c3e7f525b4af459a88c05e 100644 (file)
@@ -45,7 +45,7 @@ void SnapRealmInfo::dump(ceph::Formatter *f) const
 std::list<SnapRealmInfo> SnapRealmInfo::generate_test_instances()
 {
   std::list<SnapRealmInfo> o;
-  o.push_back(SnapRealmInfo{});
+  o.emplace_back();
   o.push_back(SnapRealmInfo(1, 10, 10, 0));
   o.push_back(SnapRealmInfo(1, 10, 10, 0));
   o.back().my_snaps.push_back(10);
@@ -88,7 +88,7 @@ void SnapRealmInfoNew::dump(ceph::Formatter *f) const
 std::list<SnapRealmInfoNew> SnapRealmInfoNew::generate_test_instances()
 {
   std::list<SnapRealmInfoNew> o;
-  o.push_back(SnapRealmInfoNew{});
+  o.emplace_back();
   o.push_back(SnapRealmInfoNew(SnapRealmInfo(1, 10, 10, 0), utime_t(), 0));
   o.push_back(SnapRealmInfoNew(SnapRealmInfo(1, 10, 10, 0), utime_t(), 1));
   o.back().info.my_snaps.push_back(10);
@@ -145,7 +145,7 @@ void SnapContext::dump(ceph::Formatter *f) const
 std::list<SnapContext> SnapContext::generate_test_instances()
 {
   std::list<SnapContext> o;
-  o.push_back(SnapContext{});
+  o.emplace_back();
   std::vector<snapid_t> v;
   o.push_back(SnapContext(10, v));
   v.push_back(18);
index 913129625d9ec75620108e2df014c9813c2f1b34..61fdffa30edd20f8cc04f62b7d03b3b94ceabf92 100644 (file)
@@ -214,7 +214,7 @@ struct vinodeno_t {
   void dump(ceph::Formatter *f) const;
   static std::list<vinodeno_t> generate_test_instances() {
     std::list<vinodeno_t> ls;
-    ls.push_back(vinodeno_t{});
+    ls.emplace_back();
     ls.push_back(vinodeno_t(1, 2));
     return ls;
   }
@@ -1134,8 +1134,8 @@ template<template<typename> class Allocator>
 auto inode_t<Allocator>::generate_test_instances() -> std::list<inode_t>
 {
   std::list<inode_t> ls;
-  ls.push_back(inode_t<Allocator>{});
-  ls.push_back(inode_t<Allocator>{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().ino = 1;
   // i am lazy.
   return ls;
index 243bf127d0bbc3112fd03f670e0e8a24b7146a6b..3844945ea47579eeaf3edd06bf49bd53fff305b1 100644 (file)
@@ -118,7 +118,7 @@ void filepath::dump(ceph::Formatter *f) const {
 
 std::list<filepath> filepath::generate_test_instances() {
   std::list<filepath> o;
-  o.push_back(filepath{});
+  o.emplace_back();
   o.push_back(filepath("/usr/bin", 0));
   o.push_back(filepath("/usr/sbin", 1));
   o.push_back(filepath("var/log", 1));
index ec7e879c484aa16c413fc7da0dfa9ea41d762618..5265cb75dc0ecc3fd444cadccbedd58a5151b695 100644 (file)
@@ -33,7 +33,7 @@ void object_t::dump(ceph::Formatter *f) const {
 
 std::list<object_t> object_t::generate_test_instances() {
   std::list<object_t> o;
-  o.push_back(object_t{});
+  o.emplace_back();
   o.push_back(object_t{"myobject"});
   return o;
 }
@@ -64,7 +64,7 @@ void sobject_t::dump(ceph::Formatter *f) const {
 
 std::list<sobject_t> sobject_t::generate_test_instances() {
   std::list<sobject_t> o;
-  o.push_back(sobject_t{});
+  o.emplace_back();
   o.push_back(sobject_t{object_t("myobject"), 123});
   return o;
 }
index 79a305292c30744b4179145519ecfdca80209689..ead9a1e8331f48a16269ec7101f5c08debdec49c 100644 (file)
@@ -54,7 +54,7 @@ void client_t::dump(ceph::Formatter *f) const {
 
 std::list<client_t> client_t::generate_test_instances() {
   std::list<client_t> ls;
-  ls.push_back(client_t{});
+  ls.emplace_back();
   ls.push_back(client_t(1));
   ls.push_back(client_t(123));
   return ls;
index 7ab2195100a3c7ee80b072a3560035d305170e83..68e2d5f5a7f6489c543056ae612074cd68e80839 100644 (file)
@@ -610,10 +610,10 @@ struct sha_digest_t {
   }
   static std::list<sha_digest_t> generate_test_instances() {
     std::list<sha_digest_t> ls;
-    ls.push_back(sha_digest_t{});
-    ls.push_back(sha_digest_t{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().v[0] = 1;
-    ls.push_back(sha_digest_t{});
+    ls.emplace_back();
     ls.back().v[0] = 2;
     return ls;
   }
index e250ac5a34a4fb69b0f7eaefd549394134bc0e2f..f7f2f7ee926c1a2d00c02fefeda9fad808704c7b 100644 (file)
@@ -65,8 +65,8 @@ struct ceph_data_stats
 
   static std::list<ceph_data_stats> generate_test_instances() {
     std::list<ceph_data_stats> ls;
-    ls.push_back(ceph_data_stats{});
-    ls.push_back(ceph_data_stats{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().byte_total = 1024*1024;
     ls.back().byte_used = 512*1024;
     ls.back().byte_avail = 512*1024;
index b0deda5623bbffb49fc81046da3f52ae3626916d..eb4b420aca6f0d4dd11eeb9a05b5543accd1fb51 100644 (file)
@@ -53,8 +53,8 @@ void Anchor::dump(Formatter *f) const
 std::list<Anchor> Anchor::generate_test_instances()
 {
   std::list<Anchor> ls;
-  ls.push_back(Anchor{});
-  ls.push_back(Anchor{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().ino = 1;
   ls.back().dirino = 2;
   ls.back().d_name = "hello";
index 8e435f96ab9204b765da36c00b50592e12cc481f..4e1cf6e5ba3c5b37e5db10687002a261c07c949e 100644 (file)
@@ -145,8 +145,8 @@ void Capability::revoke_info::dump(ceph::Formatter *f) const
 std::list<Capability::revoke_info> Capability::revoke_info::generate_test_instances()
 {
   std::list<Capability::revoke_info> ls;
-  ls.push_back(revoke_info{});
-  ls.push_back(revoke_info{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().before = 1;
   ls.back().seq = 2;
   ls.back().last_issue = 3;
index 59ea974900d60dd3cb2eca8c2c22072d605078a7..46299fe4af89650e2c342182673738a24a770cab 100644 (file)
@@ -43,8 +43,8 @@ void inode_backpointer_t::dump(ceph::Formatter *f) const
 std::list<inode_backpointer_t> inode_backpointer_t::generate_test_instances()
 {
   std::list<inode_backpointer_t> ls;
-  ls.push_back(inode_backpointer_t{});
-  ls.push_back(inode_backpointer_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().dirino = 1;
   ls.back().dname = "foo";
   ls.back().version = 123;
@@ -110,8 +110,8 @@ void inode_backtrace_t::dump(ceph::Formatter *f) const
 std::list<inode_backtrace_t> inode_backtrace_t::generate_test_instances()
 {
   std::list<inode_backtrace_t> ls;
-  ls.push_back(inode_backtrace_t{});
-  ls.push_back(inode_backtrace_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().ino = 1;
   ls.back().ancestors.push_back(inode_backpointer_t());
   ls.back().ancestors.back().dirino = 123;
index 21095afcc3d5436844ed97750f9aafe779c8724c..a7bc03e48fc5f3a7ebf540b11b84699ef2a7c0c7 100644 (file)
@@ -87,8 +87,8 @@ void frag_info_t::decode_json(JSONObj *obj){
 std::list<frag_info_t> frag_info_t::generate_test_instances()
 {
   std::list<frag_info_t> ls;
-  ls.push_back(frag_info_t{});
-  ls.push_back(frag_info_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().version = 1;
   ls.back().mtime = utime_t(2, 3);
   ls.back().nfiles = 4;
@@ -170,8 +170,8 @@ void nest_info_t::decode_json(JSONObj *obj){
 std::list<nest_info_t> nest_info_t::generate_test_instances()
 {
   std::list<nest_info_t> ls;
-  ls.push_back(nest_info_t{});
-  ls.push_back(nest_info_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().version = 1;
   ls.back().rbytes = 2;
   ls.back().rfiles = 3;
@@ -216,8 +216,8 @@ void  quota_info_t::decode_json(JSONObj *obj){
 std::list<quota_info_t> quota_info_t::generate_test_instances()
 {
   std::list<quota_info_t> ls;
-  ls.push_back(quota_info_t{});
-  ls.push_back(quota_info_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().max_bytes = 16;
   ls.back().max_files = 16;
   return ls;
@@ -272,8 +272,8 @@ void client_writeable_range_t::byte_range_t::decode_json(JSONObj *obj){
 std::list<client_writeable_range_t> client_writeable_range_t::generate_test_instances()
 {
   std::list<client_writeable_range_t> ls;
-  ls.push_back(client_writeable_range_t{});
-  ls.push_back(client_writeable_range_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().range.first = 123;
   ls.back().range.last = 456;
   ls.back().follows = 12;
@@ -320,8 +320,8 @@ void inline_data_t::dump(Formatter *f) const
 std::list<inline_data_t> inline_data_t::generate_test_instances()
 {
   std::list<inline_data_t> ls;
-  ls.push_back(inline_data_t{});
-  ls.push_back(inline_data_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   bufferlist bl;
   bl.append("inline data");
   ls.back().set_data(bl);
@@ -404,8 +404,8 @@ void fnode_t::decode_json(JSONObj *obj){
 std::list<fnode_t> fnode_t::generate_test_instances()
 {
   std::list<fnode_t> ls;
-  ls.push_back(fnode_t{});
-  ls.push_back(fnode_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().version = 1;
   ls.back().snap_purged_thru = 2;
   list<frag_info_t> fls = frag_info_t::generate_test_instances();
@@ -742,8 +742,8 @@ void session_info_t::dump(Formatter *f) const
 std::list<session_info_t> session_info_t::generate_test_instances()
 {
   std::list<session_info_t>ls;
-  ls.push_back(session_info_t{});
-  ls.push_back(session_info_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().inst = entity_inst_t(entity_name_t::MDS(12), entity_addr_t());
   ls.back().completed_requests.insert(make_pair(234, inodeno_t(111222)));
   ls.back().completed_requests.insert(make_pair(237, inodeno_t(222333)));
@@ -805,11 +805,11 @@ void string_snap_t::dump(Formatter *f) const
 std::list<string_snap_t> string_snap_t::generate_test_instances()
 {
   std::list<string_snap_t> ls;
-  ls.push_back(string_snap_t{});
-  ls.push_back(string_snap_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().name = "foo";
   ls.back().snapid = 123;
-  ls.push_back(string_snap_t{});
+  ls.emplace_back();
   ls.back().name = "bar";
   ls.back().snapid = 456;
   return ls;
@@ -861,13 +861,13 @@ void MDSCacheObjectInfo::print(std::ostream& out) const {
 std::list<MDSCacheObjectInfo> MDSCacheObjectInfo::generate_test_instances()
 {
   std::list<MDSCacheObjectInfo> ls;
-  ls.push_back(MDSCacheObjectInfo{});
-  ls.push_back(MDSCacheObjectInfo{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().ino = 1;
   ls.back().dirfrag = dirfrag_t(2, 3);
   ls.back().dname = "fooname";
   ls.back().snapid = CEPH_NOSNAP;
-  ls.push_back(MDSCacheObjectInfo{});
+  ls.emplace_back();
   ls.back().ino = 121;
   ls.back().dirfrag = dirfrag_t(222, 0);
   ls.back().dname = "bar foo";
@@ -906,8 +906,8 @@ void mds_table_pending_t::dump(Formatter *f) const
 std::list<mds_table_pending_t> mds_table_pending_t::generate_test_instances()
 {
   std::list<mds_table_pending_t> ls;
-  ls.push_back(mds_table_pending_t{});
-  ls.push_back(mds_table_pending_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().reqid = 234;
   ls.back().mds = 2;
   ls.back().tid = 35434;
@@ -925,7 +925,7 @@ void metareqid_t::print(std::ostream& out) const {
 
 std::list<metareqid_t> metareqid_t::generate_test_instances() {
   std::list<metareqid_t> ls;
-  ls.push_back(metareqid_t{});
+  ls.emplace_back();
   ls.push_back(metareqid_t(entity_name_t::CLIENT(123), 456));
   return ls;
 }
@@ -947,7 +947,7 @@ void dirfrag_t::dump(ceph::Formatter *f) const {
 
 std::list<dirfrag_t> dirfrag_t::generate_test_instances() {
   std::list<dirfrag_t> ls;
-  ls.push_back(dirfrag_t{});
+  ls.emplace_back();
   ls.push_back(dirfrag_t(1, frag_t()));
   ls.push_back(dirfrag_t(2, frag_t(3)));
   return ls;
@@ -1139,7 +1139,7 @@ void cap_reconnect_t::dump(Formatter *f) const
 std::list<cap_reconnect_t> cap_reconnect_t::generate_test_instances()
 {
   std::list<cap_reconnect_t> ls;
-  ls.push_back(cap_reconnect_t{});
+  ls.emplace_back();
   ls.back().path = "/test/path";
   ls.back().capinfo.cap_id = 1;
   return ls;
@@ -1180,7 +1180,7 @@ void snaprealm_reconnect_t::dump(Formatter *f) const
 std::list<snaprealm_reconnect_t> snaprealm_reconnect_t::generate_test_instances()
 {
   std::list<snaprealm_reconnect_t> ls;
-  ls.push_back(snaprealm_reconnect_t{});
+  ls.emplace_back();
   ls.back().realm.ino = 0x10000000001ULL;
   ls.back().realm.seq = 2;
   ls.back().realm.parent = 1;
index 37d7150ef0b12c557481f4bf29283ebf3d10efa2..0e983dbac760dd7c8ddbeae2300164d2a6b25d29 100644 (file)
@@ -206,8 +206,8 @@ template<template<typename> class Allocator>
 auto old_inode_t<Allocator>::generate_test_instances() -> std::list<old_inode_t<Allocator>>
 {
   std::list<old_inode_t<Allocator>> ls;
-  ls.push_back(old_inode_t<Allocator>{});
-  ls.push_back(old_inode_t<Allocator>{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().first = 2;
   std::list<inode_t<Allocator>> ils = inode_t<Allocator>::generate_test_instances();
   ls.back().inode = ils.back();
index 559a6ea29c04749aaaf50c00a083692ae4fa0a13..ca316d084a2d59723001d5a5dcdcfa81c9f91407 100644 (file)
@@ -67,8 +67,8 @@ void SnapInfo::dump(Formatter *f) const
 std::list<SnapInfo> SnapInfo::generate_test_instances()
 {
   std::list<SnapInfo> ls;
-  ls.push_back(SnapInfo{});
-  ls.push_back(SnapInfo{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().snapid = 1;
   ls.back().ino = 2;
   ls.back().stamp = utime_t(3, 4);
@@ -126,8 +126,8 @@ void snaplink_t::dump(Formatter *f) const
 std::list<snaplink_t> snaplink_t::generate_test_instances()
 {
   std::list<snaplink_t> ls;
-  ls.push_back(snaplink_t{});
-  ls.push_back(snaplink_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().ino = 2;
   ls.back().first = 123;
   return ls;
@@ -226,8 +226,8 @@ void sr_t::dump(Formatter *f) const
 std::list<sr_t> sr_t::generate_test_instances()
 {
   std::list<sr_t> ls;
-  ls.push_back(sr_t{});
-  ls.push_back(sr_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().seq = 1;
   ls.back().created = 2;
   ls.back().last_created = 3;
index 19af4377bbdcc64ff66da9fae4e267ada931b201..e844592d277f71169698698d29548e9221af9593 100644 (file)
@@ -326,8 +326,8 @@ public:
   }
   static std::list<openc_response_t> generate_test_instances() {
     std::list<openc_response_t> ls;
-    ls.push_back(openc_response_t{});
-    ls.push_back(openc_response_t{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().created_ino = 1;
     ls.back().delegated_inos.insert(1, 10);
     return ls;
index a1e4bd48caccb1f220573e4648418b66198cdb01..98d5be446c065f0e5ba88b5b232b237a3cfb812a 100644 (file)
@@ -67,8 +67,8 @@ struct SnapPayload {
   }
   static std::list<SnapPayload> generate_test_instances() {
     std::list<SnapPayload> o;
-    o.push_back(SnapPayload{});
-    o.push_back(SnapPayload{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().metadata["key1"] = "val1";
     o.back().metadata["key2"] = "val2";
     return o;
@@ -124,8 +124,8 @@ public:
 
     static std::list<Release> generate_test_instances() {
       std::list<Release> ls;
-      ls.push_back(Release{});
-      ls.push_back(Release{});
+      ls.emplace_back();
+      ls.emplace_back();
       ls.back().item.dname_len = 4;
       ls.back().dname = "test";
       return ls;
index b3b982575d3e2a22bbe3875bd12fb0f0a7b15e76..a0d078d34083f907533e3d2333d9f371e692ea5f 100644 (file)
@@ -224,8 +224,8 @@ struct MDSHealth
 
   static std::list<MDSHealth> generate_test_instances() {
     std::list<MDSHealth> ls;
-    ls.push_back(MDSHealth{});
-    ls.push_back(MDSHealth{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().metrics.push_back(MDSHealthMetric(MDS_HEALTH_TRIM, HEALTH_WARN,
              "MDS is behind on trimming"));
     return ls;
index 022df4e5d0cce5eaa0a76e9790b0012ab19803f9..ffe91c57b17e3eda886cb754ef6ee51dc9eee28c 100644 (file)
@@ -72,7 +72,7 @@ public:
     }
     static std::list<inode_strong> generate_test_instances() {
       std::list<inode_strong> ls;
-      ls.push_back(inode_strong{});
+      ls.emplace_back();
       ls.push_back(inode_strong(1, 2, 3, 4, 5));
       return ls;
     }
@@ -96,7 +96,7 @@ public:
     }
     static std::list<dirfrag_strong> generate_test_instances() {
       std::list<dirfrag_strong> ls;
-      ls.push_back(dirfrag_strong{});
+      ls.emplace_back();
       ls.push_back(dirfrag_strong(1, 2));
       return ls;
     }
@@ -143,7 +143,7 @@ public:
     }
     static std::list<dn_strong> generate_test_instances() {
       std::list<dn_strong> ls;
-      ls.push_back(dn_strong{});
+      ls.emplace_back();
       ls.push_back(dn_strong(1, "alternate_name", 2, 3, 4, 5, 6));
       return ls;
     }
@@ -201,7 +201,7 @@ public:
     }
     static std::list<dn_strong_new> generate_test_instances() {
       std::list<dn_strong_new> ls;
-      ls.push_back(dn_strong_new{});
+      ls.emplace_back();
       ls.push_back(dn_strong_new(1, "alternate_name", 2, 3, 4, 5, 6, 7));
       return ls;
     }
index 9fc8c177ac54309dd0e3e531dba7bb2ab84943e6..0139fc06ee9a2187340a2cf41a2bcd8914813d99 100644 (file)
@@ -87,8 +87,8 @@ public:
   static std::list<PerfCounterType> generate_test_instances()
   {
     std::list<PerfCounterType> ls;
-    ls.push_back(PerfCounterType{});
-    ls.push_back(PerfCounterType{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().path = "mycounter";
     ls.back().description = "mycounter description";
     ls.back().nick = "mycounter nick";
index e11b9f4480b24e323ae27307d19517a1703eafc0..e715b5a92acaf05c560477f7e601b2d0e180da74 100644 (file)
@@ -399,8 +399,8 @@ struct MDSPerfMetricReport {
   }
   static std::list<MDSPerfMetricReport> generate_test_instances() {
     std::list<MDSPerfMetricReport> o;
-    o.push_back(MDSPerfMetricReport{});
-    o.push_back(MDSPerfMetricReport{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().reports.emplace(MDSPerfMetricQuery(), MDSPerfMetrics());
     o.back().rank_metrics_delayed.insert(1);
     return o;
index ec317db7759ade86aa51af8a319dcd7c790f0eea..52dedcc0a0b59a152656ca489483c68ca6c4c221 100644 (file)
@@ -244,7 +244,7 @@ struct MDSConfigPayload {
   }
   static std::list<MDSConfigPayload> generate_test_instances() {
     std::list<MDSConfigPayload> ls;
-    ls.push_back(MDSConfigPayload{});
+    ls.emplace_back();
     return ls;
   }
 };
index 1d10b13ab5c89bb6c909230c642809b98d31303b..637223ee49aea4a7beeae20537b5c0ad29f51796 100644 (file)
@@ -387,24 +387,24 @@ void MgrCap::dump(ceph::Formatter *f) const {
 
 std::list<MgrCap> MgrCap::generate_test_instances() {
   std::list<MgrCap> ls;
-  ls.push_back(MgrCap{});
-  ls.push_back(MgrCap{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().parse("allow *");
-  ls.push_back(MgrCap{});
+  ls.emplace_back();
   ls.back().parse("allow rwx");
-  ls.push_back(MgrCap{});
+  ls.emplace_back();
   ls.back().parse("allow service foo x");
-  ls.push_back(MgrCap{});
+  ls.emplace_back();
   ls.back().parse("allow command bar x");
-  ls.push_back(MgrCap{});
+  ls.emplace_back();
   ls.back().parse("allow service foo r, allow command bar x");
-  ls.push_back(MgrCap{});
+  ls.emplace_back();
   ls.back().parse("allow command bar with k1=v1 x");
-  ls.push_back(MgrCap{});
+  ls.emplace_back();
   ls.back().parse("allow command bar with k1=v1 k2=v2 x");
-  ls.push_back(MgrCap{});
+  ls.emplace_back();
   ls.back().parse("allow module bar with k1=v1 k2=v2 x");
-  ls.push_back(MgrCap{});
+  ls.emplace_back();
   ls.back().parse("profile rbd pool=rbd");
   return ls;
 }
index 6345c88917798b5a5fb80c867b0f52a12b3b5e2f..dc7b0717c6dfa88e9ddf824d23f941eeefdcad0e 100644 (file)
@@ -426,8 +426,8 @@ struct OSDPerfMetricReport {
 
   static std::list<OSDPerfMetricReport> generate_test_instances() {
     std::list<OSDPerfMetricReport> o;
-    o.push_back(OSDPerfMetricReport{});
-    o.push_back(OSDPerfMetricReport{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().performance_counter_descriptors.push_back(
         PerformanceCounterDescriptor(PerformanceCounterType::OPS));
     o.back().performance_counter_descriptors.push_back(
index 10d2cd9fc98e00073a7b14885511903d14fb44c9..de9bfcafa3edc8371be28a15c7629c88be021f08 100644 (file)
@@ -61,8 +61,8 @@ void ServiceMap::Daemon::dump(Formatter *f) const
 auto ServiceMap::Daemon::generate_test_instances() -> std::list<Daemon>
 {
   std::list<Daemon> ls;
-  ls.push_back(Daemon{});
-  ls.push_back(Daemon{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().gid = 222;
   ls.back().metadata["this"] = "that";
   ls.back().task_status["task1"] = "running";
@@ -199,8 +199,8 @@ void ServiceMap::Service::dump(Formatter *f) const
 auto ServiceMap::Service::generate_test_instances() -> std::list<Service>
 {
   std::list<Service> ls;
-  ls.push_back(Service{});
-  ls.push_back(Service{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().daemons["one"].gid = 1;
   ls.back().daemons["two"].gid = 2;
   return ls;
@@ -240,8 +240,8 @@ void ServiceMap::dump(Formatter *f) const
 std::list<ServiceMap> ServiceMap::generate_test_instances()
 {
   std::list<ServiceMap> ls;
-  ls.push_back(ServiceMap{});
-  ls.push_back(ServiceMap{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().epoch = 123;
   ls.back().services["rgw"].daemons["one"].gid = 123;
   ls.back().services["rgw"].daemons["two"].gid = 344;
index c8860cf299b97a0379d19f0fa1460d65bf0c06fd..06302936653d6c24e25a5780d3c8245effdffb55 100644 (file)
@@ -84,11 +84,11 @@ public:
     }
     static std::list<Incremental> generate_test_instances() {
       std::list<Incremental> ls;
-      ls.push_back(Incremental{});
-      ls.push_back(Incremental{});
+      ls.emplace_back();
+      ls.emplace_back();
       ls.back().inc_type = GLOBAL_ID;
       ls.back().max_global_id = 1234;
-      ls.push_back(Incremental{});
+      ls.emplace_back();
       ls.back().inc_type = AUTH_DATA;
       ls.back().auth_type = 12;
       ls.back().auth_data.append("foo");
index a80f91f2ff513480b7d0916ce7b51149a119473f..66c92865af124e77cd3996e28ffe793222127459 100644 (file)
@@ -504,8 +504,8 @@ void ConnectionReport::dump(ceph::Formatter *f) const
 std::list<ConnectionReport> ConnectionReport::generate_test_instances()
 {
   std::list<ConnectionReport> o;
-  o.push_back(ConnectionReport{});
-  o.push_back(ConnectionReport{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().rank = 1;
   o.back().epoch = 2;
   o.back().epoch_version = 3;
@@ -533,8 +533,8 @@ void ConnectionTracker::dump(ceph::Formatter *f) const
 std::list<ConnectionTracker> ConnectionTracker::generate_test_instances()
 {
   std::list<ConnectionTracker> o;
-  o.push_back(ConnectionTracker{});
-  o.push_back(ConnectionTracker{});
+  o.emplace_back();
+  o.emplace_back();
   ConnectionTracker& e = o.back();
   e.rank = 2;
   e.epoch = 3;
index d21b6264bb98540eb1863ca595c102898e81c8a7..61fa0be30342c95ea83daf24b58f6684e2542cf2 100644 (file)
@@ -85,9 +85,9 @@ struct creating_pgs_t {
     }
     static std::list<pg_create_info> generate_test_instances() {
       std::list<pg_create_info> o;
-      o.push_back(pg_create_info{});
+      o.emplace_back();
       o.back().create_epoch = 10;
-      o.push_back(pg_create_info{});
+      o.emplace_back();
       o.back().create_epoch = 1;
       o.back().create_stamp = utime_t(2, 3);
       o.back().up = {1, 2, 3};
index de6dde22a780afa3d9a9eb9a905dc69e824665a0..d846e6409d0c8a40b93c0279a61a50d1301a93a8 100644 (file)
@@ -110,8 +110,8 @@ public:
     static std::list<ModuleOption> generate_test_instances()
     {
       std::list<ModuleOption> ls;
-      ls.push_back(ModuleOption{});
-      ls.push_back(ModuleOption{});
+      ls.emplace_back();
+      ls.emplace_back();
       ls.back().name = "name";
       ls.back().type = Option::TYPE_STR;
       ls.back().level = Option::LEVEL_ADVANCED;
@@ -180,8 +180,8 @@ public:
     static std::list<ModuleInfo> generate_test_instances()
     {
       std::list<ModuleInfo> ls;
-      ls.push_back(ModuleInfo{});
-      ls.push_back(ModuleInfo{});
+      ls.emplace_back();
+      ls.emplace_back();
       ls.back().name = "name";
       ls.back().can_run = true;
       ls.back().error_string = "error_string";
@@ -642,7 +642,7 @@ public:
   static std::list<MgrMap> generate_test_instances()
   {
     std::list<MgrMap> l;
-    l.push_back(MgrMap{});
+    l.emplace_back();
     return l;
   }
 
index ecec105fdedab2af61447a063e74c5abbba77bed..c4d60f99ac0100f40cffba82ba7a8ee2d82302ca 100644 (file)
@@ -532,20 +532,20 @@ void MonCap::dump(Formatter *f) const
 list<MonCap> MonCap::generate_test_instances()
 {
   list<MonCap> ls;
-  ls.push_back(MonCap{});
-  ls.push_back(MonCap{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().parse("allow *");
-  ls.push_back(MonCap{});
+  ls.emplace_back();
   ls.back().parse("allow rwx");
-  ls.push_back(MonCap{});
+  ls.emplace_back();
   ls.back().parse("allow service foo x");
-  ls.push_back(MonCap{});
+  ls.emplace_back();
   ls.back().parse("allow command bar x");
-  ls.push_back(MonCap{});
+  ls.emplace_back();
   ls.back().parse("allow service foo r, allow command bar x");
-  ls.push_back(MonCap{});
+  ls.emplace_back();
   ls.back().parse("allow command bar with k1=v1 x");
-  ls.push_back(MonCap{});
+  ls.emplace_back();
   ls.back().parse("allow command bar with k1=v1 k2=v2 x");
   return ls;
 }
index 994ef178ea0fbfc992bc8eb81560a173cf642121..bc87e98033a34646abcbbdb46f2fcce7e9f6e2ff 100644 (file)
@@ -64,8 +64,8 @@ struct MonCommand {
 
   static std::list<MonCommand> generate_test_instances() {
     std::list<MonCommand> ls;
-    ls.push_back(MonCommand{});
-    ls.push_back(MonCommand{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().cmdstring = "foo";
     ls.back().helpstring = "bar";
     ls.back().module = "baz";
index 533c3fd8d124af0692b72546eecd6ff6644dc588..8b487a38f9899e948e87c5634b5eed97f1b54e60 100644 (file)
@@ -123,8 +123,8 @@ void mon_info_t::dump(ceph::Formatter *f) const
 list<mon_info_t> mon_info_t::generate_test_instances()
 {
   list<mon_info_t> ls;
-  ls.push_back(mon_info_t{});
-  ls.push_back(mon_info_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().name = "noname";
   ls.back().public_addrs.parse("v1:1.2.3.4:567/890");
   ls.back().priority = 1;
@@ -328,8 +328,8 @@ void MonMap::decode(ceph::buffer::list::const_iterator& p)
 list<MonMap> MonMap::generate_test_instances()
 {
   list<MonMap> o;
-  o.push_back(MonMap{});
-  o.push_back(MonMap{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().epoch = 1;
   o.back().last_changed = utime_t(123, 456);
   o.back().created = utime_t(789, 101112);
index 32df36ea3fcfa2e959b032848ce16b38385bf2c9..f4c66de1812884d9c57d879cfac8708d45ef980e 100644 (file)
@@ -121,7 +121,7 @@ class MonitorDBStore
 
     static std::list<Op> generate_test_instances() {
       std::list<Op> ls;
-      ls.push_back(Op{});
+      ls.emplace_back();
       // we get coverage here from the Transaction instances
       return ls;
     }
@@ -209,8 +209,8 @@ class MonitorDBStore
 
     static std::list<Transaction> generate_test_instances() {
       std::list<Transaction> ls;
-      ls.push_back(Transaction{});
-      ls.push_back(Transaction{});
+      ls.emplace_back();
+      ls.emplace_back();
       ceph::buffer::list bl;
       bl.append("value");
       ls.back().put("prefix", "key", bl);
index 3a6a7b6c1b0724d973538b466372c56afb7c43fa..68b6fb50e98bd30a7cf55acc8c9e140eb735dc48 100644 (file)
@@ -197,7 +197,7 @@ void PGMapDigest::dump(ceph::Formatter *f) const
 list<PGMapDigest> PGMapDigest::generate_test_instances()
 {
   list<PGMapDigest> ls;
-  ls.push_back(PGMapDigest{});
+  ls.emplace_back();
   return ls;
 }
 
@@ -1118,15 +1118,15 @@ void PGMap::Incremental::dump(ceph::Formatter *f) const
 list<PGMap::Incremental> PGMap::Incremental::generate_test_instances()
 {
   list<PGMap::Incremental> o;
-  o.push_back(Incremental{});
-  o.push_back(Incremental{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().version = 1;
   o.back().stamp = utime_t(123,345);
-  o.push_back(Incremental{});
+  o.emplace_back();
   o.back().version = 2;
   o.back().pg_stat_updates[pg_t(1,2)] = pg_stat_t();
   o.back().osd_stat_updates[5] = osd_stat_t();
-  o.push_back(Incremental{});
+  o.emplace_back();
   o.back().version = 3;
   o.back().osdmap_epoch = 1;
   o.back().pg_scan = 2;
@@ -2264,7 +2264,7 @@ void PGMap::clear_delta()
 list<PGMap> PGMap::generate_test_instances()
 {
   list<PGMap> o;
-  o.push_back(PGMap{});
+  o.emplace_back();
   list<Incremental> inc = Incremental::generate_test_instances();
   inc.pop_front();
   while (!inc.empty()) {
index 2ce76be85534837485b5cd17910d213b728ca820..6df83ab4739778b49d26c3e5b53174dafaa11b52 100644 (file)
@@ -84,8 +84,8 @@ public:
     }
     static std::list<pg_count> generate_test_instances() {
       std::list<pg_count> o;
-      o.push_back(pg_count{});
-      o.push_back(pg_count{});
+      o.emplace_back();
+      o.emplace_back();
       o.back().acting = 1;
       o.back().up_not_acting = 2;
       o.back().primary = 3;
index 28ada82dbc2b4367a5b931f92d4d781060901670..26436e2f1713ff82ed138f0712446417dd9420f9 100644 (file)
@@ -60,9 +60,9 @@ struct health_check_t {
 
   static std::list<health_check_t> generate_test_instances() {
     std::list<health_check_t> ls;
-    ls.push_back(health_check_t{});
+    ls.emplace_back();
     ls.back().severity = HEALTH_WARN;
-    ls.push_back(health_check_t{});
+    ls.emplace_back();
     ls.back().severity = HEALTH_ERR;
     ls.back().summary = "summarization";
     ls.back().detail = {"one", "two", "three"};
@@ -102,8 +102,8 @@ struct health_mute_t {
 
   static std::list<health_mute_t> generate_test_instances() {
     std::list<health_mute_t> ls;
-    ls.push_back(health_mute_t{});
-    ls.push_back(health_mute_t{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().code = "OSD_DOWN";
     ls.back().ttl = utime_t(1, 2);
     ls.back().sticky = true;
@@ -132,8 +132,8 @@ struct health_check_map_t {
   static std::list<health_check_map_t> generate_test_instances() {
     std::list<health_check_map_t> ls;
 
-    ls.push_back(health_check_map_t{});
-    ls.push_back(health_check_map_t{});
+    ls.emplace_back();
+    ls.emplace_back();
     {
       auto& d = ls.back().add("FOO", HEALTH_WARN, "foo", 2);
       d.detail.push_back("a");
index bff2e1e298d3c791fe969f3bc259013f70b602ce..4640abd4d2869e008bd17c38b0ee31660c279a96 100644 (file)
@@ -120,8 +120,8 @@ struct FeatureMap {
 
   static std::list<FeatureMap> generate_test_instances() {
     std::list<FeatureMap> ls;
-    ls.push_back(FeatureMap{});
-    ls.push_back(FeatureMap{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().add(CEPH_ENTITY_TYPE_OSD, CEPH_FEATURE_UID);
     ls.back().add(CEPH_ENTITY_TYPE_OSD, CEPH_FEATURE_NOSRCADDR);
     ls.back().add(CEPH_ENTITY_TYPE_OSD, CEPH_FEATURE_PGID64);
@@ -179,8 +179,8 @@ struct MonitorDBStoreStats {
 
   static std::list<MonitorDBStoreStats> generate_test_instances() {
     std::list<MonitorDBStoreStats> ls;
-    ls.push_back(MonitorDBStoreStats{});
-    ls.push_back(MonitorDBStoreStats{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().bytes_total = 1024*1024;
     ls.back().bytes_sst = 512*1024;
     ls.back().bytes_log = 256*1024;
@@ -212,8 +212,8 @@ struct DataStats {
   }
   static std::list<DataStats> generate_test_instances() {
     std::list<DataStats> ls;
-    ls.push_back(DataStats{});
-    ls.push_back(DataStats{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().fs_stats.byte_total = 1024*1024;
     ls.back().fs_stats.byte_used = 512*1024;
     ls.back().fs_stats.byte_avail = 256*1024;
@@ -295,8 +295,8 @@ struct ScrubResult {
   }
   static std::list<ScrubResult> generate_test_instances() {
     std::list<ScrubResult> ls;
-    ls.push_back(ScrubResult{});
-    ls.push_back(ScrubResult{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().prefix_crc["foo"] = 123;
     ls.back().prefix_keys["bar"] = 456;
     return ls;
@@ -508,10 +508,10 @@ public:
 
   static std::list<mon_feature_t> generate_test_instances() {
     std::list<mon_feature_t> ls;
-    ls.push_back(mon_feature_t{});
-    ls.push_back(mon_feature_t{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().features = 1;
-    ls.push_back(mon_feature_t{});
+    ls.emplace_back();
     ls.back().features = 2;
     return ls;
   }
@@ -739,8 +739,8 @@ struct ProgressEvent {
   }
   static std::list<ProgressEvent> generate_test_instances() {
     std::list<ProgressEvent> o;
-    o.push_back(ProgressEvent{});
-    o.push_back(ProgressEvent{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().message = "test message";
     o.back().progress = 0.5;
     o.back().add_to_ceph_s = true;
@@ -801,11 +801,11 @@ struct PoolAvailability {
 
   static std::list<PoolAvailability> generate_test_instances() {
     std::list<PoolAvailability> o;
-    o.push_back(PoolAvailability{});
+    o.emplace_back();
     o.back().started_at = utime_t(123, 456);
     o.back().last_uptime = utime_t(123, 456);
     o.back().last_downtime = utime_t(123, 456);
-    o.push_back(PoolAvailability{});
+    o.emplace_back();
     o.back().pool_name = "foo";
     o.back().started_at = utime_t(123, 456);
     o.back().uptime = 100;
index 112de8aa1fb66e0f0063b519ccbb253b4c2873af..2076395e4f3458780f14ab509697f8ad02646f97 100644 (file)
@@ -43,7 +43,7 @@ struct SequencerPosition {
   }
   static std::list<SequencerPosition> generate_test_instances() {
     std::list<SequencerPosition> o;
-    o.push_back(SequencerPosition{});
+    o.emplace_back();
     o.push_back(SequencerPosition(1, 2, 3));
     o.push_back(SequencerPosition(4, 5, 6));
     return o;
index 3569d001ff23bce38cb24437f796f5e7be247664..848b993fd74777ff1cf63b05e46ced26d319f999 100644 (file)
@@ -534,7 +534,7 @@ list<Transaction> Transaction::generate_test_instances()
 {
   list<Transaction> o;
 
-  o.push_back(Transaction{});
+  o.emplace_back();
 
   Transaction t;
   t.nop();
index b894f1871efdda3794b8dd2053f77b0c2872ddbe..ec1c8364ffde7d1eb554727e737d5b81bd1545c1 100644 (file)
@@ -28,8 +28,8 @@ void bluefs_extent_t::dump(Formatter *f) const
 list<bluefs_extent_t> bluefs_extent_t::generate_test_instances()
 {
   list<bluefs_extent_t> ls;
-  ls.push_back(bluefs_extent_t{});
-  ls.push_back(bluefs_extent_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().offset = 1;
   ls.back().length = 2;
   ls.back().bdev = 1;
@@ -168,8 +168,8 @@ void bluefs_layout_t::dump(Formatter *f) const
 list<bluefs_layout_t> bluefs_layout_t::generate_test_instances()
 {
   list<bluefs_layout_t> ls;
-  ls.push_back(bluefs_layout_t{});
-  ls.push_back(bluefs_layout_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().shared_bdev = 1;
   ls.back().dedicated_db = true;
   ls.back().dedicated_wal = true;
@@ -224,8 +224,8 @@ void bluefs_super_t::dump(Formatter *f) const
 list<bluefs_super_t> bluefs_super_t::generate_test_instances()
 {
   list<bluefs_super_t> ls;
-  ls.push_back(bluefs_super_t{});
-  ls.push_back(bluefs_super_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().seq = 1;
   ls.back().block_size = 4096;
   return ls;
@@ -313,8 +313,8 @@ void bluefs_fnode_t::dump(Formatter *f) const
 list<bluefs_fnode_t> bluefs_fnode_t::generate_test_instances()
 {
   list<bluefs_fnode_t> ls;
-  ls.push_back(bluefs_fnode_t{});
-  ls.push_back(bluefs_fnode_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().ino = 123;
   ls.back().size = 1048576;
   ls.back().mtime = utime_t(123,45);
@@ -419,8 +419,8 @@ void bluefs_transaction_t::dump(Formatter *f) const
 list<bluefs_transaction_t> bluefs_transaction_t::generate_test_instances()
 {
   list<bluefs_transaction_t> ls;
-  ls.push_back(bluefs_transaction_t{});
-  ls.push_back(bluefs_transaction_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().op_init();
   ls.back().op_dir_create("dir");
   ls.back().op_dir_create("dir2");
index 940e976cff34c06ccc698e1927ec8d0f514b80cc..de6feb0f70509536f50abb23e750395679ca1758 100644 (file)
@@ -72,8 +72,8 @@ void bluestore_bdev_label_t::dump(Formatter *f) const
 list<bluestore_bdev_label_t> bluestore_bdev_label_t::generate_test_instances()
 {
   list<bluestore_bdev_label_t> o;
-  o.push_back(bluestore_bdev_label_t{});
-  o.push_back(bluestore_bdev_label_t{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().size = 123;
   o.back().btime = utime_t(4, 5);
   o.back().description = "fakey";
@@ -379,8 +379,8 @@ void bluestore_extent_ref_map_t::dump(Formatter *f) const
 list<bluestore_extent_ref_map_t> bluestore_extent_ref_map_t::generate_test_instances()
 {
   list<bluestore_extent_ref_map_t> o;
-  o.push_back(bluestore_extent_ref_map_t{});
-  o.push_back(bluestore_extent_ref_map_t{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().get(10, 10);
   o.back().get(18, 22);
   o.back().get(20, 20);
@@ -749,7 +749,7 @@ ostream& operator<<(ostream& out, const bluestore_pextent_t& o) {
 list<bluestore_pextent_t> bluestore_pextent_t::generate_test_instances()
 {
   list<bluestore_pextent_t> ls;
-  ls.push_back(bluestore_pextent_t{});
+  ls.emplace_back();
   ls.push_back(bluestore_pextent_t(1, 2));
   return ls;
 }
@@ -834,11 +834,11 @@ void bluestore_blob_t::dump(Formatter *f) const
 list<bluestore_blob_t> bluestore_blob_t::generate_test_instances()
 {
   list<bluestore_blob_t> ls;
-  ls.push_back(bluestore_blob_t{});
+  ls.emplace_back();
   ls.push_back(bluestore_blob_t(0));
-  ls.push_back(bluestore_blob_t{});
+  ls.emplace_back();
   ls.back().allocated_test(bluestore_pextent_t(111, 222));
-  ls.push_back(bluestore_blob_t{});
+  ls.emplace_back();
   ls.back().init_csum(Checksummer::CSUM_XXHASH32, 16, 65536);
   ls.back().csum_data = ceph::buffer::claim_malloc(4, strdup("abcd"));
   ls.back().add_unused(0, 3);
@@ -1397,8 +1397,8 @@ void bluestore_onode_t::shard_info::dump(Formatter *f) const
 auto bluestore_onode_t::shard_info::generate_test_instances() -> list<shard_info>
 {
   list<shard_info> o;
-  o.push_back(shard_info{});
-  o.push_back(shard_info{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().offset = 123;
   o.back().bytes = 456;
   return o;
@@ -1501,8 +1501,8 @@ void bluestore_deferred_op_t::dump(Formatter *f) const
 list<bluestore_deferred_op_t> bluestore_deferred_op_t::generate_test_instances()
 {
   list<bluestore_deferred_op_t> o;
-  o.push_back(bluestore_deferred_op_t{});
-  o.push_back(bluestore_deferred_op_t{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().op = OP_WRITE;
   o.back().extents.push_back(bluestore_pextent_t(1, 2));
   o.back().extents.push_back(bluestore_pextent_t(100, 5));
@@ -1555,7 +1555,7 @@ void bluestore_compression_header_t::dump(Formatter *f) const
 list<bluestore_compression_header_t> bluestore_compression_header_t::generate_test_instances()
 {
   list<bluestore_compression_header_t> o;
-  o.push_back(bluestore_compression_header_t{});
+  o.emplace_back();
   o.push_back(bluestore_compression_header_t(1));
   o.back().length = 1234;
   return o;
index 1e489c7074cf703378945f7ff08b36557b83616d..422433e28f13515e4643ff80edfa1f1cbd891671 100644 (file)
@@ -165,7 +165,7 @@ struct bluestore_extent_ref_map_t {
     }
     static std::list<record_t> generate_test_instances() {
       std::list<record_t> o;
-      o.push_back(record_t{});
+      o.emplace_back();
       o.push_back(record_t(123, 456));
       return o;
     }
index 937d4362713df32b86536d5cbbbc8a8864360314..fd5b36c52c8804f26312f76b92bef7cfb4958c0e 100644 (file)
@@ -97,7 +97,7 @@ void HitSet::dump(Formatter *f) const
 list<HitSet> HitSet::generate_test_instances()
 {
   list<HitSet> o;
-  o.push_back(HitSet{});
+  o.emplace_back();
   o.push_back(HitSet(new BloomHitSet(10, .1, 1)));
   o.back().insert(hobject_t());
   o.back().insert(hobject_t("asdf", "", CEPH_NOSNAP, 123, 1, ""));
@@ -200,7 +200,7 @@ list<HitSet::Params> HitSet::Params::generate_test_instances()
   for (auto& i : kind::Params::generate_test_instances()) \
     o.push_back(Params(&i)); \
 }
-  o.push_back(Params{});
+  o.emplace_back();
   o.push_back(Params(new BloomHitSet::Params));
   loop_hitset_params(BloomHitSet);
   o.push_back(Params(new ExplicitHashHitSet::Params));
index fc4881e7e332566d547483149bd4e76fdcfae86e..bb4fe1328cb72b76bd0ba6132bb9aa1094ee8461 100644 (file)
@@ -192,7 +192,7 @@ public:
     }
     static std::list<Params> generate_test_instances() {
       std::list<Params> o;
-      o.push_back(Params{});
+      o.emplace_back();
       return o;
     }
   };
@@ -240,8 +240,8 @@ public:
   void dump(ceph::Formatter *f) const override;
   static std::list<ExplicitHashHitSet> generate_test_instances() {
     std::list<ExplicitHashHitSet> o;
-    o.push_back(ExplicitHashHitSet{});
-    o.push_back(ExplicitHashHitSet{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().insert(hobject_t());
     o.back().insert(hobject_t("asdf", "", CEPH_NOSNAP, 123, 1, ""));
     o.back().insert(hobject_t("qwer", "", CEPH_NOSNAP, 456, 1, ""));
@@ -267,7 +267,7 @@ public:
     }
     static std::list<Params> generate_test_instances() {
       std::list<Params> o;
-      o.push_back(Params{});
+      o.emplace_back();
       return o;
     }
   };
@@ -315,8 +315,8 @@ public:
   void dump(ceph::Formatter *f) const override;
   static std::list<ExplicitObjectHitSet> generate_test_instances() {
     std::list<ExplicitObjectHitSet> o;
-    o.push_back(ExplicitObjectHitSet{});
-    o.push_back(ExplicitObjectHitSet{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().insert(hobject_t());
     o.back().insert(hobject_t("asdf", "", CEPH_NOSNAP, 123, 1, ""));
     o.back().insert(hobject_t("qwer", "", CEPH_NOSNAP, 456, 1, ""));
@@ -388,8 +388,8 @@ public:
     }
     static std::list<Params> generate_test_instances() {
       std::list<Params> o;
-      o.push_back(Params{});
-      o.push_back(Params{});
+      o.emplace_back();
+      o.emplace_back();
       o.back().fpp_micro = 123456;
       o.back().target_size = 300;
       o.back().seed = 99;
@@ -454,7 +454,7 @@ public:
   void dump(ceph::Formatter *f) const override;
   static std::list<BloomHitSet> generate_test_instances() {
     std::list<BloomHitSet> o;
-    o.push_back(BloomHitSet{});
+    o.emplace_back();
     o.push_back(BloomHitSet(10, .1, 1));
     o.back().insert(hobject_t());
     o.back().insert(hobject_t("asdf", "", CEPH_NOSNAP, 123, 1, ""));
index fb379de40ade5c571060d20e47ed2646bc8f8264..8c53acb404851f4120bf9623971ec44c64a0ab8e 100644 (file)
@@ -109,8 +109,8 @@ void osd_info_t::decode(ceph::buffer::list::const_iterator& bl)
 list<osd_info_t> osd_info_t::generate_test_instances()
 {
   list<osd_info_t> o;
-  o.push_back(osd_info_t{});
-  o.push_back(osd_info_t{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().last_clean_begin = 1;
   o.back().last_clean_end = 2;
   o.back().up_from = 30;
@@ -193,8 +193,8 @@ void osd_xinfo_t::decode(ceph::buffer::list::const_iterator& bl)
 list<osd_xinfo_t> osd_xinfo_t::generate_test_instances()
 {
   list<osd_xinfo_t> o;
-  o.push_back(osd_xinfo_t{});
-  o.push_back(osd_xinfo_t{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().down_stamp = utime_t(2, 3);
   o.back().laggy_probability = .123;
   o.back().laggy_interval = 123456;
@@ -1394,7 +1394,7 @@ void OSDMap::Incremental::dump(Formatter *f) const
 auto OSDMap::Incremental::generate_test_instances() -> list<Incremental>
 {
   list<Incremental> o;
-  o.push_back(Incremental{});
+  o.emplace_back();
   return o;
 }
 
index 306d430d274e43b8cf3bc729364fc94ba218975a..6560a53a5edc8e92adf94c103bb2bf06ad571e50 100644 (file)
@@ -348,8 +348,8 @@ struct PGTempMap {
   }
   static std::list<PGTempMap> generate_test_instances() {
     std::list<PGTempMap> o;
-    o.push_back(PGTempMap{});
-    o.push_back(PGTempMap{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().set(pg_t(1, 2), { 3, 4 });
     o.back().set(pg_t(2, 3), { 4, 5 });
     return o;
index 2f22ea9c9ee1777f6588c4f7a5ab17a2fa07f44b..fb59ece9eeff0c73cae7926f683caff0706ec5e1 100644 (file)
@@ -330,8 +330,8 @@ void SnapMapper::object_snaps::dump(ceph::Formatter *f) const
 auto SnapMapper::object_snaps::generate_test_instances() -> std::list<object_snaps>
 {
   std::list<object_snaps> o;
-  o.push_back(object_snaps{});
-  o.push_back(object_snaps{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().oid = hobject_t(sobject_t("name", CEPH_NOSNAP));
   o.back().snaps.insert(1);
   o.back().snaps.insert(2);
index aa043ad3bd843230ab7ba2cd349c4730cbdf1c6b..fe36bd73bfa7b2855cb63296dc1924886b10a22d 100644 (file)
@@ -163,8 +163,8 @@ public:
     }
     static std::list<Mapping> generate_test_instances() {
       std::list<Mapping> o;
-      o.push_back(Mapping{});
-      o.push_back(Mapping{});
+      o.emplace_back();
+      o.emplace_back();
       o.back().snap = 1;
       o.back().hoid = hobject_t(object_t("objname"), "key", 123, 456, 0, "");
       return o;
index eebfcd5459527adf6fe07563dd35d6ea6a780a26..2d72e25efba6fb0c4a26141a636ad613d67f1073 100644 (file)
@@ -242,7 +242,7 @@ void osd_reqid_t::dump(Formatter *f) const
 list<osd_reqid_t> osd_reqid_t::generate_test_instances()
 {
   list<osd_reqid_t> o;
-  o.push_back(osd_reqid_t{});
+  o.emplace_back();
   o.push_back(osd_reqid_t(entity_name_t::CLIENT(123), 1, 45678));
   return o;
 }
@@ -303,7 +303,7 @@ void object_locator_t::dump(Formatter *f) const
 list<object_locator_t> object_locator_t::generate_test_instances()
 {
   list<object_locator_t> o;
-  o.push_back(object_locator_t{});
+  o.emplace_back();
   o.push_back(object_locator_t(123));
   o.push_back(object_locator_t(123, 876));
   o.push_back(object_locator_t(1, "n2"));
@@ -696,9 +696,9 @@ std::list<osd_stat_t> osd_stat_t::generate_test_instances()
 {
   std::list<osd_stat_t> o;
 
-  o.push_back(osd_stat_t{});
+  o.emplace_back();
 
-  o.push_back(osd_stat_t{});
+  o.emplace_back();
   list<store_statfs_t> ll = store_statfs_t::generate_test_instances();
   o.back().statfs = ll.back();
   o.back().hb_peers.push_back(7);
@@ -920,7 +920,7 @@ void pg_t::dump(Formatter *f) const
 list<pg_t> pg_t::generate_test_instances()
 {
   list<pg_t> o;
-  o.push_back(pg_t{});
+  o.emplace_back();
   o.push_back(pg_t(1, 2));
   o.push_back(pg_t(13123, 3));
   o.push_back(pg_t(131223, 4));
@@ -1341,8 +1341,8 @@ void pool_snap_info_t::decode(ceph::buffer::list::const_iterator& bl)
 list<pool_snap_info_t> pool_snap_info_t::generate_test_instances()
 {
   list<pool_snap_info_t> o;
-  o.push_back(pool_snap_info_t{});
-  o.push_back(pool_snap_info_t{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().snapid = 1;
   o.back().stamp = utime_t(1, 2);
   o.back().name = "foo";
@@ -1562,7 +1562,7 @@ void pool_opts_t::decode(ceph::buffer::list::const_iterator& bl)
 std::list<pool_opts_t> pool_opts_t::generate_test_instances()
 {
   std::list<pool_opts_t> o;
-  o.push_back(pool_opts_t{});
+  o.emplace_back();
   return o;
 }
 
@@ -3641,8 +3641,8 @@ void pg_history_t::dump(Formatter *f) const
 list<pg_history_t> pg_history_t::generate_test_instances()
 {
   list<pg_history_t> o;
-  o.push_back(pg_history_t{});
-  o.push_back(pg_history_t{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().epoch_created = 1;
   o.back().epoch_pool_created = 1;
   o.back().last_epoch_started = 2;
@@ -3776,8 +3776,8 @@ void pg_info_t::dump(Formatter *f) const
 list<pg_info_t> pg_info_t::generate_test_instances()
 {
   list<pg_info_t> o;
-  o.push_back(pg_info_t{});
-  o.push_back(pg_info_t{});
+  o.emplace_back();
+  o.emplace_back();
   list<pg_history_t> h = pg_history_t::generate_test_instances();
   o.back().history = h.back();
   o.back().pgid = spg_t(pg_t(1, 2), shard_id_t::NO_SHARD);
@@ -3846,7 +3846,7 @@ list<pg_notify_t> pg_notify_t::generate_test_instances()
 {
   list<pg_notify_t> o;
 
-  o.push_back(pg_notify_t{});
+  o.emplace_back();
   o.push_back(pg_notify_t(shard_id_t(3), shard_id_t::NO_SHARD, 1, 1,
            pg_info_t(spg_t(pg_t(0,10), shard_id_t(-1))), PastIntervals(),
             PG_FEATURE_CLASSIC_ALL));
@@ -3940,8 +3940,8 @@ std::string PastIntervals::pg_interval_t::fmt_print() const
 auto PastIntervals::pg_interval_t::generate_test_instances() -> list<pg_interval_t>
 {
   list<pg_interval_t> o;
-  o.push_back(pg_interval_t{});
-  o.push_back(pg_interval_t{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().up.push_back(1);
   o.back().acting.push_back(2);
   o.back().acting.push_back(3);
@@ -5430,10 +5430,10 @@ void pg_log_t::dump(Formatter *f) const
 list<pg_log_t> pg_log_t::generate_test_instances()
 {
   list<pg_log_t> o;
-  o.push_back(pg_log_t{});
+  o.emplace_back();
 
   // this is nonsensical:
-  o.push_back(pg_log_t{});
+  o.emplace_back();
   o.back().head = eversion_t(1,2);
   o.back().tail = eversion_t(3,4);
   for (auto& p : pg_log_entry_t::generate_test_instances()) {
@@ -5579,15 +5579,15 @@ void object_copy_cursor_t::dump(Formatter *f) const
 list<object_copy_cursor_t> object_copy_cursor_t::generate_test_instances()
 {
   list<object_copy_cursor_t> o;
-  o.push_back(object_copy_cursor_t{});
-  o.push_back(object_copy_cursor_t{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().attr_complete = true;
   o.back().data_offset = 123;
-  o.push_back(object_copy_cursor_t{});
+  o.emplace_back();
   o.back().attr_complete = true;
   o.back().data_complete = true;
   o.back().omap_offset = "foo";
-  o.push_back(object_copy_cursor_t{});
+  o.emplace_back();
   o.back().attr_complete = true;
   o.back().data_complete = true;
   o.back().omap_complete = true;
@@ -5788,7 +5788,7 @@ void pg_create_t::dump(Formatter *f) const
 list<pg_create_t> pg_create_t::generate_test_instances()
 {
   list<pg_create_t> o;
-  o.push_back(pg_create_t{});
+  o.emplace_back();
   o.push_back(pg_create_t(1, pg_t(3, 4), 2));
   return o;
 }
@@ -5831,8 +5831,8 @@ void pg_hit_set_info_t::dump(Formatter *f) const
 list<pg_hit_set_info_t> pg_hit_set_info_t::generate_test_instances()
 {
   list<pg_hit_set_info_t> ls;
-  ls.push_back(pg_hit_set_info_t{});
-  ls.push_back(pg_hit_set_info_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().begin = utime_t(1, 2);
   ls.back().end = utime_t(3, 4);
   return ls;
@@ -5888,8 +5888,8 @@ void pg_hit_set_history_t::dump(Formatter *f) const
 list<pg_hit_set_history_t> pg_hit_set_history_t::generate_test_instances()
 {
   list<pg_hit_set_history_t> ls;
-  ls.push_back(pg_hit_set_history_t{});
-  ls.push_back(pg_hit_set_history_t{});
+  ls.emplace_back();
+  ls.emplace_back();
   ls.back().current_last_update = eversion_t(1, 2);
   ls.back().history.push_back(pg_hit_set_info_t());
   return ls;
@@ -6085,10 +6085,10 @@ void SnapSet::dump(Formatter *f) const
 list<SnapSet> SnapSet::generate_test_instances()
 {
   list<SnapSet> o;
-  o.push_back(SnapSet{});
-  o.push_back(SnapSet{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().seq = 123;
-  o.push_back(SnapSet{});
+  o.emplace_back();
   o.back().seq = 123;
   o.back().clones.push_back(12);
   o.back().clone_size[12] = 12345;
@@ -6194,8 +6194,8 @@ std::string watch_info_t::fmt_print() const
 list<watch_info_t> watch_info_t::generate_test_instances()
 {
   list<watch_info_t> o;
-  o.push_back(watch_info_t{});
-  o.push_back(watch_info_t{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().cookie = 123;
   o.back().timeout_seconds = 99;
   entity_addr_t ea;
@@ -6248,8 +6248,8 @@ void chunk_info_t::dump(Formatter *f) const
 std::list<chunk_info_t> chunk_info_t::generate_test_instances()
 {
   std::list<chunk_info_t> o;
-  o.push_back(chunk_info_t{});
-  o.push_back(chunk_info_t{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().length = 123;
   o.back().oid = hobject_t(object_t("foo"), "", 123, 456, -1, "");
   o.back().flags = cflag_t::FLAG_DIRTY;
@@ -6797,13 +6797,13 @@ ostream &operator<<(ostream &out, const ObjectRecoveryProgress &prog)
 list<ObjectRecoveryProgress> ObjectRecoveryProgress::generate_test_instances()
 {
   list<ObjectRecoveryProgress> o;
-  o.push_back(ObjectRecoveryProgress{});
+  o.emplace_back();
   o.back().first = false;
   o.back().data_complete = true;
   o.back().omap_complete = true;
   o.back().data_recovered_to = 100;
 
-  o.push_back(ObjectRecoveryProgress{});
+  o.emplace_back();
   o.back().first = true;
   o.back().data_complete = false;
   o.back().omap_complete = false;
@@ -6882,7 +6882,7 @@ void ObjectRecoveryInfo::decode(ceph::buffer::list::const_iterator &bl,
 list<ObjectRecoveryInfo> ObjectRecoveryInfo::generate_test_instances()
 {
   list<ObjectRecoveryInfo> o;
-  o.push_back(ObjectRecoveryInfo{});
+  o.emplace_back();
   o.back().soid = hobject_t(sobject_t("key", CEPH_NOSNAP));
   o.back().version = eversion_t(0,0);
   o.back().size = 100;
@@ -6928,10 +6928,10 @@ std::string ObjectRecoveryInfo::fmt_print() const
 list<PushReplyOp> PushReplyOp::generate_test_instances()
 {
   list<PushReplyOp> o;
-  o.push_back(PushReplyOp{});
-  o.push_back(PushReplyOp{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().soid = hobject_t(sobject_t("asdf", 2));
-  o.push_back(PushReplyOp{});
+  o.emplace_back();
   o.back().soid = hobject_t(sobject_t("asdf", CEPH_NOSNAP));
   return o;
 }
@@ -7003,11 +7003,11 @@ uint64_t PushReplyOp::cost(CephContext *cct) const
 list<PullOp> PullOp::generate_test_instances()
 {
   list<PullOp> o;
-  o.push_back(PullOp{});
-  o.push_back(PullOp{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().soid = hobject_t(sobject_t("asdf", 2));
   o.back().recovery_info.version = eversion_t(3, 10);
-  o.push_back(PullOp{});
+  o.emplace_back();
   o.back().soid = hobject_t(sobject_t("asdf", CEPH_NOSNAP));
   o.back().recovery_info.version = eversion_t(0, 0);
   return o;
@@ -7082,11 +7082,11 @@ uint64_t PullOp::cost(CephContext *cct) const
 list<PushOp> PushOp::generate_test_instances()
 {
   list<PushOp> o;
-  o.push_back(PushOp{});
-  o.push_back(PushOp{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().soid = hobject_t(sobject_t("asdf", 2));
   o.back().version = eversion_t(3, 10);
-  o.push_back(PushOp{});
+  o.emplace_back();
   o.back().soid = hobject_t(sobject_t("asdf", CEPH_NOSNAP));
   o.back().version = eversion_t(0, 0);
   return o;
@@ -7259,8 +7259,8 @@ void ScrubMap::dump(Formatter *f) const
 list<ScrubMap> ScrubMap::generate_test_instances()
 {
   list<ScrubMap> o;
-  o.push_back(ScrubMap{});
-  o.push_back(ScrubMap{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().valid_through = eversion_t(1, 2);
   o.back().incr_since = eversion_t(3, 4);
   list<object> obj = object::generate_test_instances();
@@ -7363,10 +7363,10 @@ auto ScrubMap::object::generate_test_instances() -> list<object>
 {
   list<object> o;
 
-  o.push_back(object{});
-  o.push_back(object{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().negative = true;
-  o.push_back(object{});
+  o.emplace_back();
   o.back().size = 123;
   {
     bufferlist foobl;
index 09950f809f22be43a0f723f608cdad1bee1bf1f9..3421cb0232ccef1d6bc44cc070dcaed7c513e35e 100644 (file)
@@ -204,7 +204,7 @@ struct pg_shard_t {
   }
   static std::list<pg_shard_t> generate_test_instances() {
     std::list<pg_shard_t> o;
-    o.push_back(pg_shard_t{});
+    o.emplace_back();
     o.push_back(pg_shard_t(1));
     o.push_back(pg_shard_t(1, shard_id_t(2)));
     return o;
@@ -619,7 +619,7 @@ struct spg_t {
   }
   static std::list<spg_t> generate_test_instances() {
     std::list<spg_t> o;
-    o.push_back(spg_t{});
+    o.emplace_back();
     o.push_back(spg_t(pg_t(1, 2), shard_id_t(3)));
     return o;
   }
@@ -956,7 +956,7 @@ public:
   }
   static std::list<eversion_t> generate_test_instances() {
     std::list<eversion_t> o;
-    o.push_back(eversion_t{});
+    o.emplace_back();
     o.push_back(eversion_t(1, 2));
     return o;
   }
@@ -1252,8 +1252,8 @@ struct pg_merge_meta_t {
   }
   static std::list<pg_merge_meta_t> generate_test_instances() {
     std::list<pg_merge_meta_t> o;
-    o.push_back(pg_merge_meta_t{});
-    o.push_back(pg_merge_meta_t{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().source_pgid = pg_t(1,2);
     o.back().ready_epoch = 1;
     o.back().last_epoch_started = 2;
@@ -3341,8 +3341,8 @@ struct pg_fast_info_t {
   }
   static std::list<pg_fast_info_t> generate_test_instances() {
     std::list<pg_fast_info_t> o;
-    o.push_back(pg_fast_info_t{});
-    o.push_back(pg_fast_info_t{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().last_update = eversion_t(1, 2);
     o.back().last_complete = eversion_t(3, 4);
     o.back().last_user_version = version_t(5);
@@ -4417,9 +4417,9 @@ struct pg_log_op_return_item_t {
   }
   static std::list<pg_log_op_return_item_t> generate_test_instances() {
     std::list<pg_log_op_return_item_t> o;
-    o.push_back(pg_log_op_return_item_t{});
+    o.emplace_back();
     o.back().rval = 0;
-    o.push_back(pg_log_op_return_item_t{});
+    o.emplace_back();
     o.back().rval = 1;
     o.back().bl.append("asdf");
     return o;
@@ -4969,11 +4969,11 @@ struct pg_missing_item {
   }
   static std::list<pg_missing_item> generate_test_instances() {
     std::list<pg_missing_item> o;
-    o.push_back(pg_missing_item{});
-    o.push_back(pg_missing_item{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().need = eversion_t(1, 2);
     o.back().have = eversion_t(1, 1);
-    o.push_back(pg_missing_item{});
+    o.emplace_back();
     o.back().need = eversion_t(3, 5);
     o.back().have = eversion_t(3, 4);
     o.back().clean_regions.mark_data_region_dirty(4096, 8192);
@@ -5335,14 +5335,14 @@ public:
   }
   static std::list<pg_missing_set> generate_test_instances() {
     std::list<pg_missing_set> o;
-    o.push_back(pg_missing_set{});
+    o.emplace_back();
     o.back().may_include_deletes = true;
-    o.push_back(pg_missing_set{});
+    o.emplace_back();
     o.back().add(
       hobject_t(object_t("foo"), "foo", 123, 456, 0, ""),
       eversion_t(5, 6), eversion_t(5, 1), false);
     o.back().may_include_deletes = true;
-    o.push_back(pg_missing_set{});
+    o.emplace_back();
     o.back().add(
       hobject_t(object_t("foo"), "foo", 123, 456, 0, ""),
       eversion_t(5, 6), eversion_t(5, 1), true);
@@ -5480,18 +5480,18 @@ struct pg_nls_response_template {
   }
   static std::list<pg_nls_response_template> generate_test_instances() {
     std::list<pg_nls_response_template<T>> o;
-    o.push_back(pg_nls_response_template<T>{});
-    o.push_back(pg_nls_response_template<T>{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().handle = hobject_t(object_t("hi"), "key", 1, 2, -1, "");
     o.back().entries.push_back(librados::ListObjectImpl("", "one", ""));
     o.back().entries.push_back(librados::ListObjectImpl("", "two", "twokey"));
     o.back().entries.push_back(librados::ListObjectImpl("", "three", ""));
-    o.push_back(pg_nls_response_template<T>{});
+    o.emplace_back();
     o.back().handle = hobject_t(object_t("hi"), "key", 3, 4, -1, "");
     o.back().entries.push_back(librados::ListObjectImpl("n1", "n1one", ""));
     o.back().entries.push_back(librados::ListObjectImpl("n1", "n1two", "n1twokey"));
     o.back().entries.push_back(librados::ListObjectImpl("n1", "n1three", ""));
-    o.push_back(pg_nls_response_template<T>{});
+    o.emplace_back();
     o.back().handle = hobject_t(object_t("hi"), "key", 5, 6, -1, "");
     o.back().entries.push_back(librados::ListObjectImpl("", "one", ""));
     o.back().entries.push_back(librados::ListObjectImpl("", "two", "twokey"));
@@ -5540,8 +5540,8 @@ struct pg_ls_response_t {
   }
   static std::list<pg_ls_response_t> generate_test_instances() {
     std::list<pg_ls_response_t> o;
-    o.push_back(pg_ls_response_t{});
-    o.push_back(pg_ls_response_t{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().handle = hobject_t(object_t("hi"), "key", 1, 2, -1, "");
     o.back().entries.push_back(std::make_pair(object_t("one"), std::string()));
     o.back().entries.push_back(std::make_pair(object_t("two"), std::string("twokey")));
@@ -6741,8 +6741,8 @@ struct obj_list_watch_response_t {
   static std::list<obj_list_watch_response_t> generate_test_instances() {
     std::list<obj_list_watch_response_t> o;
     entity_addr_t ea;
-    o.push_back(obj_list_watch_response_t{});
-    o.push_back(obj_list_watch_response_t{});
+    o.emplace_back();
+    o.emplace_back();
     std::list<watch_item_t> test_watchers = watch_item_t::generate_test_instances();
     for (auto &e : test_watchers) {
       o.back().entries.push_back(e);
@@ -6801,14 +6801,14 @@ struct clone_info {
   }
   static std::list<clone_info> generate_test_instances() {
     std::list<clone_info> o;
-    o.push_back(clone_info{});
-    o.push_back(clone_info{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().cloneid = 1;
     o.back().snaps.push_back(1);
     o.back().overlap.push_back(std::pair<uint64_t,uint64_t>(0,4096));
     o.back().overlap.push_back(std::pair<uint64_t,uint64_t>(8192,4096));
     o.back().size = 16384;
-    o.push_back(clone_info{});
+    o.emplace_back();
     o.back().cloneid = CEPH_NOSNAP;
     o.back().size = 32768;
     return o;
@@ -6851,8 +6851,8 @@ struct obj_list_snap_response_t {
   }
   static std::list<obj_list_snap_response_t> generate_test_instances() {
     std::list<obj_list_snap_response_t> o;
-    o.push_back(obj_list_snap_response_t{});
-    o.push_back(obj_list_snap_response_t{});
+    o.emplace_back();
+    o.emplace_back();
     clone_info cl;
     cl.cloneid = 1;
     cl.snaps.push_back(1);
@@ -6975,7 +6975,7 @@ struct pool_pg_num_history_t {
   }
   static std::list<pool_pg_num_history_t> generate_test_instances() {
     std::list<pool_pg_num_history_t> ls;
-    ls.push_back(pool_pg_num_history_t{});
+    ls.emplace_back();
     return ls;
   }
   friend std::ostream& operator<<(std::ostream& out, const pool_pg_num_history_t& h) {
index 1948605004c17d0f2913af3dc4093f0c04bc2d82..cd5b77d01a888f8917dbc72da6ba3af4529083ad 100644 (file)
@@ -127,7 +127,7 @@ void resource_metadata::dump(ceph::Formatter* f) const
 std::list<resource_metadata> resource_metadata::generate_test_instances()
 {
   std::list<resource_metadata> o;
-  o.push_back(resource_metadata{});
+  o.emplace_back();
   resource_metadata m;
   m.group_id = "id";
   o.push_back(std::move(m));
index b3a868529e3a18c914e310a87168e07fb11cc2b6..c81717ee65ca137f547516ba981a8cc6f31ff58d 100644 (file)
@@ -3667,7 +3667,7 @@ list<RGWBucketEntryPoint> RGWBucketEntryPoint::generate_test_instances()
   bp.creation_time = ceph::real_clock::from_ceph_timespec({ceph_le32(2), ceph_le32(3)});
 
   o.push_back(std::move(bp));
-  o.push_back(RGWBucketEntryPoint{});
+  o.emplace_back();
 
   return o;
 }
index 25ff624b825ce18ed4e85c7deacea539b693c8e6..d3819290a1a6b3c8781aeca97b9ea2ac5b4f5576 100644 (file)
@@ -6676,7 +6676,7 @@ list<rgw_data_sync_info> rgw_data_sync_info::generate_test_instances()
   info.state = rgw_data_sync_info::StateBuildingFullSyncMaps;
   info.num_shards = 8;
   o.push_back(std::move(info));
-  o.push_back(rgw_data_sync_info{});
+  o.emplace_back();
   return o;
 }
 
@@ -6688,14 +6688,14 @@ list<rgw_data_sync_marker> rgw_data_sync_marker::generate_test_instances()
   marker.marker = "01234";
   marker.pos = 5;
   o.push_back(std::move(marker));
-  o.push_back(rgw_data_sync_marker{});
+  o.emplace_back();
   return o;
 }
 
 list<rgw_data_sync_status> rgw_data_sync_status::generate_test_instances()
 {
   list<rgw_data_sync_status> o;
-  o.push_back(rgw_data_sync_status{});
+  o.emplace_back();
   return o;
 }
 
index 3de1e530979012adc5e5def37f1d7ebd94a0b9bb..df2039b12d8cf7333210c83e1fdd1ff6ad5df258 100644 (file)
@@ -93,8 +93,8 @@ void rgw_data_change::decode_json(JSONObj *obj) {
 
 std::list<rgw_data_change> rgw_data_change::generate_test_instances() {
   std::list<rgw_data_change> l;
-  l.push_back(rgw_data_change{});
-  l.push_back(rgw_data_change{});
+  l.emplace_back();
+  l.emplace_back();
   l.back().entity_type = ENTITY_TYPE_BUCKET;
   l.back().key = "bucket_name";
   l.back().timestamp = ceph::real_clock::zero();
index eb5860031018e71597dd7e860aea65474d687016..7d3756bb647796025394b5b77278205c5e727019 100644 (file)
@@ -275,7 +275,7 @@ std::list<RGWObjManifestPart> RGWObjManifestPart::generate_test_instances()
 {
   std::list<RGWObjManifestPart> o;
 
-  o.push_back(RGWObjManifestPart{});
+  o.emplace_back();
 
   RGWObjManifestPart p;
   rgw_bucket b;
@@ -308,7 +308,7 @@ std::list<RGWObjManifest> RGWObjManifest::generate_test_instances()
   }
   m.set_explicit(total_size, objs);
   o.push_back(std::move(m));
-  o.push_back(RGWObjManifest{});
+  o.emplace_back();
   return o;
 }
 
@@ -384,7 +384,7 @@ std::list<RGWObjManifestRule> RGWObjManifestRule::generate_test_instances()
   r.stripe_max_size = 512 * 1024 * 1024;
   r.override_prefix = "override_prefix";
   o.push_back(std::move(r));
-  o.push_back(RGWObjManifestRule{});
+  o.emplace_back();
   return o;
 }
 
@@ -413,7 +413,7 @@ std::list<RGWObjTier> RGWObjTier::generate_test_instances()
   }
   t.is_multipart_upload = true;
   o.push_back(std::move(t));
-  o.push_back(RGWObjTier{});
+  o.emplace_back();
   return o;
 }
 
index fbcad2dead8f49a89176ef016f7e79f9b794da99..5b84285093c10ac8c896a1fa3c3c3ed061b7e0c2 100644 (file)
@@ -11583,7 +11583,7 @@ list<objexp_hint_entry> objexp_hint_entry::generate_test_instances()
   it.bucket_id = "1234";
   it.obj_key = rgw_obj_key("obj");
   o.push_back(std::move(it));
-  o.push_back(objexp_hint_entry{});
+  o.emplace_back();
   return o;
 }
 
@@ -11605,7 +11605,7 @@ list<RGWOLHInfo> RGWOLHInfo::generate_test_instances()
   RGWOLHInfo olh;
   olh.removed = false;
   o.push_back(olh);
-  o.push_back(RGWOLHInfo{});
+  o.emplace_back();
   return o;
 }
 
index b22681444dfe3c9d8cd3a5652a8e659f83522708..5581458d92e9c963065b202d8f121bda0a61da85 100644 (file)
@@ -62,8 +62,8 @@ struct RGWUID
   }
   static std::list<RGWUID> generate_test_instances() {
     std::list<RGWUID> o;
-    o.push_back(RGWUID{});
-    o.push_back(RGWUID{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().id = "test:tester";
     return o;
   }
index cd5d18146b1468a6c4aac252fdad7815b99c0a21..4473046859730747cf1e37a65cd5151a4bb7a676 100644 (file)
@@ -166,7 +166,7 @@ void resource_metadata::dump(ceph::Formatter* f) const
 std::list<resource_metadata> resource_metadata::generate_test_instances()
 {
   std::list<resource_metadata> o;
-  o.push_back(resource_metadata{});
+  o.emplace_back();
   resource_metadata m;
   m.role_id = "id";
   o.push_back(std::move(m));
index e08db4d3cd87f836794b09d654ac9c9731f24b6e..731cc5fe81d76c6ba1360614882b93d0baefdbe2 100644 (file)
@@ -166,7 +166,7 @@ void resource_metadata::dump(ceph::Formatter* f) const
 std::list<resource_metadata> resource_metadata::generate_test_instances()
 {
   std::list<resource_metadata> o;
-  o.push_back(resource_metadata{});
+  o.emplace_back();
   resource_metadata m;;
   m.user_id = "uid";
   o.push_back(std::move(m));
index 0a9a807872004cfb2ae8212a9fa9657ebf34c241..c00753520faa8d1c2a09f5afb8490182ecf39877 100644 (file)
@@ -260,7 +260,7 @@ list<ACLPermission> ACLPermission::generate_test_instances()
   ACLPermission p;
   p.set_permissions(RGW_PERM_WRITE_ACP);
   o.push_back(std::move(p));
-  o.push_back(ACLPermission{});
+  o.emplace_back();
   return o;
 }
 
@@ -314,7 +314,7 @@ list<ACLGrant> ACLGrant::generate_test_instances()
   g1.set_group(ACL_GROUP_AUTHENTICATED_USERS, RGW_PERM_WRITE);
   o.push_back(std::move(g2));
 
-  o.push_back(ACLGrant{});
+  o.emplace_back();
   return o;
 }
 
@@ -322,7 +322,7 @@ list<ACLGranteeType> ACLGranteeType::generate_test_instances()
 {
   list<ACLGranteeType> o;
   o.push_back(ACLGranteeType(ACL_TYPE_CANON_USER));
-  o.push_back(ACLGranteeType{});
+  o.emplace_back();
   return o;
 }
 
@@ -335,7 +335,7 @@ list<RGWAccessControlList> RGWAccessControlList::generate_test_instances()
     acl.add_grant(grant);
   }
   o.push_back(std::move(acl));
-  o.push_back(RGWAccessControlList{});
+  o.emplace_back();
   return o;
 }
 
@@ -346,7 +346,7 @@ list<ACLOwner> ACLOwner::generate_test_instances()
   owner.id = "rgw";
   owner.display_name = "Mr. RGW";
   o.push_back(std::move(owner));
-  o.push_back(ACLOwner{});
+  o.emplace_back();
   return o;
 }
 
@@ -364,7 +364,7 @@ list<RGWAccessControlPolicy> RGWAccessControlPolicy::generate_test_instances()
     o.push_back(std::move(p));
   }
 
-  o.push_back(RGWAccessControlPolicy{});
+  o.emplace_back();
 
   return o;
 }
index 4efe25f2ba6b0f32dfcb58fb3966f9c1b93ec5c8..f5d4450eefe31eed59c6c7472cc4d102a230e9c7 100644 (file)
@@ -84,7 +84,7 @@ list<rgw_bucket> rgw_bucket::generate_test_instances()
   rgw_bucket b;
   init_bucket(&b, "tenant", "name", "pool", ".index_pool", "marker", "123");
   o.push_back(std::move(b));
-  o.push_back(rgw_bucket{});
+  o.emplace_back();
   return o;
 }
 
@@ -128,7 +128,7 @@ list<rgw_user> rgw_user::generate_test_instances()
   rgw_user u("tenant", "user");
 
   o.push_back(u);
-  o.push_back(rgw_user{});
+  o.emplace_back();
   return o;
 }
 
index 19575af384fb63c4f8417d60622dada385907ac8..ff8d5606cf7cad1ee46353de5556f09349120e72 100644 (file)
@@ -83,7 +83,7 @@ struct rgw_zone_id {
 
   static std::list<rgw_zone_id> generate_test_instances() {
     std::list<rgw_zone_id> o;
-    o.push_back(rgw_zone_id{});
+    o.emplace_back();
     o.push_back(rgw_zone_id("id"));
     return o;
   }
index 71d8bada94a769aedc5734d1bd2eb901fa2ce2d8..0f5dea2694f28cee60a9b6d094bf145788a6ec1e 100644 (file)
@@ -363,7 +363,7 @@ list<ObjectMetaInfo> ObjectMetaInfo::generate_test_instances()
   ObjectMetaInfo m;
   m.size = 1024 * 1024;
   o.push_back(std::move(m));
-  o.push_back(ObjectMetaInfo{});
+  o.emplace_back();
   return o;
 }
 
@@ -392,7 +392,7 @@ list<ObjectCacheInfo> ObjectCacheInfo::generate_test_instances()
   i.rm_xattrs["r3"] = data;
   i.meta.size = 512 * 1024;
   o.push_back(std::move(i));
-  o.push_back(ObjectCacheInfo{});
+  o.emplace_back();
   return o;
 }
 
@@ -410,7 +410,7 @@ void ObjectCacheInfo::dump(Formatter *f) const
 list<RGWCacheNotifyInfo> RGWCacheNotifyInfo::generate_test_instances()
 {
   list<RGWCacheNotifyInfo> o;
-  o.push_back(RGWCacheNotifyInfo{});
+  o.emplace_back();
   return o;
 }
 
index 40895ca56b5b631907e658a8690de9597f5db9b9..22c7e44c1ce0137c2e6ccab203fc5f8d0bb5c14d 100644 (file)
@@ -2072,7 +2072,7 @@ void RGWUserCaps::dump(Formatter *f) const
 list<RGWUserCaps> RGWUserCaps::generate_test_instances()
 {
   list<RGWUserCaps> o;
-  o.push_back(RGWUserCaps{});
+  o.emplace_back();
   RGWUserCaps caps;
   caps.add_cap("read");
   caps.add_cap("write");
@@ -2525,7 +2525,7 @@ list<RGWBucketEnt> RGWBucketEnt::generate_test_instances()
   e.size_rounded = 4096;
   e.count = 1;
   o.push_back(std::move(e));
-  o.push_back(RGWBucketEnt{});
+  o.emplace_back();
   return o;
 }
 
@@ -2546,7 +2546,7 @@ list<rgw_obj> rgw_obj::generate_test_instances()
   rgw_bucket b;
   init_bucket(&b, "tenant", "bucket", "pool", ".index_pool", "marker", "10");
   o.push_back(rgw_obj(b, "object"));
-  o.push_back(rgw_obj{});
+  o.emplace_back();
   return o;
 }
 
@@ -2682,7 +2682,7 @@ list<RGWUserInfo> RGWUserInfo::generate_test_instances()
   i.subusers[u.name] = u;
   o.push_back(std::move(i));
 
-  o.push_back(RGWUserInfo{});
+  o.emplace_back();
   return o;
 }
 
@@ -2975,7 +2975,7 @@ list<RGWSubUser> RGWSubUser::generate_test_instances()
   u.name = "name";
   u.perm_mask = 0xf;
   o.push_back(std::move(u));
-  o.push_back(RGWSubUser{});
+  o.emplace_back();
   return o;
 }
 
@@ -3031,7 +3031,7 @@ list<RGWAccessKey> RGWAccessKey::generate_test_instances()
   k.key = "key";
   k.subuser = "subuser";
   o.push_back(std::move(k));
-  o.push_back(RGWAccessKey{});
+  o.emplace_back();
   return o;
 }
 
@@ -3135,7 +3135,7 @@ void RGWAccountInfo::decode_json(JSONObj* obj)
 std::list<RGWAccountInfo> RGWAccountInfo::generate_test_instances()
 {
   std::list<RGWAccountInfo> o;
-  o.push_back(RGWAccountInfo{});
+  o.emplace_back();
   auto p = RGWAccountInfo{};
   p.id = "account1";
   p.tenant = "tenant1";
@@ -3171,7 +3171,7 @@ void RGWGroupInfo::decode_json(JSONObj* obj)
 std::list<RGWGroupInfo> RGWGroupInfo::generate_test_instances()
 {
   std::list<RGWGroupInfo> o;
-  o.push_back(RGWGroupInfo{});
+  o.emplace_back();
   auto p = RGWGroupInfo{};
   p.id = "id";
   p.tenant = "tenant";
index ec62e9c7a8350e827d16b866747ff90b4fb39dc3..8aec72d4a99f4b658459ba02c75ec65447006f24 100644 (file)
@@ -1602,8 +1602,8 @@ struct multipart_upload_info
 
   static std::list<multipart_upload_info> generate_test_instances() {
     std::list<multipart_upload_info> o;
-    o.push_back(multipart_upload_info{});
-    o.push_back(multipart_upload_info{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().dest_placement.name = "dest_placement";
     o.back().dest_placement.storage_class = "dest_storage_class";
     return o;
index 08e8eacc6fd92e6678ffe2c90e48430af96b867b..4aa0d30b0afa5cede2549f39c7178f67a680e078 100644 (file)
@@ -68,8 +68,8 @@ void RGWCORSRule::erase_origin_if_present(string& origin, bool *rule_empty) {
 list<RGWCORSRule> RGWCORSRule::generate_test_instances()
 {
   list<RGWCORSRule> o;
-  o.push_back(RGWCORSRule{});
-  o.push_back(RGWCORSRule{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().id = "test";
   o.back().max_age = 100;
   o.back().allowed_methods = RGW_CORS_GET | RGW_CORS_PUT;
index 962ebecb812f1989c48e765a6c709d90a17c9a7f..0f7a46921321b60f62326dcff8894e385086f9ea 100644 (file)
@@ -28,7 +28,7 @@ list<obj_version> obj_version::generate_test_instances()
   v.tag = "tag";
 
   o.push_back(std::move(v));
-  o.push_back(obj_version{});
+  o.emplace_back();
   return o;
 }
 
@@ -42,6 +42,6 @@ std::list<RGWBucketEncryptionConfig> RGWBucketEncryptionConfig::generate_test_in
   bc = RGWBucketEncryptionConfig("AES256");
   o.push_back(std::move(bc));
 
-  o.push_back(RGWBucketEncryptionConfig{});
+  o.emplace_back();
   return o;
 }
index eaae450c966a14cb02889a010cf91243faf200a2..b462d4247a2d962f0418d39c5483b459dc18743e 100644 (file)
@@ -2676,7 +2676,7 @@ RGWLC::LCWorker::~LCWorker()
 list<RGWLifecycleConfiguration> RGWLifecycleConfiguration::generate_test_instances()
 {
   list<RGWLifecycleConfiguration> o;
-  o.push_back(RGWLifecycleConfiguration{});
+  o.emplace_back();
   return o;
 }
 
index 8cd0250b49e5b2c0e33c7f951afd31920edbd0ba..7f770c2cd2d4e75ba8e687a43d6bccd98feb69d2 100644 (file)
@@ -703,7 +703,7 @@ list<rgw_log_entry> rgw_log_entry::generate_test_instances()
   e.account_id = "account_id";
   e.role_id = "role_id";
   o.push_back(std::move(e));
-  o.push_back(rgw_log_entry{});
+  o.emplace_back();
   return o;
 }
 
index 83b85ef15c321274790884980b0c83d317d2cf85..45db3ff0aac5b7834e131ac45e0436d888f9be57 100644 (file)
@@ -99,8 +99,8 @@ void RGWMetadataLogData::decode_json(JSONObj *obj) {
 
 std::list<RGWMetadataLogData> RGWMetadataLogData::generate_test_instances() {
   std::list<RGWMetadataLogData> l;
-  l.push_back(RGWMetadataLogData{});
-  l.push_back(RGWMetadataLogData{});
+  l.emplace_back();
+  l.emplace_back();
   l.back().read_version = obj_version();
   l.back().read_version.tag = "read_tag";
   l.back().write_version = obj_version();
index 5f369d1cd0fc58c2294a7b07a1ffa3129efc9523..95454086b34a6b19f6bfc3815ebaaab1783e5057 100644 (file)
@@ -89,7 +89,7 @@ list<RGWUploadPartInfo> RGWUploadPartInfo::generate_test_instances()
   i.size = 10 * 1024 * 1024;
   i.etag = "etag";
   o.push_back(std::move(i));
-  o.push_back(RGWUploadPartInfo{});
+  o.emplace_back();
   return o;
 }
 
index 227c96d931e587d3f193c247edcc1cc960a12fbe..67f00b5db2697e68cfb72aa03a4c44feca98a776 100644 (file)
@@ -90,8 +90,8 @@ struct rgw_obj_index_key { // cls_rgw_obj_key now aliases this type
   void decode_json(JSONObj *obj);
   static std::list<rgw_obj_index_key> generate_test_instances() {
     std::list<rgw_obj_index_key> ls;
-    ls.push_back(rgw_obj_index_key{});
-    ls.push_back(rgw_obj_index_key{});
+    ls.emplace_back();
+    ls.emplace_back();
     ls.back().name = "name";
     ls.back().instance = "instance";
     return ls;
index ecb5a5fe9881bd8ba1502356d184e3a1e94ba5f1..6b0bd0232a3b4795a89c007dffa0f5ae97328fd6 100644 (file)
@@ -51,7 +51,7 @@ void ObjectLockRule::dump(Formatter *f) const {
 
 std::list<ObjectLockRule> ObjectLockRule::generate_test_instances() {
   std::list<ObjectLockRule> o;
-  o.push_back(ObjectLockRule{});
+  o.emplace_back();
   return o;
 }
 
index b22cc9cc4d31bda8ba8a9f877867c8d80e26c8b2..4c0a21ed76dab207b36d654ca291ee770c4b7e78 100644 (file)
@@ -38,6 +38,6 @@ std::list<RGWOIDCProviderInfo> RGWOIDCProviderInfo::generate_test_instances()
   p.client_ids = {"a", "b"};
   p.thumbprints = {"c", "d"};
   l.push_back(std::move(p));
-  l.push_back(RGWOIDCProviderInfo{});
+  l.emplace_back();
   return l;
 }
index 4c78df1b66af91ec7fdb6ac48d89b4f16e17ffe7..b4761114d09f2d1560e11aa95b3a659d6ad16e58 100644 (file)
@@ -96,7 +96,7 @@ struct rgw_placement_rule {
 
   static std::list<rgw_placement_rule> generate_test_instances() {
     std::list<rgw_placement_rule> o;
-    o.push_back(rgw_placement_rule{});
+    o.emplace_back();
     o.push_back(rgw_placement_rule("name", "storage_class"));
     return o;
   }
index 0a84f57d4712b54887e25501a0fbf287f7c631de..bbc9c774a14a2ffa48eedeaf984d04d7da533738 100644 (file)
@@ -97,7 +97,7 @@ struct rgw_pool {
 
   static std::list<rgw_pool> generate_test_instances() {
     std::list<rgw_pool> o;
-    o.push_back(rgw_pool{});
+    o.emplace_back();
     o.push_back(rgw_pool("pool", "ns"));
     return o;
   }
index 4334241f1135c21e6072d8106edf69e6d7d74613..68a9eb83d782fca39e15e3e563d96dcf0fde62b4 100644 (file)
@@ -1042,8 +1042,8 @@ void RGWQuotaInfo::dump(Formatter *f) const
 std::list<RGWQuotaInfo> RGWQuotaInfo::generate_test_instances()
 {
   std::list<RGWQuotaInfo> o;
-  o.push_back(RGWQuotaInfo{});
-  o.push_back(RGWQuotaInfo{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().enabled = true;
   o.back().check_on_raw = true;
   o.back().max_size = 1024;
index 4ee4b833b29950403911993fdfea86edc4afd2dc..c8a075592d66bbd5f9bcc52a6d7a6f56a1de3f10 100644 (file)
@@ -86,8 +86,8 @@ int RGWRealm::find_zone(const DoutPrefixProvider *dpp,
 list<RGWRealm> RGWRealm::generate_test_instances()
 {
   list<RGWRealm> o;
-  o.push_back(RGWRealm{});
-  o.push_back(RGWRealm{});
+  o.emplace_back();
+  o.emplace_back();
   return o;
 }
 
index 8c1ce02ceff275856f3151e64c3d5ec9edc33562..16fe5aae5e9de46eaf53f0c0448487d6919ce4d5 100644 (file)
@@ -792,7 +792,7 @@ void rgw_sync_policy_info::dump(Formatter *f) const
 list<rgw_sync_policy_info> rgw_sync_policy_info::generate_test_instances()
 {
   list<rgw_sync_policy_info> o;
-  o.push_back(rgw_sync_policy_info{});
+  o.emplace_back();
   return o;
 }
 
index 85cb3dcfd2d77d1f6e4ca8c4766a327e0dfb57c4..5489fef942953763606d7724ae5325e9b043dd2d 100644 (file)
@@ -72,7 +72,7 @@ std::list<RGWObjTags> RGWObjTags::generate_test_instances()
   r.add_tag("key1","val1");
   r.add_tag("key2","val2");
   o.push_back(std::move(r));
-  o.push_back(RGWObjTags{});
+  o.emplace_back();
   return o;
 }
 
index 951ebb8904403f150e45b9d3a5eaa4bd485bd807..23323ab76c2cce9bf7fa12cd98f94caae55cd9df 100644 (file)
@@ -71,8 +71,8 @@ static void decode_placement_targets(map<string, RGWZoneGroupPlacementTarget>& t
 list<RGWZone> RGWZone::generate_test_instances()
 {
   list<RGWZone> o;
-  o.push_back(RGWZone{});
-  o.push_back(RGWZone{});
+  o.emplace_back();
+  o.emplace_back();
   return o;
 }
 
@@ -511,8 +511,8 @@ void RGWZonePlacementInfo::dump(Formatter *f) const
 list<RGWZonePlacementInfo> RGWZonePlacementInfo::generate_test_instances()
 {
   list<RGWZonePlacementInfo> o;
-  o.push_back(RGWZonePlacementInfo{});
-  o.push_back(RGWZonePlacementInfo{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().index_pool = rgw_pool("rgw.buckets.index");
   
   o.back().data_extra_pool = rgw_pool("rgw.buckets.non-ec");
@@ -585,7 +585,7 @@ void RGWZoneStorageClasses::dump(Formatter *f) const
 list<RGWZoneStorageClasses> RGWZoneStorageClasses::generate_test_instances()
 {
   list<RGWZoneStorageClasses> o;
-  o.push_back(RGWZoneStorageClasses{});
+  o.emplace_back();
   return o;
 }
 
@@ -672,8 +672,8 @@ void RGWZoneStorageClass::dump(Formatter *f) const
 list<RGWZoneStorageClass> RGWZoneStorageClass::generate_test_instances()
 {
   list<RGWZoneStorageClass> o;
-  o.push_back(RGWZoneStorageClass{});
-  o.push_back(RGWZoneStorageClass{});
+  o.emplace_back();
+  o.emplace_back();
   o.back().data_pool = rgw_pool("pool1");
   o.back().compression_type = "zlib";
   return o;
index 44ece58143e481277dcf6a3155eab7fd2c0b72d5..e56b8e7f406f9d8f6338c766384a02d25143ea46 100644 (file)
@@ -572,7 +572,7 @@ struct RGWZoneGroupTierS3Glacier {
   void decode_json(JSONObj *obj);
   static std::list<RGWZoneGroupTierS3Glacier> generate_test_instances() {
     std::list<RGWZoneGroupTierS3Glacier> o;
-    o.push_back(RGWZoneGroupTierS3Glacier{});
+    o.emplace_back();
     o.back().glacier_restore_days = 2;
     o.back().glacier_restore_tier_type = GlacierRestoreTierType::Expedited;
     return o;
@@ -671,8 +671,8 @@ struct RGWZoneGroupPlacementTier {
   void decode_json(JSONObj *obj);
   static std::list<RGWZoneGroupPlacementTier> generate_test_instances() {
     std::list<RGWZoneGroupPlacementTier> o;
-    o.push_back(RGWZoneGroupPlacementTier{});
-    o.push_back(RGWZoneGroupPlacementTier{});
+    o.emplace_back();
+    o.emplace_back();
     o.back().tier_type = RGWTierType::CLOUD_S3;
     o.back().storage_class = RGW_STORAGE_CLASS_STANDARD;
     o.back().allow_read_through = false;
@@ -730,9 +730,9 @@ struct RGWZoneGroupPlacementTarget {
   void decode_json(JSONObj *obj);
   static std::list<RGWZoneGroupPlacementTarget> generate_test_instances() {
     std::list<RGWZoneGroupPlacementTarget> o;
-    o.push_back(RGWZoneGroupPlacementTarget{});
+    o.emplace_back();
     o.back().storage_classes.insert(RGW_STORAGE_CLASS_STANDARD);
-    o.push_back(RGWZoneGroupPlacementTarget{});
+    o.emplace_back();
     o.back().name = "target";
     o.back().tags.insert("tag1");
     o.back().tags.insert("tag2");