Merge pull request #12403 from liewegas/wip-mon-mgr-cleanups

mon: clean up some osdmon/pgmon interactions

Reviewed-by: Kefu Chai <kchai@redhat.com>

diff --cc qa/workunits/cephtool/test.sh
Simple merge

diff --cc src/common/config_opts.h
Simple merge

diff --cc src/mon/Elector.cc
Simple merge

diff --cc src/mon/MonCommands.h
Simple merge

diff --cc src/mon/Monitor.cc
Simple merge

diff --cc src/mon/Monitor.h
Simple merge

diff --cc src/mon/MonmapMonitor.cc
Simple merge

diff --cc src/mon/OSDMonitor.cc
index 8c6c5fb0fa828456bca55ce4c8b9b41998fe2a71,e9ca79fdeb758aa2da7a5a5dd7c3b3bbcf931c28..f4474a5220beb16fa495f44b1fdda2dd16b4c39f
--- 1/src/mon/OSDMonitor.cc
--- 2/src/mon/OSDMonitor.cc
+++ b/src/mon/OSDMonitor.cc
@@@ -5326,29 -5181,7 +5201,21 @@@ int OSDMonitor::prepare_command_pool_se
        ss << "specified pgp_num " << n << " > pg_num " << p.get_pg_num();
        return -EINVAL;
      }
-     for(set<pg_t>::iterator i = mon->pgmon()->pg_map.creating_pgs.begin();
-       i != mon->pgmon()->pg_map.creating_pgs.end();
-       ++i) {
-       if (i->m_pool == static_cast<uint64_t>(pool)) {
-       ss << "currently creating pgs, wait";
-       return -EBUSY;
-       }
-     }
      p.set_pgp_num(n);
 +  } else if (var == "crush_rule") {
 +    int id = osdmap.crush->get_rule_id(val);
 +    if (id == -ENOENT) {
 +      ss << "crush rule " << val << " does not exist";
 +      return -ENOENT;
 +    }
 +    if (id < 0) {
 +      ss << cpp_strerror(id);
 +      return -ENOENT;
 +    }
 +    if (!osdmap.crush->check_crush_rule(id, p.get_type(), p.get_size(), ss)) {
 +      return -EINVAL;
 +    }
 +    p.crush_ruleset = id;
    } else if (var == "crush_ruleset") {
      if (interr.length()) {
        ss << "error parsing integer value '" << val << "': " << interr;

diff --cc src/osd/OSDMap.h
Simple merge

diff --cc src/test/pybind/test_ceph_argparse.py
Simple merge