]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commitdiff
tools/mvtest: ensure testcase is executable (755)
authorShiyang Ruan <ruansy.fnst@fujitsu.com>
Fri, 8 Sep 2023 05:43:35 +0000 (13:43 +0800)
committerZorro Lang <zlang@kernel.org>
Wed, 20 Sep 2023 07:49:54 +0000 (15:49 +0800)
Some test cases lack executable permission ('x'). Before running each
test case, `./check` checks and grants them 'x' permission. However,
this always leads to a dirty git repo. And the absence of 'x' permission
in test cases is often overlooked during reviews.

Since maintainers use mvtest to assign new case, add this change for
convenience of maintainers.

Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>
Reviewed-by: Zorro Lang <zlang@redhat.com>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Zorro Lang <zlang@kernel.org>
tools/mvtest

index 99b1541429317ff6fcf2438b4173a520673cf865..09a9982b7f807e8c766c3c00139bcd2917b3fcda 100755 (executable)
@@ -34,6 +34,8 @@ did="$(basename "${dest}")"
 
 git mv "tests/${src}" "tests/${dest}"
 git mv "tests/${src}.out" "tests/${dest}.out"
+# make sure testcase is executable
+chmod a+x "tests/${dest}"
 sed -e "s/^# FS[[:space:]]*QA.*Test.*[0-9]\+$/# FS QA Test No. ${did}/g" -i "tests/${dest}"
 sed -e "s/^QA output created by ${sid}$/QA output created by ${did}/g" -i "tests/${dest}.out"
 sed -e "s/test-${sid}/test-${did}/g" -i "tests/${dest}.out"