]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph-client.git/commitdiff
ceph: remove unnecessary assignment
authorChengguang Xu <cgxu519@gmx.com>
Fri, 17 Aug 2018 14:05:31 +0000 (22:05 +0800)
committerJeff Layton <jlayton@kernel.org>
Mon, 23 Sep 2019 13:27:21 +0000 (09:27 -0400)
ceph_pagelist_encode_string() will not fail in reserved case,
also, we do not check err code here, so remove unnecessary
assignment.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
fs/ceph/acl.c

index aa55f412a6e35c01d6024b62f2031b619a0e3a08..26be6520d3fb1ec43799ff42bf7541f9a6ffa282 100644 (file)
@@ -222,8 +222,8 @@ int ceph_pre_init_acls(struct inode *dir, umode_t *mode,
                err = ceph_pagelist_reserve(pagelist, len + val_size2 + 8);
                if (err)
                        goto out_err;
-               err = ceph_pagelist_encode_string(pagelist,
-                                                 XATTR_NAME_POSIX_ACL_DEFAULT, len);
+               ceph_pagelist_encode_string(pagelist,
+                                         XATTR_NAME_POSIX_ACL_DEFAULT, len);
                err = posix_acl_to_xattr(&init_user_ns, default_acl,
                                         tmp_buf, val_size2);
                if (err < 0)