debug log_writer

diff --git a/db/db_impl.cc b/db/db_impl.cc
index 6e776f550e967f2b2baedde012da313d14706a9c..148fe171885d20cc871f8194e984cc2954181347 100644 (file)
--- a/db/db_impl.cc
+++ b/db/db_impl.cc
@@ -1128,7 +1128,8 @@ Status DBImpl::RecoverLogFiles(const std::vector<uint64_t>& log_numbers,
     // to be skipped instead of propagating bad information (like overly
     // large sequence numbers).
     log::Reader reader(db_options_.info_log, std::move(file_reader), &reporter,
-                       true /*checksum*/, 0 /*initial_offset*/, log_number);
+                       true /*checksum*/, 0 /*initial_offset*/, log_number,
+                      &db_options_);
     Log(InfoLogLevel::INFO_LEVEL, db_options_.info_log,
         "Recovering log #%" PRIu64 " mode %d skip-recovery %d", log_number,
         db_options_.wal_recovery_mode, !continue_replay_log);
@@ -4309,8 +4310,10 @@ Status DBImpl::SwitchMemtable(ColumnFamilyData* cfd, WriteContext* context) {
                                          mutable_cf_options.write_buffer_size);
         unique_ptr<WritableFileWriter> file_writer(
             new WritableFileWriter(std::move(lfile), opt_env_opt));
-        new_log = new log::Writer(std::move(file_writer), new_log_number,
-                                  db_options_.recycle_log_file_num > 0);
+        new_log = new log::Writer(std::move(file_writer),
+                                 new_log_number,
+                                  db_options_.recycle_log_file_num > 0,
+                                 &db_options_);
       }
     }
 
@@ -4990,7 +4993,8 @@ Status DB::Open(const DBOptions& db_options, const std::string& dbname,
       impl->logs_.emplace_back(
           new_log_number,
           new log::Writer(std::move(file_writer), new_log_number,
-                          impl->db_options_.recycle_log_file_num > 0));
+                          impl->db_options_.recycle_log_file_num > 0,
+                         &impl->db_options_));
 
       // set column family handles
       for (auto cf : column_families) {

diff --git a/db/log_reader.cc b/db/log_reader.cc
index 1ed8daa801fd5b3efab320e8f9ced1ea56a667e1..b70d21e38c9675f4ca68d9f5fec56fe5b3e75a75 100644 (file)
--- a/db/log_reader.cc
+++ b/db/log_reader.cc
@@ -22,9 +22,12 @@ Reader::Reporter::~Reporter() {
 }
 
 Reader::Reader(std::shared_ptr<Logger> info_log,
-               unique_ptr<SequentialFileReader>&& _file, Reporter* reporter,
-               bool checksum, uint64_t initial_offset, uint64_t log_num)
-    : info_log_(info_log),
+              unique_ptr<SequentialFileReader>&& _file,
+               Reporter* reporter, bool checksum, uint64_t initial_offset,
+               uint64_t log_num,
+              const DBOptions *opt)
+    : db_options_(opt),
+      info_log_(info_log),
       file_(std::move(_file)),
       reporter_(reporter),
       checksum_(checksum),
@@ -410,9 +413,10 @@ unsigned int Reader::ReadPhysicalRecord(Slice* result, size_t* drop_size) {
     }
 
     // Check crc
+    uint32_t actual_crc = 0;
     if (checksum_) {
       uint32_t expected_crc = crc32c::Unmask(DecodeFixed32(header));
-      uint32_t actual_crc = crc32c::Value(header + 6, length + header_size - 6);
+      actual_crc = crc32c::Value(header + 6, length + header_size - 6);
       if (actual_crc != expected_crc) {
         // Drop the rest of the buffer since "length" itself may have
         // been corrupted and if we trust it, we could find some
@@ -433,6 +437,15 @@ unsigned int Reader::ReadPhysicalRecord(Slice* result, size_t* drop_size) {
       return kBadRecord;
     }
 
+    if (db_options_)
+      Log(InfoLogLevel::DEBUG_LEVEL, db_options_->info_log,
+       "ReadPhysicalRecord: log %lld offset %lld len %d crc %d type %d",
+         (unsigned long long)log_number_,
+         (unsigned long long)(end_of_buffer_offset_ - buffer_.size() -
+                              header_size - length),
+         (int)header_size + (int)length, crc32c::Mask(actual_crc),
+         type);
+    
     *result = Slice(header + header_size, length);
     return type;
   }

diff --git a/db/log_reader.h b/db/log_reader.h
index d0d7ad6f3472c74f55d02c9dd89e35d948006ce8..2b7aca88316dc2bb70485b17c9610d54fe3ccb1d 100644 (file)
--- a/db/log_reader.h
+++ b/db/log_reader.h
@@ -19,6 +19,7 @@
 namespace rocksdb {
 
 class SequentialFileReader;
+class DBOptions;
 class Logger;
 using std::unique_ptr;
 
@@ -56,7 +57,8 @@ class Reader {
   Reader(std::shared_ptr<Logger> info_log,
         unique_ptr<SequentialFileReader>&& file,
          Reporter* reporter, bool checksum, uint64_t initial_offset,
-         uint64_t log_num);
+         uint64_t log_num,
+        const DBOptions *opt = NULL);
 
   ~Reader();
 
@@ -89,6 +91,7 @@ class Reader {
   SequentialFileReader* file() { return file_.get(); }
 
  private:
+  const DBOptions *db_options_;
   std::shared_ptr<Logger> info_log_;
   const unique_ptr<SequentialFileReader> file_;
   Reporter* const reporter_;

diff --git a/db/log_writer.cc b/db/log_writer.cc
index 84780d87f25dc2aef125ec1733385d05788cf4ba..98843bdd44832f546d8bfbe9aac73fcd21307a03 100644 (file)
--- a/db/log_writer.cc
+++ b/db/log_writer.cc
@@ -11,6 +11,7 @@
 
 #include <stdint.h>
 #include "rocksdb/env.h"
+#include "rocksdb/options.h"
 #include "util/coding.h"
 #include "util/crc32c.h"
 #include "util/file_reader_writer.h"
@@ -19,8 +20,10 @@ namespace rocksdb {
 namespace log {
 
 Writer::Writer(unique_ptr<WritableFileWriter>&& dest,
-               uint64_t log_number, bool recycle_log_files)
-    : dest_(std::move(dest)),
+               uint64_t log_number, bool recycle_log_files,
+              const DBOptions *opt)
+    : db_options_(opt),
+      dest_(std::move(dest)),
       block_offset_(0),
       log_number_(log_number),
       recycle_log_files_(recycle_log_files) {
@@ -122,6 +125,14 @@ Status Writer::EmitPhysicalRecord(RecordType t, const char* ptr, size_t n) {
   crc = crc32c::Mask(crc);  // Adjust for storage
   EncodeFixed32(buf, crc);
 
+  if (db_options_)
+    Log(InfoLogLevel::DEBUG_LEVEL, db_options_->info_log,
+       "EmitPhysicalRecord: log %lld offset %lld len %d crc %d",
+       (unsigned long long)log_number_,
+       (unsigned long long)dest_->GetFileSize(),
+       (int)header_size + (int)n,
+       crc);
+
   // Write the header and the payload
   Status s = dest_->Append(Slice(buf, header_size));
   if (s.ok()) {

diff --git a/db/log_writer.h b/db/log_writer.h
index 876e4c56fc81f324494dbeac05bfc2627afa59ad..28f94a0208ac03193a424478ae9ef6c007ee99f3 100644 (file)
--- a/db/log_writer.h
+++ b/db/log_writer.h
@@ -19,6 +19,7 @@
 namespace rocksdb {
 
 class WritableFileWriter;
+class DBOptions;
 
 using std::unique_ptr;
 
@@ -73,7 +74,8 @@ class Writer {
   // "*dest" must be initially empty.
   // "*dest" must remain live while this Writer is in use.
   explicit Writer(unique_ptr<WritableFileWriter>&& dest,
-                  uint64_t log_number, bool recycle_log_files);
+                  uint64_t log_number, bool recycle_log_files,
+                 const DBOptions *opt = NULL);
   ~Writer();
 
   Status AddRecord(const Slice& slice);
@@ -82,6 +84,7 @@ class Writer {
   const WritableFileWriter* file() const { return dest_.get(); }
 
  private:
+  const DBOptions *db_options_;
   unique_ptr<WritableFileWriter> dest_;
   size_t block_offset_;       // Current offset in block
   uint64_t log_number_;